266774 - Start page URL is wrong in region.properties and bookmarks.html (404)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[:Gavin Sharp [email: [e-mail]]]

See bug 266000 comment 14 and bug 266000 comment 20.

Region.properties contains different links to start pages.

http://www.mozilla.org/products/firefox/start/ and
http://start.mozilla.org/firefox/

Of the two, the second one works best. The first uses javascript to redirect,
which causes the user to see the 0.8 start page if they have javascript turned
off. I will attach a patch changing them all to the second link.

As a side-issue, I think that the http://start.mozilla.org/firefox/ link should
redirect to the Firefox Central page at
http://www.mozilla.org/firefox/central.html, since it is geared towards users
who have already downloaded Firefox. See bug 266000 comment 2.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch 1

Comment 2

[Michael Lefevre]

regarding the side issue - from the discussion in the localisation group,
there's going to be a new start page (which is not done yet), which I assume
that will redirect to. So that's not an issue.

Comment 3

[Asa Dotzler [:asa]]

Is this still a problem? Didn't we get new URLs about a week ago?

Comment 4

[Michael Lefevre]

I must confess I'm not following what the various URLs are supposed to be, but
the ones mentioned in this file haven't changed - it still uses
http://www.mozilla.org/products/firefox/start/ for the start page rather than
http://start.mozilla.org/firefox/ . Both of those currently redirect to the main
/products/firefox page.

The ones that changed were, I think, the default bookmarks and the throbber.

Comment 5

[Asa Dotzler [:asa]]

ben says this doesn't matter.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

It was a minor problem to begin with, which only affected those who used the
default start page with javascript turned off. As far as I can tell, the /start/
link has since been fixed to use a server side redirect instead of javascript,
so that makes this basically a non-issue. This should still be fixed IMO, to
ensure that there is only one page to manage and also to simplify things.
Although it is just a simple substitution, it definitely does not block 1.0.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

http://start.mozilla.org/firefox/ no longer works because of the google redirection.

http://start.mozilla.org/firefox

should be used instead.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch 2

Comment 9

[:Gavin Sharp [email: [e-mail]]]

*** Bug 272290 has been marked as a duplicate of this bug. ***

Comment 10

[Phil Ringnalda (:philor)]

*** Bug 275435 has been marked as a duplicate of this bug. ***

Comment 11

[Phil Ringnalda (:philor)]

*** Bug 277401 has been marked as a duplicate of this bug. ***

Comment 12

[:Gavin Sharp [email: [e-mail]]]

*** Bug 284513 has been marked as a duplicate of this bug. ***

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 167729 [details] [diff] [review]
Patch 2

This looks fine to me from a are-all-the-equal-signs-in-the-right-place point
of view, but I'm definitely not the right person to make the call as to whether
the URLs are right.  rebron/cbeard/asa or someone should probably review this
instead.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

rebron/cbeard/asa, have any ideas on whether this is the desired patch?

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 167729 [details] [diff] [review]
Patch 2

This looks good to me.

Comment 16

[Steffen Wilberg]

Checking in mozilla/browser/locales/en-US/chrome/browser-region/region.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser-region/region.properties,v
 <--  region.properties
new revision: 1.6; previous revision: 1.5
done
Checking in mozilla/browser/locales/en-US/profile/bookmarks.html;
/cvsroot/mozilla/browser/locales/en-US/profile/bookmarks.html,v  <--  bookmarks.html
new revision: 1.4; previous revision: 1.3
done

Comment 17

[Jaime Mitchell (use [e-mail] for email)]

As nothing has happened in bug 268603 can this (simple) patch not be ported to
the branch to correct this visiable error.

(asking for blocking to check if this is a possibility)

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Attachment: 1.0.1 branch patch, bookmarks only

Comment 19

[Daniel Veditz [:dveditz]]

Not blocking 1.0.5

A bookmark patch doesn't help people who already created their profile, and the
.property file changes run afoul the localization teams (which is why Gavin
dropped them from the branch patch I'm sure). Rafael is working on getting the
redirect fixed so http://start.mozilla.org/firefox/ is not 404

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 188489 [details] [diff] [review]
1.0.1 branch patch, bookmarks only

1.0.5 has already shipped; unsetting approval request

Comment 21

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change