Closed Bug 27233 Opened 25 years ago Closed 24 years ago

JS fill-in is very slow

Categories

(Core :: DOM: Core & HTML, defect, P1)

x86
All
defect

Tracking

()

VERIFIED DUPLICATE of bug 53165
mozilla0.9.1

People

(Reporter: sdwyer, Assigned: rods)

References

()

Details

(Keywords: perf)

Attachments

(1 file)

The javascript fill-in on the bug reporting form is very slow. I would guess that if you use any form and dynamically repopulate a form with JS it would be very slow.
*** Bug 27229 has been marked as a duplicate of this bug. ***
passing on to Don. Should someone in your group own this?
Assignee: phil → don
correcting the product to Browser
Component: Back End → Browser-General
Product: MailNews → Browser
QA Contact: lchiang → gerardok
Prashant, please could you look at this? Thanks
QA Contact: gerardok → desale
Component: Browser-General → Form Submission
Reassigning as per Don
Assignee: don → rods
QA Contact: desale → ckritzer
setting to M17
Target Milestone: --- → M17
This is a known issue with to many reflows being scheduled when selects are filled in via script
Status: NEW → ASSIGNED
Keywords: perf
*** Bug 32920 has been marked as a duplicate of this bug. ***
Attached file simple textcase
*** Bug 45017 has been marked as a duplicate of this bug. ***
*** Bug 45075 has been marked as a duplicate of this bug. ***
Adding nsbeta3 keyword. This makes the bugzilla query page really ugly: try loading the query page, then change Product to Mail, and watch for 3-5 seconds (Linux optimized build) as the combo boxes repaint over and over and over again.
Keywords: nsbeta3
OS: Windows NT → All
QA Contact: ckritzer
Nisheeth's comment from an e-mail: I see two possible solutions here: 1) Send it to Moz Cafe for lunch so that it comes back really fast. 2) We could use the BeginReflowBatching/EndReflowBatching API on the pres shell to batch reflows during the EvaluateScript() call in the content sink. This should help as long as the script does not repeatedly call property getter methods that flush pending reflow commands because they require the frame model to be up to date.
Marking nsbeta3- This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
Whiteboard: [nsbeta3-]
Target Milestone: M17 → Future
*** Bug 52791 has been marked as a duplicate of this bug. ***
Triaging QA. Jan, is this yours?
QA Contact: janc
*** Bug 53942 has been marked as a duplicate of this bug. ***
*** Bug 53960 has been marked as a duplicate of this bug. ***
It certainly could be effecting it, but I would be suprised if it is completely responsible for it. I'll set it as a dependency so I can test when Bug 30091 is fixed.
Depends on: 30091
Adding bug 46298 as blocking this bug.
Depends on: 46298
*** Bug 60684 has been marked as a duplicate of this bug. ***
I will take another look at this, it may get faster with lazy dropdowns
Severity: normal → major
Priority: P3 → P1
Whiteboard: [nsbeta3-]
Target Milestone: Future → ---
Keywords: mostfreq
The problem here seems to be that we are causing lots of reflows by calls to nsGenericHTMLElement::GetPrimaryFrame(), which calls nsHTMLDocument::FlushPendingNotifications. In the case of bugzilla query page component switching, these calls are coming from nsHTMLOptionElement::GetSelected(). In the case of loading test8 (although it doesn't account for as much of the time there), they're coming from nsHTMLTextAreaElement::HandleDOMEvent and nsHTMLSelectElement::HandleDOMEvent. GetPrimaryFrame does take an extra argument (with a default value of PR_TRUE) for whether to flush notifications, but that may or may not be the correct solution...
*** Bug 69979 has been marked as a duplicate of this bug. ***
Going to take another look and see why we are flushing the pending events each time.
Target Milestone: --- → mozilla0.9.1
QA Contact -> gerardok
QA Contact: janc → gerardok
*** Bug 73396 has been marked as a duplicate of this bug. ***
*** Bug 74060 has been marked as a duplicate of this bug. ***
Blocks: 71668
*** This bug has been marked as a duplicate of 53165 ***
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
verified dup
Status: RESOLVED → VERIFIED
Component: HTML: Form Submission → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: