Closed Bug 272456 Opened 20 years ago Closed 20 years ago

Default text color not set

Categories

(Bugzilla :: User Interface, defect, P1)

Product:
Bugzilla
Component:
User Interface
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.20

People

(Reporter: paul, Assigned: myk)

References

(Blocks 1 open bug,
URL
)

Details

Attachments

(1 file)

patch v1: fixes problem
2.87 KB, patch
justdave
: review+
LpSolit
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041119 Firefox/1.0 (Debian package 1.0-3)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041119 Firefox/1.0 (Debian package 1.0-3)

This, and most other bugzilla pages set the page background color. However they
do not set the default text color. This makes them unreadable on a desktop with
a light-on-dark default colorscheme.

bugzilla tip global stylesheets don't fix this problem. I guess the stylesheet
doesn't set the text color.

Reproducible: Always
Steps to Reproduce:
1. Change default colorscheme to something with light color text
2. Try to read bugzilla pages.
Actual Results:  
Page displayed with (default) light colored text on a white background

Expected Results:  
Text color should be set to something suitable (eg. black)
I agree, we should set: body {color: black; background-color: white} by default.
This affect bug lists as well -> bug 130276.
Blocks: 130276
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 255524 has been marked as a duplicate of this bug. ***
*** Bug 279652 has been marked as a duplicate of this bug. ***
Flags: blocking2.20?
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.20
Is anybody going to do anything about this? There are even non-mozilla bugzillas
that have wrong colors. Can't the default templates be correct HTML?

It is really simple to fix. Just somebody who has the power has to do it.

I currently cannot read most of the bugzilla text/links until I select it.

<body bgcolor="#ffffff" onload=""
        class="bugzilla-mozilla-org bz_bug bz_status_NEW
bz_component_User_Interface bz_bug_272456"
        > is apparently wrong. No colors for text/links. No reason to set colors
at all since stylesheets are applied anyway.

And there are two stylesheets applied to this page for some reason. The second
one is empty and I cannot find anything in the first one that would set the
default colors, although it is quite long.

Something like this should set default colors and fix these problems for good. 

body { color: #000; background-color: #fff; }
:link { color: #600; }
:visited { color #606; }
Here's a patch that fixes the problem by moving the background color from a
body tag attribute to the global stylesheet and adds a corresponding text
color.	It's a short, simple fix, and b.m.o can get it too if an administrator
applies it to the installation.
Attachment #172594 - Flags: review?(justdave)
Comment on attachment 172594 [details] [diff] [review]
patch v1: fixes problem

r=LpSolit

Note that your patch will be bitrotten due to the checkin of bug 265394 (which
has approval+).
Attachment #172594 - Flags: review+
Flags: approval?
OS: Linux → All
Hardware: PC → All
Attachment #172594 - Flags: review?(justdave) → review+
as noted, you may have a (minor) cvs conflict to resolve when you check this in.
Flags: blocking2.20?
Flags: blocking2.20+
Flags: approval?
Flags: approval+
Yes, several conflicts and fuzz-factors, so I just applied the code changes by 
hand.

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <-
-  filterexceptions.pl
new revision: 1.33; previous revision: 1.32
done
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
  <--  header.html.tmpl
new revision: 1.35; previous revision: 1.34
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Thanks for fixing this.

However, the mozilla.org bugzilla did not get the fix so far.

Perhaps I should file a new bug about that..
(In reply to comment #9)
> Perhaps I should file a new bug about that..

In no case, no! b.m.o has not been updated since we applied this patch to
bugzilla. This should be done in a month or so, IMO.

*** Bug 309269 has been marked as a duplicate of this bug. ***
Thanks for fixing.  I hate this defect.
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: