273349 - double click attachment in compose window created with Forward as attachment from pop or local mail opens "attachment" without forwarded content

Status: RESOLVED DUPLICATE of bug 271094

(Thunderbird :: Mail Window Front End, defect)

Description

[Bernhard Walle]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041109 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041109 Firefox/1.0

If I forward a normal (not HTML, not tested with HTML) message as attachment and
in the compose window of the new mail I double click to show the attment, an
emty window is shown.

Reproducible: Always
Steps to Reproduce:
1. Click on "Forward" if you read a message
2. Double-click on the attachment which is created and should hold the forwarded
message.


Actual Results:  
An empty window is shown.

Expected Results:  
The window should contain the forwarded message.

Comment 1

[Jim Wagner]

I have the same problem with Thunderbird 1.0.2 on Windows XP.  When I forward
any message as an attachment, double clicking on the attachment results in a
message window which shows only the menu bar and toolbar.  Would someone please
change this bug status to NEW?

Comment 2

[Tracy Walker [:tracy]]

I am seeing this on Windows Thunderbird trunk builds as well.

Comment 3

[Tracy Walker [:tracy]]

this is working in windows Thunderbird trunk build 2005-05-05-05-trunk.
Yesterdays bustage may have been caused by all the other problems with trunk
builds.  I'll double check with the linux build when it becomes available, as
linux was what this was originally reported on.

Comment 4

[Tracy Walker [:tracy]]

WFM with Tbird trunk builds Windows 2005-05-05-05-trunk and Linux
2005-05-05-06-trunk

Comment 5

[Jim Wagner]

I've found that this problem still exists in Thunderbird 1.5 Beta 1 on Windows
XP.  Problem is not resolved.

Comment 6

[Jim Wagner]

Problem still exists in Thunderbird 1.5 Beta 2 on Windows XP.  Thinking it might
help I deleted my profile and started over - no good.

Comment 7

[David :Bienvenu]

Tracy, did you miss the "from the compose window" part of this bug? That indeed
doesn't work for me, at least with my debug build and a pop3 message.

Comment 8

[Raanan Barzel]

Stilla problem with TB version 1.5 (20051222):

I sent myself a message with an attached picture.

The picture in the received message opens up when double clicked.

I then forward the received message to myself (TB set to Forward messages as attachment)

The forwarded message shows the original message as attachment (envelope)

When this (envelope) attachment is double clicked it opens up in a new window with two attachments: the original picture attachment *as well as itself* as an attachment (envelope). Cliccking on any of these has no result. Further, when trying to save the picture (Save As...)  TB displays an alert : "Unable to save the attachment. Please check your file name and try again later." This is pure nonsense, since the filename is correct (looked at the source), and there is nothing a user can do at this point anyway.

Obviously, TB is confused, with mail it generated itself and which it cannot process correctly.

This seems to me a very serious fault, which should stop TB 1.5.

Comment 9

[Joe Sabash [:JoeS1]]

(In reply to comment #8)
> Stilla problem with TB version 1.5 (20051222):
> 
> I sent myself a message with an attached picture.
> 
> The picture in the received message opens up when double clicked.
> 
The original poster makes no mention of images, however I'm seeing this in RC2
One additional clue (and workaraound) If you set View | attachments | inline then the attached image can be saved by right-click , save-as

Comment 10

[Bart Verkoeijen]

(In reply to comment #8)
> Stilla problem with TB version 1.5 (20051222):
> 
> I sent myself a message with an attached picture.
> 
> The picture in the received message opens up when double clicked.
> 
> I then forward the received message to myself (TB set to Forward messages as
> attachment)
> 
> The forwarded message shows the original message as attachment (envelope)
> 
> When this (envelope) attachment is double clicked it opens up in a new window
> with two attachments: the original picture attachment *as well as itself* as an
> attachment (envelope). Cliccking on any of these has no result. Further, when
> trying to save the picture (Save As...)  TB displays an alert : "Unable to save
> the attachment. Please check your file name and try again later." This is pure
> nonsense, since the filename is correct (looked at the source), and there is
> nothing a user can do at this point anyway.
> 
> Obviously, TB is confused, with mail it generated itself and which it cannot
> process correctly.
> 
> This seems to me a very serious fault, which should stop TB 1.5.
> 

I have the exact problem here too. And indeed, it's a serious fault.
The the workaround from Joe Sabash in comment #9 works, but makes me think.

What is the new window when opened? Is it a new instance of the attached (child) e-mail, or is it a view from the original (parent) e-mail? With 'view' I mean that the parent e-mail is shown with inline attachments and parent body removed.

Comment 11

[Håvar I. Henriksen [:havarh]]

Verified on Thunderbird 1.5 on both Linux and WinXP
Trying to clarify the steps to reproduce this bug:
1. First make sure that forwarded messages is sent as a attachment and not inline
2. forward a message
3. in the compose window that gets opened in #2 do the following: doubleclick on the file of the forwarded message in the attachments bucket (file name is the subject of the message, or "Forwarded Message" if the subject is blank)

Actual Results:
An empty message view window is shown.

Expected Results:  
The window should contain a preview of the forwarded message.

The bug seems to be somewhere betwenn line 2806 and 2814 in the MsgComposeCommands.js file.
(http://lxr.mozilla.org/mozilla1.8/source/mail/components/compose/content/MsgComposeCommands.js#2806)

Comment 12

[Scott MacGregor]

these builds have already been released.

Comment 13

[Raanan Barzel]

(In reply to comment #12)
> these builds have already been released.
> 
Which builds?

TB 1.5.0.2 of April 22 still displays the same behavior - empty window when the mail forwarded as attachment is clicked.

Comment 14

[Scott MacGregor]

not going to block on it but would take a patch if we got one.

Comment 15

[Jim Wagner]

Problem still exists in TB 2.0.0.4.  The bug is now over 2.5 years old and apparently has existed from TB's beginning.  It is not hard to re-create (not some obscure thing), and when it happens it looks ridiculous.  IMHO this bug is an embarrassment and reflects quite poorly on a program that is otherwise very usable.  I strongly urge the developers to address this bug ASAP.

Comment 16

[Wayne Mery (:wsmwk)]

The problem is protocol dependent, as a little simple experimentation easily shows and I think the summary now accurately reflects. This does not happen with imap and I think also not with news, only local and pop.  Does anyone see otherwise?

So I don't think comment 11 nails the failing code.  Perhaps http://lxr.mozilla.org/mozilla1.8/source/mail/components/compose/content/MsgComposeCommands.js#2671 or perhaps more likely a function that it calls.

bug 391190 is a more troubling manifestation

Comment 18

[Wayne Mery (:wsmwk)]

bug 271094 goes in to great detail - this bug is in part or whole a dup of 271094 
bug 204350 may be related

perhaps this just part the rfc822 rats nest?

However if there is no attachment data in the compose window as bug 391190 might suggest, i.e. there is nothing more than a pointer to this data, then there may be a trivial cause+solution.

Comment 19

[Magnus Melin [:mkmelin]]

Marking as dupe.