274273 - "About Thunderbird" dialog has useless "hide toolbar" button

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Joachim Noreiko]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040614 Firefox/0.9

On Mac OS X, the "About Thunderbird" dialog has a "toolbar" button on the
right-hand side of the title bar. (This is the oblong clear button that hides
the toolbar in finder windows and other apps.) On this window, it serves no
purpose and should not be displayed.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Hiro]

Confirm.

Mac OS X 10.3.6

Comment 2

[Patrick]

This bug is actually more present: also in the about box for Firefox and in the
download manager for Firefox....

Comment 3

[Patrick]

Asaf: isn't this caused by your checkin for bug 271855?

"3. places the extra2 button at the right side (or left in a RTL gui)"

Comment 4

[Patrick]

Attachment: Possible fix for discussion - untested

I'm new to XUL and new to Mac OS X-specific bugs (so be gentle with me). 
Would this be the approach to fix this?


/mozilla/mail/base/content/aboutDialog.xul
without the extra2 button.

Comment 5

[Asaf Romano (gone)]

Extra2 isn't related at all (so is the buttons attribute) this is a well know
mac widget/ bug (we're always adding a collapse toolbar button to non-dialogs).

Comment 6

[Uri Bernstein]

*** Bug 335046 has been marked as a duplicate of this bug. ***

Comment 7

[Matt Dudziak]

This problem is not present in the 3.x version of Thunderbird. Shouldn't this bug be closed?

Comment 9

[Phil Ringnalda (:philor)]

No, it shouldn't be closed, because it's only not present due to Widget: Cocoa not drawing it; see bug 363415.

Comment 10

[Robin Whittleton]

See bug #397243 for equivalent problem in various windows in Firefox.

Comment 11

[Mark Banner (:standard8)]

(In reply to comment #9)
> No, it shouldn't be closed, because it's only not present due to Widget: Cocoa
> not drawing it; see bug 363415.
> 

Phil, bug 363415 seems to be fixed now, and I don't see one of these buttons; or am I missing something?

Comment 12

[Phil Ringnalda (:philor)]

Well, one of us is missing something, since I still see it in Tb's About and the filter dialog and the search dialog and about:config and the download manager and probably other places I'm forgetting. So if you don't see it, I think I'm missing an unchecked-in patch to widget/cocoa that's in your tree.

Comment 13

[Markus Stange [:mstange]]

Will be fixed in Thunderbird 3.next by bug 269410.