287329 - Open Location Dialog should behave exactly as URL bar for the current page

Status: RESOLVED WONTFIX

(Firefox :: Menus, enhancement, P3)

Description

[Tyler Close]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1

The Open Location Dialog can be opened when the Location tool is not visible.
The location field in the dialog should behave exactly as the Location tool
does. It should initially contain the URL for the current page. This feature
would facilitate getting the URL of the current page when the Location tool is
not visible, as well as navigating a site by peeling back its hierarchical URLs.

Reproducible: Always

Steps to Reproduce:
1. Hide the toolbar containing the Location tool.
2. Type ctrl-L to open the Open Location Dialog
3. The location field of the dialog does not contain the URL of the current page.

Actual Results:  
The dialog contained some other URL.

Expected Results:  
The dialog should contain the URL of the current page.

This bug is similar to 247467, which also requests that the Open File Dialog
behave as the Location tool does.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

This makes sense to me, too. I think we should be moving to a model where the
Open Location Dialog acts as a dialog-form of the location tool, especially
since it's only available when the location tool is hidden.

Of course, if someone opens a new window/tab and then invokes the open location
dialog, the field should be empty and waiting.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Bug 247267 took us part of the way to making the "Open Location" popup dialog
(shown when toolbars are hidden) a modal version of the URL bar. This one is to
take us the rest of the way. Includes ..

  - showing the URL of current page (if it exists)
  - recognizing open-in-tab (alt+enter)
  - getting rid of target drop-down

Comment 3

[:Gavin Sharp [email: [e-mail]]]

*** Bug 333629 has been marked as a duplicate of this bug. ***

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** Bug 338132 has been marked as a duplicate of this bug. ***

Comment 5

[Charli Li (winsxs)]

open location dialog is not a dialog on Mac OS X fx build 1.0.4, it is a blank fx window.  Now tracking Win2K & XP builds...

Comment 6

[Joey Minta]

Attachment: patch

This patch implements the 3 improvements beltzner mentions in comment #2.  Specifically:
(1) The input field now contains the current tab's url (provided it's not about:blank)
(2) There is no more "Target" drop-down.
(3) Alt+Enter opens the link in a new tab.  (Enter still opens the link in the current tab.)

Comment 7

[Joey Minta]

Comment on attachment 265560 [details] [diff] [review]
patch

I'm told beltzner meant to give this ui-r+, not a=

Comment 8

[(mostly gone) XtC4UaLL [:xtc4uall]]

any (patch review) movement gonna happen here?

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 265560 [details] [diff] [review]
patch

Patch unfortunately no longer applies cleanly. Would be interested in reviewing an updated patch, though - my fault for letting this sit so long.

nit: could use KeyEvent.DOM_VK_RETURN instead of hardcoded "13"

Comment 11

[Dão Gottwald [:dao]]

> Steps to Reproduce:
> 1. Hide the toolbar containing the Location tool.

This isn't possible anymore.