299463 - File res/hiddenWindow.html missing in installer build

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Andrew Schultz]

it'd be nice to let people know when you're going to break the world

Comment 1

[Andrew Schultz]

Attachment: patch

Comment 2

[kitchin]

Duplicate of Bug 299449

Comment 3

[kitchin]

Sorry, that's the Firefox bug for the same thing.

Comment 4

[Benjamin Smedberg]

Comment on attachment 188038 [details] [diff] [review]
patch

Please land this on the 1.7 branch as well as the trunk.

Comment 5

[Robert Kaiser]

checked into trunk and MOZILLA_1_7_BRANCH.

Comment 6

[Carsten Book [:Tomcat]]

*** Bug 299474 has been marked as a duplicate of this bug. ***

Comment 7

[Adam Guthrie]

*** Bug 299648 has been marked as a duplicate of this bug. ***

Comment 8

[Jacek Piskozub]

Reopening. Branch (1.7) has still the problem in the latest nightly build
2005070408.

Comment 9

[Andrew Schultz]

ftp://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2005-07-04-08-1.7/windows-xpi/browser.xpi
includes hiddenWindow.html, so I don't know what else is needed.

Comment 10

[Jacek Piskozub]

> so I don't know what else is needed.

I already know. hiddenWindow.html is missing in GRE. When I copied the file into
C:\Program Files\Common Files\mozilla.org\GRE\1.7.9_2005070406\res, the problem
was solved (well, worked around).

Comment 11

[Jacek Piskozub]

... and no wonder. The patch from the secret bug (damn such stupid secrets!),
changed mozilla/ xpfe/ appshell/ src/ nsAppShellService.cpp replacing
"about:blank" with "resource://gre/res/hiddenWindow.html".

That's how I guessed I need to copy the file to .../gre/res directory.

Comment 12

[Jay Patel [:jay]]

CC'ing jst, this looks like a regression from his recent checkin for bug 297543. 

Setting blocking1.7.9+ flag, please get this fix on the 1.7 branch asap!  a=jay

Comment 13

[Daniel Veditz [:dveditz]]

(In reply to comment #10)
> > so I don't know what else is needed.
> 
> I already know. hiddenWindow.html is missing in GRE.

Looks like it goes in mozilla/embedding/config/basebrowser-installer-win.pkg to
get into the GRE.

Comment 14

[Johnny Stenback (:jst)]

Attachment: Same thing for aviary

Comment 15

[Johnny Stenback (:jst)]

Comment on attachment 188373 [details] [diff] [review]
Same thing for aviary

Um, that belongs in a different bug, and it's a different patch too, me thinks.

Comment 16

[Johnny Stenback (:jst)]

Attachment: 1.7 version of the first attachment.

Comment 17

[Johnny Stenback (:jst)]

Fix landed on the 1.7 branch by [e-mail].

Comment 18

[Jay Patel [:jay]]

Reopening again since kairo's patch went in on 7/2 and comment #8 says the 7/4
builds were still broken.  Jst is investigating.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

GRE-based installer builds, such as
http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/latest-trunk/seamonkey-1.0a.en-US.win32.stub-installer.exe,
are still displaying the alert dialog for the missing hiddenWindow.html.

comment 10, comment 11, and comment 13 have all restated this issue so this bug
isn't really fixed.

Comment 20

[Robert Kaiser]

I've landed the first attachment for trunk and 1.7 branch on 2005-07-02, when
this bug fixed. The reopen happened because it was still seen on the branch, and
dveditz seems to be right that it needs to be patched in the file for GRE as
well, which wasn't included in the patch here (as this has been ported from
aviary, which does not have seperate GRE packages AFAIK).

Comment 21

[Johnny Stenback (:jst)]

Attachment: Add hiddenWindow.html to GRE's res dir.

Comment 22

[Daniel Veditz [:dveditz]]

Comment on attachment 188385 [details] [diff] [review]
Add hiddenWindow.html to GRE's res dir.

r/sr=dveditz

Comment 23

[Jay Patel [:jay]]

Comment on attachment 188385 [details] [diff] [review]
Add hiddenWindow.html to GRE's res dir.

a=jay for the 1.7 branch.  Let's get this in asap.

Comment 24

[Christian :Biesinger (don't email me, ping me on IRC)]

shouldn't the file also be removed from the other windows packaging files, so
that it doesn't get shipped twice?

Comment 25

[Johnny Stenback (:jst)]

Fix landed on the 1.7 branch.

Comment 26

[Robert Kaiser]

Comment on attachment 188385 [details] [diff] [review]
Add hiddenWindow.html to GRE's res dir.

We want this in SeaMonkey trunk as well.

biesi:
I'd rather deal with removing duplicate versions of it once the bigger problem
of getting warning dialogs etc. is fixed. Non-GRE-based builds will need the
file in the other files. I guess we can look to remove it where ua.css also
isn't listed...

Comment 27

[Jason Bassford]

> once the bigger problem of getting warning dialogs etc. is fixed

FWIW: This bug resulted in a bigger problem for me on two different home
profiles, and my work profile, than just a warning dialog.  In all cases, 3/4
times I'd start SeaMonkey (previously also seen with Mozilla) I'd be left with
only a splash screen and nothing else.  I'd have to kill the process.  As soon
as I copied the missing hiddenWindow.html file over, this stopped happening, and
the browser would load every time.

I can only think that the warning dialog was somehow being called, but just not
being shown - so the browser was waiting for an event (my clicking on OK) that
never actually happened. (?)  Although, this doesn't explain why it worked
sometimes.  However, fixing this bug should also fix the problem I was seeing.

Comment 28

[Robert Kaiser]

checked in the GRE fix for trunk.

OK, I hope this is really fixed now.

Comment 29

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b3) Gecko/20050708 SeaMonkey/1.0a]
(nightly) (W98SE)

V.F.

Comment 30

[Carsten Book [:Tomcat]]

*** Bug 300228 has been marked as a duplicate of this bug. ***

Comment 31

[Carsten Book [:Tomcat]]

*** Bug 300503 has been marked as a duplicate of this bug. ***

Comment 32

[Carsten Book [:Tomcat]]

*** Bug 300512 has been marked as a duplicate of this bug. ***

Comment 33

[[e-mail]]

I think this need to be reopened, I've been getting this error with 1.8b2

Comment 34

[Ian Neal]

Could you check your build ID and make sure it is more recent than the one
mentioned in comment 29 (20050708).

Comment 35

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 301331 has been marked as a duplicate of this bug. ***

Comment 36

[OstGote!]

*** Bug 302268 has been marked as a duplicate of this bug. ***

Comment 37

[Frank Wein [:mcsmurf]]

*** Bug 303877 has been marked as a duplicate of this bug. ***

Comment 38

[Eileen Carpenter]

If you have a fix, it would be nice to make a new build available. However, even
though I haven't downloaded a more recent build (7/2/05 is still the most recent
build), it has stopped doing it in the past few days.

Comment 39

[Robert Kaiser]

(In reply to comment #38)
> If you have a fix, it would be nice to make a new build available. However, even
> though I haven't downloaded a more recent build (7/2/05 is still the most recent
> build), it has stopped doing it in the past few days.

We have plenty newer SeaMonkey builds available, I don't know what you mean...

Comment 40

[Eileen Carpenter]

I'm using Mozilla Suite for Windows, not Seamonkey. I'm hearing different things
about what Seamonkey is.
When I click on "latest builds" under QA, I get
http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/latest/ where the latest
mozilla-win32-installer.exe is July 2 (and the latest Seamonkey is July 3).

Comment 41

[Robert Kaiser]

Eileen, Mozilla suite is not existent on any 1.8 or higher version any more
(1.7.x are the latest and last version supported by Mozilla Foundation), and its
new builds were stopped back then because of that.
SeaMonkey is the new project emerged out of that and continuing the suite code,
and its new builds are up in the seamonkey directory on ftp.mozilla.org - see
http://www.mozilla.org/projects/seamonkey/ for more info about that project.

Comment 42

[zug_treno]

*** Bug 325538 has been marked as a duplicate of this bug. ***