313453 - Language packs don't get updated

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Volkmar W. Pogatzki]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051021 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b5) Gecko/20051021 Firefox/1.5

Updating from a 1.0.6 profile to Firefox 1.5b2, any language pack installed will not be updated.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Volkmar W. Pogatzki]

Attachment: Screenshot

Comment 2

[Volkmar W. Pogatzki]

Probably a dup of bug 313453?

Comment 3

[Jo Hermans]

(In reply to comment #2)
> Probably a dup of bug 313453?
> 

do you mean bug 307225 ?

Comment 4

[Volkmar W. Pogatzki]

(In reply to comment #3)
> (In reply to comment #2)
> > Probably a dup of bug 313453?
> > 
> 
> do you mean bug 307225 ?
> 
No, sorry. What I meant is bug 245946. 

Comment 7

[Axel Hecht [:Pike]]

I did an update attempt of the Estonian langpack, I had version 2.0.10 installed and 2.0.12 is current.
https://addons.mozilla.org/de/firefox/addons/versions/4194 has the versions.

Here's the log, I'll attach the update.rdf, too.

Basically, em checks for updates, get's an update.rdf that looks good to me, and then just says that everything is fine. Rob, Benjamin, any idea?

Datasource: Update Started

Datasource: Addon Update Started: {2c5693fc-cbf5-4310-8c58-fa879d4cc645}

RDFItemUpdater:checkForUpdates sending a request to server for: https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={2c5693fc-cbf5-4310-8c58-fa879d4cc645}&version=2.0.10&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.6&appOS=WINNT&appABI=x86-msvc, item = ({id:"{2c5693fc-cbf5-4310-8c58-fa879d4cc645}", version:"2.0.10", installLocationKey:"app-profile", minAppVersion:"2.0", maxAppVersion:"2.0.0.*", name:"Eesti keele pakk 2.0.10 b2", xpiURL:"none", xpiHash:"", iconURL:"chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png", updateRDF:"", type:8})

RDFItemUpdater:_parseV20UpdateInfo: No updates were found for:
{2c5693fc-cbf5-4310-8c58-fa879d4cc645}
If you are an Extension developer and were expecting there to be
updates, this could mean any number of things, since the RDF system
doesn't give up much in the way of information when the load fails.

Try checking that: 
 1. Your RDF File is correct - e.g. check that there is a top level
    RDF Resource with a URI urn:mozilla:extension:{GUID}, and that
    the <em:updates> listed all have matching GUIDs.

RDFItemUpdater:_parseV20UpdateInfo: No updates were found for:
{2c5693fc-cbf5-4310-8c58-fa879d4cc645}
If you are an Extension developer and were expecting there to be
updates, this could mean any number of things, since the RDF system
doesn't give up much in the way of information when the load fails.

Try checking that: 
 1. Your RDF File is correct - e.g. check that there is a top level
    RDF Resource with a URI urn:mozilla:extension:{GUID}, and that
    the <em:updates> listed all have matching GUIDs.

Datasource: Addon Update Ended: {2c5693fc-cbf5-4310-8c58-fa879d4cc645}, status: 8

Datasource: Update Ended

Comment 8

[Axel Hecht [:Pike]]

Attachment: update.rdf for Estonian language pack

Comment 9

[Mike Schroepfer]

RStrong can you help taking a look at this?

Comment 10

[Robert Strong (they/them - no direct email)]

I planned on taking a look this week... is by no later than Friday soon enough?

Comment 11

[Axel Hecht [:Pike]]

The hopeful among us would like to see this land in a minor update on the branch, or rather, 2.0.0.7, to help us with a push to get more lively development in upcoming localizations. Not having extension updates takes out a bit of the fun of releasing early often.

Not sure when .7 closes, though.

Comment 12

[Robert Strong (they/them - no direct email)]

The rdf returned from AMO for locale pack uses extension when it should use item
For example:
<RDF:Description about="urn:mozilla:extension:{2c5693fc-cbf5-4310-8c58-fa879d4cc645}">

should be
<RDF:Description about="urn:mozilla:item:{2c5693fc-cbf5-4310-8c58-fa879d4cc645}">

Reassigning to AMO and cc'ing morgamic

Comment 13

[Mike Schroepfer]

(In reply to comment #11)
> The hopeful among us would like to see this land in a minor update on the
> branch, or rather, 2.0.0.7, to help us with a push to get more lively
> development in upcoming localizations. Not having extension updates takes out a
> bit of the fun of releasing early often.
> 
> Not sure when .7 closes, though.
> 

Yea - that gives us some time (weeks)

Comment 14

[Michael Morgan [:morgamic]]

The mismatch in types is related to bug 390655.  I set up a tracking bug last week for overall improvements to locale pack supports in bug 390660.

The good news is that the db supports the relationship and the addon_type just needs to be output correctly.  The bad news is that the associations aren't there and the UI to separate and browse locale packs doesn't exist (they are grouped in with extensions instead of having their own special place).

So some discussion has happened about where to have users find locale packs, and I'm not sure if there has been a consensus on where to list them. Ideally, things would happen in this order:

1) decide on a point of entry for locale packs -- AMO page, all.html, both?
2) reassign appropriate add-ons to the correct locale-pack type
3) update the update service to echo the right RDF type based on that 'fixed' association

If we do 2) before 1) then users won't be able to view or find locale packs -- which would be bad.  We can'd do 3) without 2) because there isn't a solid way to differentiate locale packs from other extensions without that association.

So Axel, what we need is a decision covering where we want users to find locale packs and what you'd like to see on AMO as far as where people would browse and find them.  One temporary place might be on the dictionaries page?  Or something similar?  Some ideas are here: http://tinyurl.com/2kwfq7

The "Languages & Dictionaries" tab in the mockups for the new AMO design would house dictionaries and locale packs.  What do you think about that?

We should be able to hash 1/2/3 and ultimately bug 390660 at the on-site.  Could you add comments to the locale pack bugs as appropriate?  Thanks.

Comment 15

[Mic Berman]

adding madhava who has been doing work with myself and wil clouser on this topic (of finding language packs)

Comment 16

[Wil Clouser [:clouserw]]

Attachment: s/extension/item/ for language packs

Is this all that needs to happen? (from comment 12)

Comment 17

[Justin Scott [:fligtar]]

Comment on attachment 322304 [details] [diff] [review]
s/extension/item/ for language packs

Tested and works - got an update for a Language Pack in Firefox 2.

Comment 18

[Wil Clouser [:clouserw]]

Thanks, committed in r14512.  Will go live Thursday night.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

To test, I:

[1] Installed 2.0.0.1 of the Persian language pack in Firefox 2.0.0.14 on Windows
[2] Opened Tools | Add-ons
[3] Clicked "Find Updates"
[4] Didn't get an update
[5] Changed |extensions.update.url| to |https://preview.addons.mozilla.org/update/VersionCheck.php?reqVersion=%REQ_VERSION%&id=%ITEM_ID%&version=%ITEM_VERSION%&maxAppVersion=%ITEM_MAXAPPVERSION%&status=%ITEM_STATUS%&appID=%APP_ID%&appVersion=%APP_VERSION%&appOS=%APP_OS%&appABI=%APP_ABI%|
[6] Clicked "Find Updates" again

At this point, was offered and successfully installed 2.0.0.6.

Verified FIXED

Comment 20

[Onno Ekker [:nONoNonO UTC+1]]

I have FX2, FX3, TB2 and TB3, but don't get updates for my dutch language pack.

The dutch language pack comes from http://ftp.mozilla.com/pub/%APP%/releases/%VERSION%/%OS%/xpi/releases/, which is the same that is distributed with dutch version of FX/TB.

Searching AMO I cannot find it however... Maybe I could persuade the dutch language pack team to also include their language pack on AMO, but there are probably a lot more language packs that can be downloaded from mozilla and don't get updated.

Here's part of my Error Console logging that holds all the info about my language pack. (I tried both with default |extensions.update.url| and url as specified in comment #19 .)

RDFItemUpdater:checkForUpdates sending a request to server for: https://preview.addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id=[e-mail]&version=2.0.0.10&maxAppVersion=2.0.0.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2.0.0.16&appOS=WINNT&appABI=x86-msvc, item = ({id:"[e-mail]", version:"2.0.0.10", installLocationKey:"app-profile", minAppVersion:"2.0.0.4", maxAppVersion:"2.0.0.*", name:"Nederlands (NL) Language Pack", xpiURL:"none", xpiHash:"", iconURL:"chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png", updateRDF:"", type:8})

Datasource: Addon Update Ended: [e-mail], status: 8

Could you please tell me if I do something wrong, or otherwise confirm this problem and reopen the issue?

Thanks...

Comment 21

[Onno Ekker [:nONoNonO UTC+1]]

(In reply to comment #20)

> Could you please tell me if I do something wrong, or otherwise confirm this
> problem and reopen the issue?

Reopening bug 336372 might be a better idea, since it looks like the problem is solved for AMO hosted language packs, but not for other installed language packs from mozilla...

Comment 22

[Tracy Walker [:tracy]]

> 
> Reopening bug 336372 might be a better idea, since it looks like the problem is
> solved for AMO hosted language packs, but not for other installed language
> packs from mozilla...
> 

That bug is duped back to this one.

File a new bug for 2.0.0.x -> 3.0.x for lang packs not hosted on AMO.  We just ran into this in testday with a user with en-US build using a de lang pack.

Comment 23

[Onno Ekker [:nONoNonO UTC+1]]

(In reply to comment #22)
> File a new bug for 2.0.0.x -> 3.0.x for lang packs not hosted on AMO.
I did file that new bug, but forgot to include a notice here: bug 451824