327539 - Move <svg:textPath> to branch

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Per driver discussion, a patch to move <textPath> capability to the 1.8.x branch.  Patch pedigree:

BACKOUT:

02/16  bug 327507 - uninitialized variables in glyph positioning [1]
10/23  bug 313165 - infinite loop in nsSVGTextFrame:GetBBox [1]
10/13  bug 311274 - text extent optimizations [1]
10/03  bug 299376 - don't assume both x and y set [2]
09/13  bug 310473 - avoid passing noninvertable matrixes to cairo [2]
09/27  bug 307155 - land cairo 1.0.0 [1]
09/26  bug 309095 - baseline offset wrong for cairo [2]
09/13  bug 307314 - crash on null tspan region [2]

[1] Changes from the textPath patch that were split for the branch.

[2] Patches pulled out for sequencing, reapplied below.

PATCHES:

08/25  bug 282579 - textPath implementation
08/26  bug 282579 - textPath: libart stubs
08/26  bug 282579 - textPath: fix logic for falling of end of path
08/29  bug 282579 - textPath: observe path for changes
08/30  bug 282579 - textPath: fix use of null surface
09/06  bug 306547 - textPath: lost segments when using closePath
09/07  bug 307314 - REAPPLY: crash on null tspan region
09/26  bug 309095 - REAPPLY: baseline offset wrong for cairo
10/02  bug 310473 - REAPPLY: avoid passing noninvertable matrixes to cairo
10/02  bug 299376 - REAPPLY: don't assume both x and y set
11/07  bug 315375 - textPath: crash
02/16  bug 327507 - REAPPLY: uninitialized variables in glyph positioning

Sizing, built with the same options as the official moz binaries:

                         BASE      +TEXTPATH    DIFF

win32 firefox.exe         7020 K    7028 K       + 8 K
win32 installer           4858 K    4861 K       + 3 K

linux firefox-bin         9545 K    9558 K      + 13 K
linux firefox.tgz         7633 K    7638 K       + 5 K

os-x Firefox.app         23036 K   23068 K      + 32 K
os-x Firefox.dmg          9360 K    9368 K       + 8 K

Comment 1

[tor]

Attachment: textPath for branch

Comment 2

[tor]

Attachment: patch version checked in

Merge to branch tip, include fix from bug 330602.

Comment 3

[tor]

Checked in.

Comment 4

[Robert Longson [:longsonr]]

I think this has the memory leaks that were fixed in bug 317708 c.f. lines like this...

+  nsSVGCharacterPosition *cp;
+  mSource->GetCharacterPosition(&cp);
+  if (NS_FAILED(mSource->GetCharacterPosition(&cp)))
+    return NS_ERROR_FAILURE;