33467 - Cookie Manager should allow direct entry of entries to reject/allow - add site button

Status: VERIFIED FIXED

(Core :: Networking: Cookies, enhancement, P3)

Description

[Richard Ekle]

The Cookie Manager is great.  One additional feature I'd like to see though is 
the ability to directly add/delete/edit cookie entries in the Cookie Manager.  
Say I install Mozilla on a new PC.  I know I want to block doubleclick.net.  
I'd like to be able to go into the cookie manager and manually add it as a 
blocked cookie site, rather than having to keep browsing until I hit a 
doubleclick.net cookie and reject it then.

Another useful feature would be to be able to export the cookie manager 'black 
list' to a file and then be able to import it into a different machine's copy 
of Mozilla.

Comment 1

[Stephen P. Morse]

These were thought about but rejected for the present.  Problem is that it would 
take a sophisticated user to know in advance which sites he wants to block 
cookies from.  And such a sophisticated user could always hand-edit the 
cookperm.txt file.

I'm not saying that this wouldn't be a nice feature, just that it wasn't 
considered as important as the ability to permanently block cookies as they are 
being encountered.  If someone volunteers to implement this, then I'll certainly 
see that it gets checked in.  Otherwise this will probably have to wait for post 
6.0.

Comment 2

[Daniel Veditz [:dveditz]]

Changing fictional "M30" to reality

Comment 3

[Jacob Steenhagen]

Adding self to CC list

Comment 4

[Stephen P. Morse]

Modifying the summary to include image manager as well as cookie manager.

Comment 5

[Stephen P. Morse]

*** Bug 57418 has been marked as a duplicate of this bug. ***

Comment 6

[Marcia Knous [:marcia]]

Netscape nav triage team: based on Steve Morse's pre-triage recommendation, this 
is not a beta stopper.

Comment 7

[Stephen P. Morse]

.

Comment 8

[Stephen P. Morse]

*** Bug 26742 has been marked as a duplicate of this bug. ***

Comment 9

[Stephen P. Morse]

*** Bug 67431 has been marked as a duplicate of this bug. ***

Comment 10

[timeless]

*** Bug 69148 has been marked as a duplicate of this bug. ***

Comment 11

[Alex Bishop]

*** Bug 89221 has been marked as a duplicate of this bug. ***

Comment 12

[Alex Bishop]

Internet Explorer 6 is going to have a feature like this. Microsoft are
promoting it on their Windows XP site. See
http://www.microsoft.com/windowsxp/expertzone/columns/bowman/june25.asp for more
details. It would be nice if Mozilla had this feature before IE6 launches.

Comment 13

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 89904 has been marked as a duplicate of this bug. ***

Comment 14

[Jeremy M. Dolan]

The workaround is to edit cookperm.txt in your profile.
Never mind the "This is a generated file!  Do not edit." bit ;)
There's no documentation on the file format, but:

0F  site can't set cookies
0T  site can set cookies
1F  site can't load images

I've never seen 1T naturally occur, it probably does the obvious, though.
Not sure what the @@@@ line controls.

Comment 15

[Stephen P. Morse]

@@@@ reflects the last-used state of the do-you-want-to-remember checkbox that 
appears in the cookie-warning box and the image-warning box

1T will occur if you put a checkmark in the image-warning checkbox for a 
particualur site.

Comment 16

[Diego Biurrun]

*** Bug 115801 has been marked as a duplicate of this bug. ***

Comment 17

[Alfonso Martinez]

*** Bug 110363 has been marked as a duplicate of this bug. ***

Comment 18

[Alfonso Martinez]

*** Bug 129489 has been marked as a duplicate of this bug. ***

Comment 19

[timeless]

*** Bug 142397 has been marked as a duplicate of this bug. ***

Comment 20

[Jesse Ruderman]

*** Bug 151330 has been marked as a duplicate of this bug. ***

Comment 21

[Jesse Ruderman]

See also:
bug 92469  import/export image permissions lists
bug 109810 manually add to Passwords never saved list in passwordmanager

Comment 22

[Jo Hermans]

*** Bug 161830 has been marked as a duplicate of this bug. ***

Comment 23

[R.K.Aa.]

*** Bug 176917 has been marked as a duplicate of this bug. ***

Comment 24

[Jo Hermans]

*** Bug 183830 has been marked as a duplicate of this bug. ***

Comment 25

[[e-mail]]

As a user, I think this is a reasonably important feature to have, since I use 
it very regularly with IE (which is another reason we should support it). I'm 
aware of cookperm.txt's existence, but that doesn't address the issue; the user 
should be able to do this within the UI, especially since it (seems like) such 
a simple thing to implement.

This isn't just for 'power users' who want to enter permissions on browser 
install - this is something I use everyday. As explained in bug 183830 (sorry 
for the dup), it's useful if you want a 'blanket reject' policy for cookies, 
but then enable them when you encounter a site where you want to specifically 
enable them. For instance, webmail sites usually require cookies, but that 
doesn't mean I want to enable cookies for all sites.

In 183830, I mentioned what I think would be a nice way to implement this - by 
adding to the cookie manager, and also by having a small 'cookie icon' in the 
status bar which shows if a cookie has been rejected (or stored) for that site. 
Clicking this icon would allow the user to 'set allow' or 'set reject' very 
quickly, without clicking all the way thru prefs to the cookie manager.

Image and popup managers might want similar features.

Comment 26

[Sander]

*** Bug 201060 has been marked as a duplicate of this bug. ***

Comment 27

[Jason Bassford]

Tweaking summary. (I would have found this one otherwise.)

Comment 28

[[e-mail]]

adding mvl to cc. we should consider this at some point if (when) we're
reworking UI stuff.

Comment 29

[Rich hart]

Please get direct entry fixed on at least the Image manager.  Thanks

Comment 30

[benc]

Rich: cookies and image blocking are separate componenets now. Can you create a
bug just for Image Manager in Image Manager?

Comment 31

[Bill Mason]

*** Bug 210142 has been marked as a duplicate of this bug. ***

Comment 32

[Matthias Versen [:Matti]]

*** Bug 211321 has been marked as a duplicate of this bug. ***

Comment 33

[Michiel van Leeuwen (email: mvl+moz@)]

taking

Comment 34

[Joe Infla]

*** Bug 214974 has been marked as a duplicate of this bug. ***

Comment 35

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: first try

A first try at a patch. Just add a "Add Site" button, which pops up a dialog
that asks you to enter a sitename, and a checkbox to indicate allow
cookie/image or block it.

Comment 36

[[e-mail]]

Comment on attachment 129761 [details] [diff] [review]
first try

>Index: extensions/wallet/cookieviewer/CookieViewer.properties
>===================================================================
>+addPermissionTitle = Add Site
>+addPermissionCookieText = Enter a site for which you want to set the cookie permission (eg "www.mozilla.org")

s/eg/e.g./, and add a full-stop at the end?

>+addPermissionImageText = Enter a site for which you want to set the image permission (eg "www.mozilla.org")

same here.

this looks good, but i'd still like to see two radioboxes instead of a checkbox
here: "() allow cookies () reject cookies". it's up to jag, i guess, since we
can't use the nice promptservice default if we do that, like you say.

what about keybindings (checkbox)?

r=dwitte, provided jag is happy with the checkbox prompt.

Comment 37

[Christopher Wanko]

Attachment: Target UI for this enhancement

This bitmap is a screenshot for AtGuard, still the finest firewall/ content
filter program in existence.  This dialog box is *precisely* what is needed
regarding popups, cookies, images, flash, and so forth.

It asks you two questions: "is this session-only or permanent?" and "is it for
this domain or this machine?"  Four choices, real simple.  No more distinction
between files, or UI issues, or whatever else might be concocted.  For
permanent choices, you save either a domain or a machine name, and the
attributes that go with it.  For sessions it's the same thing, only it'll live
in your cache folder or a temporary file and die on exit.

Comment 38

[Michiel van Leeuwen (email: mvl+moz@)]

That screenshot is not a terget ui for this bug. This bug is about a way to add
entries to the cookie sites, without browsing to that site. The screenshot is
something for the dialog that pops up when a cookie is set.

Comment 39

[Alfonso Martinez]

*** Bug 219841 has been marked as a duplicate of this bug. ***

Comment 40

[jag (Peter Annema)]

Comment on attachment 129761 [details] [diff] [review]
first try

Hmm, I think the checkbox is fine for now. If we ever get to the place where
you can disable all cookies, and selectively enable them for some sites (none
of the current UI suggests that's possible), then a more explicit choice would
be needed.

sr=jag

Comment 41

[jag (Peter Annema)]

Comment on attachment 129761 [details] [diff] [review]
first try

Hmm, I missed the "Cookie Sites" tab. So I guess you can block all cookies and
then selectively unblock a few sites. Or at least it looks like you can. So
perhaps two radio buttons would be better then. Unchecking the checkbox kinda
suggests "whatever the current default is", though really the way to do that is
to remove the domain from the list.

Comment 42

[Michiel van Leeuwen (email: mvl+moz@)]

I agree that radio buttons would be clearer. I tried to create a dialog with it,
but got bitten by bug 181331. I used JS to set the labels to eiterh "allow site
to set cookies" or "allow site to show images". So either that bug needs to be
fixed, or worked around using a different UI.

Comment 43

[Mike Connor [:mconnor]]

->

Comment 44

[Mike Connor [:mconnor]]

fixed by the patch for bug 222553

Comment 45

[benc]

verify via closed dependency to kill this bug... will test and verify there.