335167 - 'Save Page As...' should be 'Save Image As...' when viewing an image (or 'Save As...')

Status: NEW

(Firefox :: Menus, defect)

Description

[Gids Goldberg]

When viewing an image the File menu reads 'Save Page As...' it should read 'Save Image As...'

IE gets around this by using 'Save As...' for everything, which would be easier to implement but not as descriptive.

The equivalant for Seamonkey is Bug 171515

Comment 1

[Channy Yun [:channy]]

Axel, please check it out. Bug 352245 is related to this one in l10n ko.

Comment 2

[Andrew Hagen]

The sibling of this Firefox bug, Seamonkey bug 171515, also notes the same problem for text documents PDF files, etc.

Comment 3

[James May [:fowl2]]

One solution (mentioned in Bug 352245), is to change it to "Save As..." instead of having to detect types and things with "Save <type> As..." and all its' localised equivalents.

Comment 5

[Nguyen Ngoc Trung]

I would like to fix this bug

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Nguyen Ngoc Trung from comment #5)
> I would like to fix this bug

If you want to work on this bug, I recommend that you look into the documentation to become familiar with Mozilla development: https://developer.mozilla.org/en-US/mozilla

If you have specific questions about writing this patch, you can ask here.

Comment 7

[Nguyen Ngoc Trung]

Attachment: Proposed patch

I have changed the label "Save Page As..." to "Save As..."

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 613797 [details] [diff] [review]
Proposed patch

Thanks for the patch! Sorry it took us so long to notice :(

When changing strings, it's necessary to also change the entity name so that localizers can detect the change. So that means you would also need to change "savePageCmd.label" to e.g. "saveCmd.label", and update other references to it in browser-appmenu, browser-context, etc.

But before moving further with patching, let's see whether UX folks have an opinion on this bug.

Comment 9

[Ruben Rodriguez]

This should apply to video and audio files, since there are dedicated strings for those too.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:jaws, could you have a look please?
For more information, please visit auto_nag documentation.