Closed Bug 335755 Opened 19 years ago Closed 18 years ago

Extension XUL overlay errors should not create a gray bar


(Core :: XUL, enhancement)

Not set





(Reporter: jruderman, Assigned: enndeakin)




(3 files)

There have been at least 50 bug reports in Bugzilla about a gray bar appearing below the status bar due to broken extensions.  (I counted INVA bugs where was mentioned, bug 314768 and its dups, and bug 308742 and its dups).

The gray bar is an unnecessary persistent annoyance.  It should be replaced by a clear error message (in a dialog) or quiet failure (just show a message in the JavaScript Console).  The message should state which overlay is broken/missing and which extension is responsible.
This patch disables printing out the error message for non-well-formed overlays. The "xul-overlay-parsererror" notification can be used by some future extension manager change to disable the corresponding extension.
Assignee: nobody → enndeakin
Attachment #220937 - Flags: superreview?(jst)
Attachment #220937 - Flags: review?(bugmail)
Comment on attachment 220937 [details] [diff] [review]
Don't output error message for overlays that don't parse properly

Please make OnDocumentParserError return the reporterror bool rather than an nsresult.

And send a notification to the js-console as well.

with that, r=sicking
Attachment #220937 - Flags: review?(bugmail) → review+
Attached patch Address commentsSplinter Review
Attachment #220993 - Flags: superreview?(jst)
Comment on attachment 220993 [details] [diff] [review]
Address comments

Attachment #220993 - Flags: superreview?(jst) → superreview+
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #220937 - Flags: superreview?(jst)
So shouldn't we report the error to the console even if OnDocumentParserError() returns true?
(In reply to comment #5)
> So shouldn't we report the error to the console even if OnDocumentParserError()
> returns true?

We could do that yes. That would cause all XUL parse errors, overlay or otherwise to be reported.
That's what we should do, imo, unless there's a really good reason not to.
Comment on attachment 220993 [details] [diff] [review]
Address comments

Requesting approval‑branch‑1.8.1. This comes up often in the support forums and the problem occurs more often with major releases (with new versions of extensions coming out).
Attachment #220993 - Flags: approval-branch-1.8.1?
Attachment #220993 - Flags: approval-branch-1.8.1? → approval-branch-1.8.1?(bryner)
Comment on attachment 220993 [details] [diff] [review]
Address comments

This can't land on the branch as-is because it changes nsIXULDocument.
Attachment #220993 - Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1-
Wait.  Doesn't this double-report the well-formedness errors, since nsExpatDriver reports errors itself too?
Depends on: 342063
Filed bug 342063 on the double-reporting issue.
*** Bug 318588 has been marked as a duplicate of this bug. ***
Attached image screenshot from Mac
bz: This is a screenshot of the error console on 1.8 branch, with two error messages.  As I understand this bug from comment 0, you want me to prevent the second error message from appearing.  That's what my patch does.  Did I misinterpret this bug?  Do I need to change the code on 1.8 branch somewhere else?
ignore comment 13, I meant to attach to bug 342063 (sorry!)
*** Bug 356792 has been marked as a duplicate of this bug. ***
*** Bug 356841 has been marked as a duplicate of this bug. ***
*** Bug 357508 has been marked as a duplicate of this bug. ***
*** Bug 362691 has been marked as a duplicate of this bug. ***
Rather than fix individual bugs like bug 364460, we would rather take a patch for this bug on the 1.8 branch.

Neil:  Could you look into updating the patch for the 1.8 branch?
Flags: wanted1.8.1.x+
Are you planning and is it possible to add an error dialog to inform the average user that one of his extensions is not working properly?
Possible, yes. The question is better suited for a newsgroup or a separate bug.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.