336488 - Search Bookmarks Broken

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Steven.S]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8) Gecko/20060503 BonEcho/2.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8) Gecko/20060503 BonEcho/2.0a1

Ever since Places was disabled on branch, searching bookmarks hasn't worked. Searching from the bookmarks sidebar and bookmarks manager both don't work. I compiled a new build right before submitting this bug and it is still present, even with a new profile.

Reproducible: Always

Steps to Reproduce:
1. Open bookmarks sidebar or bookmarks manager
2. Search for a known bookmark

Actual Results:  
Should find the bookmark

Expected Results:  
doesn't find bookmark

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060503 BonEcho/2.0a1
Yes, I see the same.

Comment 2

[Guy Kaiser]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060503 BonEcho/2.0a1 ID:2006050304

Same here.

Comment 3

[Peter van der Woude [:Peter6]]

Steven, are you sure this was caused by Bug 336488 (Disable Places on 1.8.1 branch) ?
Are you sure this regressed between the 20060428 and 20060429 ?

Comment 4

[Steven.S]

Peter, no I'm not sure the exact date it regressed. In fact, I had been having trouble with places so I had made a build with --disable-places a week before it was officially turned off and it had this same problem. So it definitely didn't occur during the dates you mentioned but happened sometime before that. (btw, the bug you linked to is the same bug we're on)

Comment 5

[Peter van der Woude [:Peter6]]

Yeah, that should have been bug 335377

Hmm, so this regressed between Places enabled and Places disabled
mid march - 20060429

Comment 6

[Frank Yan (:fryn)]

would the checkin for bug 325257 have anything to do with it?

that checkin also broke FireFTP.

Comment 7

[Nick Fagerlund]

I confirm this on Mac with BonEcho alpha 2; architecture can probably be changed to "All."

Comment 8

[Worcester12345]

Is this subject to the same "...due to underlying issues on certain
filesystems, until we ship Places,..." issue as in Bugzilla Bug 249150
Bookmarks file is overwritten (deleted) randomly in Firefox versions without places?

https://bugzilla.mozilla.org/show_bug.cgi?id=249150#c92

Comment 9

[diorser]

Bug still existing since April 29th.
http://forums.mozillazine.org/viewtopic.php?p=2235226#2235226

Should be corrected for any official release.

Comment 10

[(not reading, please use [e-mail] instead)]

while working on #315690, I saw this regression.

Comment 11

[(not reading, please use [e-mail] instead)]

taking, as I would really need this fixed before I can verify that a fix for #315690 did not regress bug #255255

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: removing part of the fix from bug #317107 which caused this regression

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 223342 [details] [diff] [review]
removing part of the fix from bug #317107 which caused this regression

Wow, sucks that Firefox bookmarks search depends on code in xpfe/components/search. Clearly I was wrong in bug 317107 :(.  I'd be kind of nice to remove that dependency (so that bug 332021 could be fixed on the branch), but I have a strong feeling that that would require a non-trivial amount of work.

r=me if it fixes the bustage, but I'm really not familiar with any of this code, and I don't know who is. Maybe vlad?

Comment 14

[(not reading, please use [e-mail] instead)]

> Wow, sucks that Firefox bookmarks search depends on code in xpfe/components/search.

Based on ben's comments, when places is re-enabled, it should not depend on it.  

But I'm not sure, so that is just my un-educated guess.

Comment 15

[(not reading, please use [e-mail] instead)]

when debugging to figure out what was going on, I was unable to set a breakpoint in nsLocalSearchService.cpp, which led me to look rdf:localsearch was missing.

doing a cvs blame on mozilla/browser/components/bookmarks/content/bookmarksTree.xml led me to bug 317107: new search service.

note, mozilla/xpfe/components/bookmarks/resources/bookmarksTree.xml does not have this issue, as it still has rdf:localsearch

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 223342 [details] [diff] [review]
removing part of the fix from bug #317107 which caused this regression

robert strong tells me for mozilla/browser I only need one review (thanks gavin) and then a= for the 1.8.1 branch

Comment 17

[Mike Connor [:mconnor]]

Comment on attachment 223342 [details] [diff] [review]
removing part of the fix from bug #317107 which caused this regression

gah, so evil.

a=me for branch after we reopen it

Comment 18

[Steven.S]

I can confirm the fixes this bug. Since branch is closed, if anyone else wants the fix on their browser just modify BookmarksTree.xml inside browser.jar with the changes in the patch. Thanks Seth Spitzer. :)

Comment 19

[Frank Yan (:fryn)]

the branch is open again, because alpha 3 is out.
so is this being checked in?

Comment 20

[(not reading, please use [e-mail] instead)]

landed on 1.8.1 branch

Comment 21

[Phil Ringnalda (:philor)]

*** Bug 339903 has been marked as a duplicate of this bug. ***

Comment 22

[Ria Klaassen (not reading all bugmail)]

*** Bug 339984 has been marked as a duplicate of this bug. ***

Comment 23

[(not reading, please use [e-mail] instead)]

fyi, in order to keep trunk in sync with the 1.8 branch, I've landed this change on the trunk as well.

Comment 24

[Carsten Book [:Tomcat]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b2) Gecko/20060822 BonEcho/2.0b2

Comment 25

[Tracy Walker [:tracy]]

verified 1.8.1 per comment 24