Closed Bug 342991 Opened 18 years ago Closed 18 years ago

feeds show up empty

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

2.0 Branch
defect
Not set
blocker

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 2 beta1

People

(Reporter: Peter6, Assigned: asqueella)

References

Details

(Keywords: regression, verified1.8.1, Whiteboard: 181b1+)

Attachments

(2 files)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060628 Minefield/3.0a1 ID:2006062803 [cairo]

Open http://feedhouse.mozillazine.org/rss10.xml

regressed between:
works in 20060627 1315pdt build
fails in 20060627 1541pdt build
The following errors pop up in the error console:

Error: BrowserFeedWriter is not defined
Source File: chrome://browser/content/feeds/subscribe.js
Line: 45

Warning: Event=select, use of preventBubble() is deprecated. Use W3C standard stopPropagation() instead.
Source File: chrome://browser/content/feeds/options.xul
Line: 0

Error: this._feedWriter has no properties
Source File: chrome://browser/content/feeds/subscribe.js
Line: 50


Bug 336903 looks like a fairly obvious candidate?
Also confirmed as a bug on branch:

Mozilla/5.0 (Windows; compatible; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060628 Firefox/2.0a3
Flags: blocking1.9a1?
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta1
Flags: blocking-firefox2? → blocking-firefox2+
I see this on the Mac as well (Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060630 BonEcho/2.0a3)

Here is the output from the JS console on the Mac - Error: uncaught exception: [Exception... "'[JavaScript Error: "this._window has no properties" {file: "file:///Users/knous/Desktop/Firefox%202.0/BonEcho.app/Contents/MacOS/components/FeedWriter.js" line: 377}]' when calling method: [nsIFeedWriter::changeOptions]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/feeds/subscribe.js :: SH_changeOptions :: line 54"  data: yes]
Just to be clear this JS message occurs when I hit the "Change Reader" button. Adding ben to the bug.

(In reply to comment #4)
> I see this on the Mac as well (Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
> en-US; rv:1.8.1a3) Gecko/20060630 BonEcho/2.0a3)
> 
> Here is the output from the JS console on the Mac - Error: uncaught exception:
> [Exception... "'[JavaScript Error: "this._window has no properties" {file:
> "file:///Users/knous/Desktop/Firefox%202.0/BonEcho.app/Contents/MacOS/components/FeedWriter.js"
> line: 377}]' when calling method: [nsIFeedWriter::changeOptions]"  nsresult:
> "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame
> :: chrome://browser/content/feeds/subscribe.js :: SH_changeOptions :: line 54" 
> data: yes]
> 

Severity: major → blocker
OS: Windows 2000 → All
Hardware: PC → All
Version: Trunk → 2.0 Branch
So the first problem is that FeedWriter.js is not bundled with the installer. Another one is missing close() method on nsIFeedWriter. Last problem (for me) was that FeedWriter's _isValidWindow is totally broken with flat chrome.
Attached patch patchSplinter Review
I *think* this fixes the bug. (Not tested, except for the IDL part, since I don't build installer).
Assignee: nobody → asqueella
Status: NEW → ASSIGNED
Attachment #227827 - Flags: review?(beng)
Of course that wasn't enough for the branch, which needed additional change to FeedWriter.js due to differences in interface naming.
Attachment #227839 - Flags: review?(bugs)
Attachment #227827 - Flags: review?(beng) → review?(bugs)
Filed the issue with a flat chrome build as bug 343360.
*** Bug 343384 has been marked as a duplicate of this bug. ***
Attachment #227839 - Flags: review?(bugs) → review+
Attachment #227827 - Flags: review?(bugs) → review+
Whiteboard: [checkin needed] 181b1+
mozilla/browser/installer/windows/packages-static 	1.82
mozilla/browser/installer/unix/packages-static 	1.78
mozilla/browser/components/feeds/public/nsIFeedWriter.idl 	1.2
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking1.9a1?
Resolution: --- → FIXED
Whiteboard: [checkin needed] 181b1+ → [need-a] 181b1+
Gavin - thanks for landing! please request 1.8.1 after a few days on trunk.
Marcia - can you confirm this fixes things with the 7-6 nightly on trunk?
(In reply to comment #12)
> Gavin - thanks for landing! please request 1.8.1 after a few days on trunk.

Oh, sorry - I'm so behind on bugmail that I didn't notice comment 12. Go ahead and cancel the approval request if more trunk baking is desired. For what it's worth, I think the fix is obviously desired, and suitable to be landed now. I have verified that it fixes the bug in my local build.
Attachment #227839 - Flags: approval1.8.1? → approval1.8.1+
mozilla/browser/installer/unix/packages-static 	1.50.2.29
mozilla/browser/components/feeds/src/FeedWriter.js 	1.2.2.3
mozilla/browser/components/feeds/public/nsIFeedWriter.idl 	1.1.2.2
mozilla/browser/installer/windows/packages-static 	1.53.2.30
Keywords: fixed1.8.1
Whiteboard: [need-a] 181b1+ → 181b1+
No longer depends on: 344022
verified with 2.0b2 builds from 20060821
Status: RESOLVED → VERIFIED
*** Bug 352204 has been marked as a duplicate of this bug. ***
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: