342991 - feeds show up empty

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060628 Minefield/3.0a1 ID:2006062803 [cairo]

Open http://feedhouse.mozillazine.org/rss10.xml

regressed between:
works in 20060627 1315pdt build
fails in 20060627 1541pdt build

Comment 1

[TimoT]

The following errors pop up in the error console:

Error: BrowserFeedWriter is not defined
Source File: chrome://browser/content/feeds/subscribe.js
Line: 45

Warning: Event=select, use of preventBubble() is deprecated. Use W3C standard stopPropagation() instead.
Source File: chrome://browser/content/feeds/options.xul
Line: 0

Error: this._feedWriter has no properties
Source File: chrome://browser/content/feeds/subscribe.js
Line: 50


Bug 336903 looks like a fairly obvious candidate?

Comment 2

[Peter van der Woude [:Peter6]]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20060627+1248&maxdate=20060627+1535&cvsroot=%2Fcvsroot

Comment 3

[Doug Halamay]

Also confirmed as a bug on branch:

Mozilla/5.0 (Windows; compatible; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060628 Firefox/2.0a3

Comment 4

[Marcia Knous [:marcia]]

I see this on the Mac as well (Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060630 BonEcho/2.0a3)

Here is the output from the JS console on the Mac - Error: uncaught exception: [Exception... "'[JavaScript Error: "this._window has no properties" {file: "file:///Users/knous/Desktop/Firefox%202.0/BonEcho.app/Contents/MacOS/components/FeedWriter.js" line: 377}]' when calling method: [nsIFeedWriter::changeOptions]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/feeds/subscribe.js :: SH_changeOptions :: line 54"  data: yes]

Comment 5

[Marcia Knous [:marcia]]

Just to be clear this JS message occurs when I hit the "Change Reader" button. Adding ben to the bug.

(In reply to comment #4)
> I see this on the Mac as well (Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
> en-US; rv:1.8.1a3) Gecko/20060630 BonEcho/2.0a3)
> 
> Here is the output from the JS console on the Mac - Error: uncaught exception:
> [Exception... "'[JavaScript Error: "this._window has no properties" {file:
> "file:///Users/knous/Desktop/Firefox%202.0/BonEcho.app/Contents/MacOS/components/FeedWriter.js"
> line: 377}]' when calling method: [nsIFeedWriter::changeOptions]"  nsresult:
> "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame
> :: chrome://browser/content/feeds/subscribe.js :: SH_changeOptions :: line 54" 
> data: yes]
> 

Comment 6

[Nickolay_Ponomarev]

So the first problem is that FeedWriter.js is not bundled with the installer. Another one is missing close() method on nsIFeedWriter. Last problem (for me) was that FeedWriter's _isValidWindow is totally broken with flat chrome.

Comment 7

[Nickolay_Ponomarev]

Attachment: patch

I *think* this fixes the bug. (Not tested, except for the IDL part, since I don't build installer).

Comment 8

[Nickolay_Ponomarev]

Attachment: patch for 1.8 branch

Of course that wasn't enough for the branch, which needed additional change to FeedWriter.js due to differences in interface naming.

Comment 9

[Nickolay_Ponomarev]

Filed the issue with a flat chrome build as bug 343360.

Comment 10

[dex_sf]

*** Bug 343384 has been marked as a duplicate of this bug. ***

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/installer/windows/packages-static 	1.82
mozilla/browser/installer/unix/packages-static 	1.78
mozilla/browser/components/feeds/public/nsIFeedWriter.idl 	1.2

Comment 12

[Mike Schroepfer]

Gavin - thanks for landing! please request 1.8.1 after a few days on trunk.

Comment 13

[Mike Schroepfer]

Marcia - can you confirm this fixes things with the 7-6 nightly on trunk?

Comment 14

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #12)
> Gavin - thanks for landing! please request 1.8.1 after a few days on trunk.

Oh, sorry - I'm so behind on bugmail that I didn't notice comment 12. Go ahead and cancel the approval request if more trunk baking is desired. For what it's worth, I think the fix is obviously desired, and suitable to be landed now. I have verified that it fixes the bug in my local build.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/installer/unix/packages-static 	1.50.2.29
mozilla/browser/components/feeds/src/FeedWriter.js 	1.2.2.3
mozilla/browser/components/feeds/public/nsIFeedWriter.idl 	1.1.2.2
mozilla/browser/installer/windows/packages-static 	1.53.2.30

Comment 16

[Tracy Walker [:tracy]]

verified with 2.0b2 builds from 20060821

Comment 17

[Adam Guthrie]

*** Bug 352204 has been marked as a duplicate of this bug. ***