343422 - when you have only one tab, middle click on the tab brings the close button back

Status: RESOLVED DUPLICATE of bug 342105

(Firefox :: Tabbed Browser, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060702 Minefield/3.0a1 ID:2006070202 [cairo] (also on latest branch)

repro:
Open FF with 1 tab
middleclick on that tab

result:
the close button appears in that tab

expected:
that not to happen

Comment 1

[Simon Bünzli]

Attachment: dispatch TabClose after TabOpen in this edge case

Because we're adding a blank tab which will replace the tab to be closed, we're getting a TabOpen event after the TabClose one which confuses adjustTabStrip. Dispatching TabClose slightly later should take care of this issue (and is even more correct because we're actually opening a new tab before closing the old one).

Comment 2

[Simon Bünzli]

*** Bug 344082 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

sorry for not noticing this patch before b1.  I'll take test, review and work it into b2.

Comment 4

[Mike Connor [:mconnor]]

Now that closing the exposed tab doesn't close the window, we should show the always show the closebutton, duping to that bug.

*** This bug has been marked as a duplicate of 342105 ***

Comment 5

[Simon Bünzli]

Comment on attachment 228557 [details] [diff] [review]
dispatch TabClose after TabOpen in this edge case

Moving this patch over to bug 344587.

Comment 6

[Brian Polidoro]

*** Bug 344953 has been marked as a duplicate of this bug. ***

Comment 7

[Brian Polidoro]

*** Bug 345268 has been marked as a duplicate of this bug. ***