348024 - ja-JP Search Feature Tracking for Firefox 2

Status: VERIFIED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[chris hofmann]

tracking bug to make sure we get things on the list below working correctly for
each locale:

Deafult Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Comment 1

[chris hofmann]

Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1b2) Gecko/20060828 BonEcho/2.0b2 appears to not have offical branding turned on.

--enable-application=browser --enable-update-channel=nightly --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-svg --enable-canvas --enable-update-packaging

but yahoo search generates an offical search code.
http://search.yahoo.co.jp/search?p=test&ei=UTF-8&fr=moz2&rls=org.mozilla:ja-JP:official

google still shows "unoffical"
http://www.google.co.jp/search?q=test&lr=lang_ja&ie=utf-8&oe=utf-8&rls=org.mozilla:ja:unofficial&client=firefox

Comment 2

[chris hofmann]

Attachment: first draft at a ja-JP search test page

some questions about approvals for the extra engines

and 

goo ウェブ

search for "test"  point to URLs of the form
http://search.goo.ne.jp/web.jsp?MT=test&from=Firefox15&PT=Firefox15

Should this be updated to Firefox20?

Comment 3

[chris hofmann]

Attachment: v2 update with correcxt yahoo code

Comment 4

[chris hofmann]

looks like we don't have the correct fr code -- this is what I see in 
Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1b2) Gecko/20060828 BonEcho/2.0b2

http://search.yahoo.co.jp/search?p=test&ei=UTF-8&fr=moz2&rls=org.mozilla:ja-JP:official

Comment 5

[chris hofmann]

blocking issues seem to be
1) get a patch to make sure yahoo search code is fr=moz1
2) contacts, reviews, approvals for goo

Comment 6

[Mike Schroepfer]

Note that we are not changing the code from moz2->moz1.   So we just need the goo approvals/reviews/etc.

Comment 7

[Gen Kanai [:gen]]

I have contacted NTT Goo to have them review Beta 2.  I will ask them again for an update.

Comment 8

[Gen Kanai [:gen]]

Also, NTT Goo have recently launched their version of search "suggest" and are interested in having that integrated into Firefox 2 Ja-JP.

Comment 9

[Mic Berman]

Gen can you help me check in with Goo on this
thanks
mic

Comment 10

[Gen Kanai [:gen]]

I have checked with Goo and they would like for us to update the search string to differentiate Firefox 2 i.e. "from=Firefox20&PT=Firefox20"

They would like for us to integrate their version of search "suggest" but they cannot meet the deadline for RC1.  They do plan to meet the deadline for RC2.

I will also contact Yahoo Japan regarding the "fr code" issue.

Comment 11

[Mic Berman]

does Gen's answer address the concern?
mic

Comment 12

[Mike Schroepfer]

Gen,

Thanks for your quick reply.  Unfortunately, RC1 is the deadline for all code changes.  RC2 will only occur if we find a new issue in the wild with RC1.   This means if Goo cannot make it by RC1 for suggests they'll miss FF2.

Axel - can you update the codes for the plugin to match as below:

(In reply to comment #10)
> I have checked with Goo and they would like for us to update the search string
> to differentiate Firefox 2 i.e. "from=Firefox20&PT=Firefox20"
> 
> They would like for us to integrate their version of search "suggest" but they
> cannot meet the deadline for RC1.  They do plan to meet the deadline for RC2.
> 
> I will also contact Yahoo Japan regarding the "fr code" issue.
> 

Comment 13

[Gen Kanai [:gen]]

Mike- understood re: Goo.  

Will attempt to get confirmation re: Yahoo! Japan's code today (the 11th).

Comment 14

[Gen Kanai [:gen]]

I have received confirmation from Yahoo! Japan today 09/11.

They do not wish for us to change the tracking code for FF2.

The current FF2 Beta2 ja-JP is accurate by Yahoo! Japan's testing.

Comment 15

[Axel Hecht [:Pike]]

So Yahoo US says fr=fx2-moz-1, Yahoo Japan say fr=moz2? I'll forward Gen a mail I have here.

Are those codes for all three Yahoo plugins in the Japanese builds?

Comment 16

[Axel Hecht [:Pike]]

Attachment: change Firefox15 to Firefox20, needs to be in ja-JP-mac, too

Comment 17

[Axel Hecht [:Pike]]

The yahoo plugin was fixed by Benjamin as part of bug 351817.
He did not touch the shopping and auction plugins for Yahoo. Gen, Mic, could you please verify which flags we're supposed to use for those. We might want to port the preference based approach for those plugins, too.

Comment 18

[Mic Berman]

i don't have direct knowledge however my guess is it should be the same as was shipped in FF1.5 as those plug-ins were there then too.
don't know if that's helpful
i have also pinged yahoo and given that it's now 5:50am in Tokyo, we might get an answer in a few hours
best
mic

Comment 19

[Gen Kanai [:gen]]

I just spoke with schrep and will re-confirm with malbers and yahoo! Japan with a cc to mic and axel.  pleast stay tuned.

Comment 20

[dynamis (Tomoya ASAI)]

(In reply to comment #16)
> Created an attachment (id=237719) [edit]
> change Firefox15 to Firefox20, needs to be in ja-JP-mac, too

The Japanese comment in the changed lines of the patch is "This valud may have to be changed" in English. It will be changed now and of cource the comment is not required now.

If you give approval to commit the change of goo plugin, I'll remove the comment and commit it into l10n CVS.

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 237719 [details] [diff] [review]
change Firefox15 to Firefox20, needs to be in ja-JP-mac, too

Go, Goo! ;-)

Comment 22

[chris hofmann]

here is a look at yahoo code seen in build Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP-mac; rv:1.8.1b2) Gecko/2006091203 BonEcho/2.0b2

http://search.yahoo.co.jp/search?p=test&ei=UTF-8&fr=fx2-moz-1&rls=org.mozilla:ja-JP:official

Comment 23

[Axel Hecht [:Pike]]

We still need to confirm whether the params for the Yahoo! auction and shopping plugins should match 1.5 or the main plugin on 2.0. I.e., hardcoding fr=moz2 or pref="yahoo-fr".

Comment 24

[Mic Berman]

Hi
Gen and I received confirmation from Yahoo Japan that we can use the same "fr=fx2-moz-1" for Yahoo! Japan Auctions search and Yahoo! Japan Shopping search
Axel - does that address the outstanding question for this bug?
thanks
mic

Comment 25

[chris hofmann]

yeah, that makes sense.  make the code match what gets sent for search.  now we just need the patch to make that happen.  who can put that together?

Comment 26

[Mike Schroepfer]

If they match then we should use the pref so we can override later if needed.

Note is there is still some confusion over the codes.  We may have to revent to moz2...   I'll update as soon as I have info.

Comment 27

[Mike Schroepfer]

Note the latest:

http://wiki.mozilla.org/Firefox2/L10n_Requirements#Yahoo.21

Says we should be matching FF15 - and using moz2 here

Comment 28

[Axel Hecht [:Pike]]

Attachment: use MozParam for fr, fix rls to use moz:foo, too

I moved the hardcoded fr params in auction and shopping over the the cjkt pref, and changed the rls param to use moz:distributionID and moz:official.

I tried testing this on a nightly bonecho, sadly those don't seem to be offically branded, so fr= was empty. But both moz:distributionID and moz:official got correctly set.

I tried to test suggest, too, but that doesn't work from here, dynamis reports it works within Japan. This is likely a timeout issue, we need to watch that once fx2 is released to make sure that the servers don't drop the feature under load.

Comment 29

[dynamis (Tomoya ASAI)]

Attachment: change of yahoo searchplugins

I reviewed Axel's patch.
MozParam for fr works well. The parameter will be outputed according to the pref written in firefox-branding.js. rls parameter also fine.

But during the test I found below problems:
  Values of InputEncoding and ei parameter didn't match
  Invalid SuggestionUrl is included in yahoo-jp-auctions.xml

This patch includes fix of these.

Comment 30

[Axel Hecht [:Pike]]

Comment on attachment 238620 [details] [diff] [review]
change of yahoo searchplugins

r/a=me, assuming you land this on both locales, of course.

Comment 31

[dynamis (Tomoya ASAI)]

checked in cvs, of couce for both ja/ja-JP-mac.

Comment 32

[Axel Hecht [:Pike]]

Resolved FIXED, the final search code for Yahoo will be done in bug 352781.

Please test a nightly and VERIFY that all search plugins work as expected. Preferably one with official branding, which don't exist yet :-/.

Comment 33

[dynamis (Tomoya ASAI)]

(In reply to comment #32)
> Please test a nightly and VERIFY that all search plugins work as expected.
> Preferably one with official branding, which don't exist yet :-/.

fine with unofficial nightly.
I'll mark as VERIFIED aftter check with official branding one.

Comment 34

[dynamis (Tomoya ASAI)]

All works fine with ja Firefox 2.0 RC1 - RC1
 -> VERIFIED

Here are result urls when I type "Japanese" in japanese:
http://search.yahoo.co.jp/search?p=%E6%97%A5%E6%9C%AC%E8%AA%9E&ei=UTF-8&fr=moz2&rls=org.mozilla:ja-JP:official
http://www.google.co.jp/search?q=%E6%97%A5%E6%9C%AC%E8%AA%9E&lr=lang_ja&ie=utf-8&oe=utf-8&rls=org.mozilla:ja:official&client=firefox
http://esearch.rakuten.co.jp/rms/sd/esearch/vc?p=0&sv=2&sitem=%c6%fc%cb%dc%b8%ec
http://search.goo.ne.jp/web.jsp?MT=%C6%FC%CB%DC%B8%EC&from=Firefox20&PT=Firefox20
http://shopping.yahoo.co.jp/search?p=%C6%FC%CB%DC%B8%EC&ei=EUC-JP&fr=moz2&rls=org.mozilla:ja-JP:official
http://search.auctions.yahoo.co.jp/jp/search/auc?p=%C6%FC%CB%DC%B8%EC&ei=EUC-JP&fr=moz2&rls=org.mozilla:ja-JP:official&alocale=0jp&acc=jp
http://www.amazon.co.jp/gp/search?field-keywords=%E6%97%A5%E6%9C%AC%E8%AA%9E&index=blended&tag=mozillajapan-fx-22&sourceid=Mozilla-search&__mk_ja_JP=%E3%82%AB%E3%82%BF%E3%82%AB%E3%83%8A
# above url for amazon is a redirected url
http://search.creativecommons.org/?q=%E6%97%A5%E6%9C%AC%E8%AA%9E&sourceid=Mozilla-search