350440 - Wrong icon (favicon) assigned to bookmark upon viewing error page

Status: VERIFIED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Thomas Rutter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060826 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060826 BonEcho/2.0b2

If you have a bookmark for a site that no longer exists and results in an error page, revisiting that bookmark will cause the wrong icon to be assigned to the bookmark.

Reproducible: Always

Steps to Reproduce:
1. Navigate to non-existant location such as http://www.sduhdakfhguhkuhs.com
2. Bookmark this page
3. Navigate to http://www.google.com/
4. Load the bookmark that goes to the non-existant page

Actual Results:  
google.com icon is assigned to the sduhdakfhguhkuhs.com bookmark

Expected Results:  
Either the warning icon (exclamation mark), or no icon, should be assigned to the sduhdakfhguhkuhs.com bookmark

Comment 1

[Jean-Yves Perrier [:teoli]]

I can reproduce it under MacOS and the build: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060827 BonEcho/2.0b2 ID:2006082703

Comment 2

[Jean-Yves Perrier [:teoli]]

Maybe a duplicate of bug 271359 ( https://bugzilla.mozilla.org/show_bug.cgi?id=271359 ) ?

Comment 3

[Thomas Rutter]

(In reply to comment #2)
> Maybe a duplicate of bug 271359 (
> https://bugzilla.mozilla.org/show_bug.cgi?id=271359 ) ?
> 

It's possible, but it doesn't seem like it to me and there doesn't _seem_ to be enough information to know for sure.

Bug 271359 seems to refer to some sort of race condition where you try to load a second bookmark while another site is currently loading.

This bug has clear steps to reproduce, and occurs even if the current site has fully loaded.  This bug also refers to the error pages which (correct me if I'm wrong) I don't think existed back then.

If someone can reproduce both bugs and can figure out that it is the same cause then do merge.

Comment 4

[Jackie Liu]

(In reply to comment #3)
> (In reply to comment #2)
> > Maybe a duplicate of bug 271359 (
> > https://bugzilla.mozilla.org/show_bug.cgi?id=271359 ) ?
> > 
> 
> It's possible, but it doesn't seem like it to me and there doesn't _seem_ to be
> enough information to know for sure.
> 
> Bug 271359 seems to refer to some sort of race condition where you try to load
> a second bookmark while another site is currently loading.
> 
> This bug has clear steps to reproduce, and occurs even if the current site has
> fully loaded.  This bug also refers to the error pages which (correct me if I'm
> wrong) I don't think existed back then.
> 
> If someone can reproduce both bugs and can figure out that it is the same cause
> then do merge.
> 

Agreed.  I confirm on "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060826 BonEcho/2.0b2".

Comment 5

[Ria Klaassen (not reading all bugmail)]

It is very unlikely that this will be fixed before the coming Firefox 2.0; even if you would have a safe patch I wouldn't give this much chance. The next release will use Places and in this new bookmarks/history system this bug is not present anymore.

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Any chances to get this finally fixed in Firefox 4 ?

Comment 15

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Can someone with privileges nominate this bug as blocker for Firefox 4 ?
Because I don't want that this bug will be still forgotten for more years...

Comment 16

[Marco Bonardo [:mak]]

(In reply to comment #15)
> Can someone with privileges nominate this bug as blocker for Firefox 4 ?
> Because I don't want that this bug will be still forgotten for more years...

if it's not a regression from 3.6 to 4, it won't get blocking regardless its age. So it would be a useless nomination.

Comment 17

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

dataloss should be added to keywords

Comment 18

[Steve Chapel]

The wrong favicon appearing is not critical data loss.

Comment 19

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Partially, because it overwrite favicon with this yellow triangle with "!" in center.
It's the same like it will be overwriting bookmark name or address.

Comment 20

[Marco Bonardo [:mak]]

Can you reproduce in Firefox 4 RC/Final?

Comment 21

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I can't, but nice will be when someone who also experienced bug confirm this. Because sometimes bug appear, sometimes not, as far I remember. :)

Comment 22

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Can't reproduce it anymore and no word from other users, so closing this one as WORKSFORME.
If someone feel otherwise, please reopen.