Closed Bug 350855 Opened 18 years ago Closed 18 years ago

Back/Forward button's drop-marker doesn't cover the whole height

Categories

(Firefox :: Toolbars and Customization, defect)

2.0 Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 2

People

(Reporter: zeniko, Assigned: mconnor)

References

Details

(Keywords: fixed1.8.1, regression, Whiteboard: [Fx2 theme change])

Attachments

(2 files, 1 obsolete file)

Steps to reproduce:
1. Customize the toolbar to display big icons with text
2. Navigate to two arbitrary pages in the same tab
3. Click the Back button at the interception of the horizontal line going through the text and the vertical line going through the drop-marker.

Actual result:
The previous page is displayed.

Expected result:
The drop-down is opened
Fixing bug 350151 will make this more obvious.
Depends on: 350151
Flags: blocking-firefox2?
Whiteboard: [Fx2 theme change]
Target Milestone: --- → Firefox 2
As i asked on the other bug, did you test on a build which has the fix for 350590?
(In reply to comment #2)
Bug 350853, bug 350854 and this bug were all tested with the 2006083103 nightly build which includes that fix.
Summary: Back/Forward button don't open drop-down when clicked on the text → Back/Forward button doesn't open drop-down when clicked on the text
(In reply to comment #2)
Note that this is exactly the opposite issue to bug 350590: in this case the drop-down _isn't_ opened when it actually should be.
Attached patch the fix (obsolete) — Splinter Review
Will get post-facto review on this.
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.cs
s
new revision: 1.17.2.49; previous revision: 1.17.2.48
done
Checking in browser/themes/winstripe/browser/browser.xml;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.xml,v  <--  browser.xm
l
new revision: 1.4.8.6; previous revision: 1.4.8.5
done
Attachment #236233 - Flags: review?(mconnor)
Comment on attachment 236233 [details] [diff] [review]
the fix

er, wrong bug sorry.
Attachment #236233 - Attachment is obsolete: true
Attachment #236233 - Flags: review?(mconnor)
OK, now that I read this right, this was done on purpose, see bug 349148.
Whiteboard: [Fx2 theme change] → [Fx2 theme change] WONTFIX?
(In reply to comment #7)
> OK, now that I read this right, this was done on purpose, see bug 349148.

In that case, let me rephrase this bug's issue: I've never seen a drop-marker not covering either the whole height or width of a button.

Do we really have to introduce this novelty in UI design without giving it proper thought (other than: "it looks nice and we didn't know how to otherwise fix deeper-lying issues with the drop-down pill")?
Keywords: regression
Summary: Back/Forward button doesn't open drop-down when clicked on the text → Back/Forward button's drop-marker doesn't cover the whole height
You're referring to the ~2px*~1px in the bottom right corner of the button, not to the entire label, right? Clicking on the label itself should go back/forward, as it did in 1.5. Please update the bug summary if so.

Also note it should be pretty easy to fix that. Well, as easy as adding a fixed width/height box right after the label (_not_ a allowevents-box).
Attached image screenshot
(In reply to comment #9)
> You're referring to the ~2px*~1px in the bottom right corner of the button, not
> to the entire label, right?

I'm referring to the whole part of the button to the right of the red line (cf. the screenshot). Currently the drop-down doesn't open when clicking either above(!) the pill or when clicking on the "rd" part of Forward.
It does WFM few pixels above and below the dropmarker (and yeah, above and below to that we have the allowevents-boxes which are the current extended target area of the button part).
taking to evaluate
Assignee: nobody → mconnor
Flags: blocking-firefox2? → blocking-firefox2+
(In reply to comment #7)
> OK, now that I read this right, this was done on purpose, see bug 349148.

Seems like we really should fix bug 350151, as the invocation of the dropdown is really unpredicatable...
Attached image suggested structure
green - go b/f.
red - dropdown
black - DoNothing();
Attachment #236822 - Flags: ui-review?(mconnor)
black background, not lines :)
(In reply to comment #14)
> black - DoNothing();

There should be no black at all.

Up until now, the drop-down part of the button was directly adjacent (small icons; resp. separated by a 2px margin for big icons) to the next button. This would be more obvious if we still used native toolbar buttons with bevel (which I'm still hoping for in bug 348442).
The black area is that margin. I think it's a bit bigger than 2px; but i might be wrong.
Attachment #236822 - Flags: ui-review?(mconnor)
Fixed by reverting to standard menubuttons, warts and all.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [Fx2 theme change] WONTFIX? → [Fx2 theme change]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: