Closed Bug 353571 Opened 16 years ago Closed 16 years ago

Disable Places on Trunk

Categories

(Firefox :: Bookmarks & History, defect)

x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: vlad, Assigned: vlad)

References

Details

Attachments

(2 files)

As Places work is pretty much stalled, and it will be getting a significant overhaul in the Firefox 3 timeframe, it should get disabled on the trunk until the UI is ready again.  We're not going to do any auto-migration from places to non-places; there will be a post to MDC stating what day the flip will happen for nightly builds, and that people will need to export their old bookmarks using the built-in places Export functionality.
Attached patch disable placesSplinter Review
Disable Places on trunk; note that this still leaves it enabled for xulrunner, because that doesn't depend on the UI.
Attachment #239430 - Flags: review?
Attachment #239430 - Flags: review? → review?(mconnor)
So I asked Myk to look and see what bookmarks changes had landed on the 1.8 branch that should also be landed on the trunk.  He gave a rather detailed analysis (including what landed on trunk but not branch), but the gist of it is that the following bugs landed in the old bookmarks code on branch only: bug 342930, bug 243078 (attachment 199109 [details] [diff] [review] was backed out of the branch and probably needs to be backed out of the trunk), bug 284660, and maybe bug 347210.
Depends on: 284660
Comment on attachment 239430 [details] [diff] [review]
disable places

r=me

will follow up with myk and dietrich to get branch/trunk synced, sounds like myk's already looked at this!
Attachment #239430 - Flags: review?(mconnor) → review+
Here's the diff I used in my analysis.  For each chunk, I appended a comment explaining the bug(s) it comes from and whether we need to do anything with it (i.e. apply a branch patch to the trunk).

To extract just those comments plus the files they apply to, run the following command on this file:

  egrep 'diff -uNr|@@' bookmarks-changes.diff
On MDC, it was stated that Places will be disabled in order to make the new theme landing easier. Now the new theme has landed with Places beeing enabled. I wonder if disabling Places is still required. Even though stalled, it's still functional. And even though there will be an overhaul, I guess most nightly testers (and users) would rather like to stay with Places in order to keep their history and not have to export their bookmarks.
(In reply to comment #5)
In the Places window, choose No Grouping. Right-click, choose Select All. Right-click, choose Copy. If you paste it in a text editor, it is maybe not as nice as a sidebar, but usable.
(In reply to comment #6)
> (In reply to comment #5)
> In the Places window, choose No Grouping. Right-click, choose Select All.
> Right-click, choose Copy. If you paste it in a text editor, it is maybe not as
> nice as a sidebar, but usable.

Can't you just use the exporter (File->Export in the places manager)?
(In reply to comment #7)
It exports only bookmarks currently.

Brian J Polidoro wrote: "I believe Places is being disabled because they don't want to ship 3.0a1 with Places because it's still pretty much in the same shape as it was for the 2.0 alphas."

That would make sense to me, but then again the MDC news is misleading.
(In reply to comment #9)
> Brian J Polidoro wrote: "I believe Places is being disabled because they don't
> want to ship 3.0a1 with Places because it's still pretty much in the same shape
> as it was for the 2.0 alphas."
> 
> That would make sense to me, but then again the MDC news is misleading.

Whoops, that was my fault; I wrote the MDC news item, and it should have said "Places will be going through a redesign before being reenabled", but I must've cut that out while editing it.

In any case, Places will be disabled, new theme or no.
about bug #342930, this bug (from dbaron's comment #2) does not block disabling places on the trunk.

vlad has asked me to review the patch from myk to see what (if anything) might block the disabling of places.
> vlad has asked me to review the patch from myk to see what (if anything) might
> block the disabling of places.

dbaron reviewed myk comments in his patch and listed what he saw as what was missing from the trunk (see comment #2).  

Since that time, gavin landed bug #284660 and I've landed #341654.

I've also reviewed myk's comments, and nothing has lept out that would block us from disabling places on the trunk.

Marcia gave me a link to the full functional tests for FF2.0 Bookmarks (http://litmus.mozilla.org/show_test.cgi?type=by_category&product=1&testgroup=27&subgroup=388) and I'll run through them to make sure we're not missing something huge.
Depends on: 341654
> Marcia gave me a link to the full functional tests for FF2.0 Bookmarks
>(http://litmus.mozilla.org/show_test.cgi?type=by_category&product=1&testgroup=27&subgroup=388)
> and I'll run through them to make sure we're not missing something huge.

found one issue so far:  bug #354245
Depends on: 354245
> found one issue so far:  bug #354245

update:  I'm not seeing this problem with a new profile, just with my existing profile.
I just checked this in; should I leave this bug open for the misc merging?
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Trunk hourly builds have no bookmarks.
The file bookmarks.html is absent in a new profile.
In a used profile, it does not recognize bookmarks.html. 
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Session Store is busted, too.
(In reply to comment #18)
> Session Store is busted, too.
> 
Update: Session Store and bookmarks working fine now after auto-updating to the daily.  Guess a 2nd clobber was needed. 


Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Resolution: --- → FIXED
Depends on: 354415
microsummaries don't seem to work anymore.
> microsummaries don't seem to work anymore.

dao, I've spun this off to bug #354855 so that it gets attention.

can you elaborate there?  I'll test as well to confirm.
Depends on: 354855
in addition to myk's patch (which only covers mozilla/browser/components/bookmarks), we should also review the difference between the branch and trunk within the #if[n]def MOZ_PLACES.

I'm tracking that work in bug #355651, as this bug covers disabling places on the trunk.
No longer blocks: 355651
Status: RESOLVED → VERIFIED
heads up, planning on re-enabling places on the trunk, but (as of 12/14/06) that is just history-on-places, and not all of places.

see bug #355738
Depends on: 355738
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.