354967 - Homepage is only imported on first run

Status: RESOLVED INVALID

(Firefox :: Migration, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060930 BonEcho/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060930 BonEcho/2.0

FF 2.0, clean profile.

I have Windows XP with Internet Explorer 7.0RC1. I tried import data from IE. All data imported OK but there was a problem with homepage which wasn't imported. 

Reproducible: Always

Steps to Reproduce:
1. Use File -> Import.
2. Import all data from IE 7.0RC1.
3. Homepage from IE isn't imported.




I have error message in Error Console:

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: XStringBundle :: getString :: line 17"  data: no]
Source File: XStringBundle
Line: 17

Comment 1

[Jackie Liu]

I can confirm this behavior on "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060927 BonEcho/2.0".

Comment 2

[Jackie Liu]

Somehow related/dupe of Bug 252700

Comment 3

[Kevin Brosnan]

wfm - Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.2) Gecko/20070208 Firefox/2.0.0.2

Comment 4

[u279076]

FYI: Home page is not migrated from IE 6 to Minefield 2007070604 (latest nightly).

Comment 5

[Mike Connor [:mconnor]]

IE7 Migration -> jmathies

Comment 6

[Jim Mathies [:jimm]]

On initial install, we migrate correctly on 2.0, and on Minefield. The wizard does some special processing for this, and grabs the ie home page using the sourceHomePageURL migrator property. This appears to be working correctly, for example - 

var ms = Components.classes["@mozilla.org/profile/migrator;1?app=browser&type=ie"] .getService(Components.interfaces.nsIBrowserProfileMigrator);
ms.sourceHomePageURL
http://www.yahoo.com/

is an easy way to test.

As far as the file -> import option goes, we do not import the IE homepage. It's currently commented out. (see bug 252546) I'll go ahead and uncomment and test this and post a patch. I honestly don't understand the reasoning behind that bug.

Comment 7

[Jim Mathies [:jimm]]

Actually, just bringing up the home page import panel in all cases is better. Not sure why we skip off that on the import option.

Comment 8

[Jim Mathies [:jimm]]

Attachment: import patch v.1

Not bringing up the homepage import option was global across all platforms. So this patch effects everybody, not just windows. Who ever wrote this code obviously felt this shouldn't be displayed, but I'll leave it to reviewers to decide if this should actually get checked in.

I think a better way to do this would be to not present the homepage panel, and simply add a homepage check box to the import options when the user invokes file->import. However that would require string changes and makes things complicated for rolling this into branch. I need to get with mconnor and see what he thinks about that. It wouldn't be to much work to go that route. 

For minefield builds, there are a number of strings that will not be available unless your building with --enable-official-branding. In which case the homepage panel will generate a string exception and will not be displayed.

Comment 9

[Mike Connor [:mconnor]]

I wrote that code.  The point of having the separate panel was to offer a clear choice between Firefox Start and the old home page (there was a commented out checkbox for Home Page when I implemented the panel, we spent a bunch of time on this).

Comment 10

[Jim Mathies [:jimm]]

The commented out home page option I believe was in the settings import, uncommenting that would cause the homepage to be imported with that option. Personally I don't like that much, and I don't think users will either.  I'm not convinced this really needs fixing either since a homepage is easy to import manually. The one solution that really works would involve creating a seperate homepage checkbox in the import options. It looks like that would require changes to the import cpp files, the idl interface, new strings, etc.. I'm just not convinced it's worth it.

Comment 11

[Mike Connor [:mconnor]]

Ah, gah, this got lumped in with the other "IE7 import is busted" bugs, but this is just the default behaviour, and I kept assuming it was accurate.  This is by design, but I won't mark this INVALID quite yet, its been a couple years and i want to re-evaluate this.

Comment 12

[Paul Silaghi, QA [:pauly]]

Unable to import homepage from IE9 to Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.26) Gecko/20120128 Firefox/3.6.26

Comment 13

[u279076]

(In reply to Paul Silaghi [QA] from comment #12)
> Unable to import homepage from IE9 to Mozilla/5.0 (Windows; U; Windows NT
> 6.1; en-US; rv:1.9.2.26) Gecko/20120128 Firefox/3.6.26

Paul, does this *old* bug affect any of the newer releases, or is it just on Firefox 3.6?

Comment 14

[Matthew N. [:MattN]]

From what I saw lately, it is still by design to only import the homepage on first run (see comment 11).  If Paul is saying that it doesn't import at all then that would be a different bug but would probably be resolved by bug 710895 which is in progress.  If someone feels strongly that this should be changed, we could probably request ui-review.

Comment 15

[Paul Silaghi, QA [:pauly]]

Everything works fine on FF 11b1, once with the new functionality on the first run where you can choose whether or not the homepage to be imported.

Comment 16

[Asaf Romano (gone)]

So, by design indeed, but that design isn't great -> uiwanted.

Comment 17

[Marco Bonardo [:mak]]

Bug 1434167 made this invalid