360650 - Guided form overrides platform and OS fields, which causes internal error

Status: RESOLVED DUPLICATE of bug 657317

(bugzilla.mozilla.org :: General, enhancement)

Description

[bigstijn]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; .NET CLR 1.0.3705; InfoPath.1)
Build Identifier: Bugzilla 2.22

I have now the case in my bugzilla installation that 
enter_bug.cgi lists me different values for the fields platform / OS than the guided form enter_bug.cgi?format=guided .

I changed the values with editvalues.

Probably the reason is the fact I did a migration of the database, but didn't migrate the bugzilla directory (as we did no customization)
(running checksetup didn't help)

Still, I think it would be a good idea that enter_bug.cgi?format=guided takes the same source for the (editvalues) fields as enter_bug.cgi .

Reproducible: Always

Comment 1

[bigstijn]

Well, indeed, it does: 
in create-guided.html.tmpl we have:
  [%# We override rep_platform and op_sys for simplicity. The values chosen
      are based on which are most common in the b.m.o database %]
  [% rep_platform = [ "PC", "Macintosh", "All", "Other" ] %]
[% op_sys = [ "Windows 98", "Windows NT", "Windows 2000", "Windows XP",
                "Mac System 9.x", "MacOS X",
                "Linux", "All", "other" ] %]

The problem of this construction is that the given values aren't valid anymore when editvalues is used to remove these mentioned values.

When the user submits this form, he gets the message:
Internal Error
Bugzilla has suffered an internal error. Please save this page and send it to xxx with details of what you were doing at the time this message appeared. 

URL: xxx/post_bug.cgi

A legal Platform was not set.  


Ok, create-guided.html.tmpl is full with b.m.o. code, but it should work anyhow on any installation.

Comment 2

[bigstijn]

There is also some bug around, that states that b.m.o. customization should be in a separate branch, but i can't find it now.

Comment 3

[Frédéric Buclin]

I confirm the error thrown by post_bug.cgi. If you really want a minimal list, then you should at least make sure that the displayed values are valid, e.g. by filtering and excluding all those being invalid. There is a Bugzilla::Field method to quickly get legal values.

Comment 4

[Gervase Markham [:gerv]]

The guided form is b.m.o.-specific. It's provided in the main distribution as an example of custom templates; it's not guaranteed to work for anyone else.

Having said that, there's no reason we shouldn't change it to work in the way that comment 3 suggests.

Gerv

Comment 5

[Max Kanat-Alexander]

The guided bug entry form is going to be removed from the core Bugzilla code (see bug 474086), so we won't be fixing these bugs in upstream Bugzilla. It was always just an example page, to begin with. I'm moving the bugs to the bmo component, to at least preserve a record of the fact that these things may need to be fixed for bmo.

Comment 6

[Gervase Markham [:gerv]]

The form states clearly at the top that you'll need to modify it to use it. So this is an enhancement aimed at making it more easily reusable. Which is fine.

Gerv

Comment 7

[David Lawrence [:dkl]]

Attachment: Patch to fix hard coded values in guided bug entry (v1)

Here is a patch that removes the hard code values for op_sys and rep_platform and just uses the Bugzilla legal values. Please review.

Dave

Comment 10

[David Lawrence [:dkl]]

This is no longer necessary as the guided form is being completely revamped.