364158 - New version of JEP (0.9.6), please land on trunk and branches

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

This version contains a whole slew of bugfixes (mostly new or revised
workarounds for Apple bugs), and adds some new functionality.  Most
notably JEP 0.9.6 adds support for accessing the browser's cookie
store, and unbreaks JavaScript-to-Java LiveConnect support on the
trunk (which was broken on 2006-08-21 by a change to the
nsIScriptSecurityManager interface, see bug 348559 and bug 350664).

Please land JEP 0.9.6 on the trunk as soon as possible.

This new JEP is probably too late for Firefox 1.5.0.9 and 2.0.0.1 (of
which RCs have already appeared).  If so, please land JEP 0.9.6 on
those branches as soon as those versions have been released.  With
these (possible) exceptions, please land the JEP on all relevant
branches as soon as possible.

http://javaplugin.sourceforge.net/

Those who want to try the new version right away will need to install
it "over" the older versions currently bundled with Mozilla.org
browsers.  I recommend installing the new JEP to your
/Library/Internet Plug-Ins/ folder, then removing older copy(ies) of
the JEP from your Mozilla.org browser(s).  For more information see
the JEP Readme.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Attachment: Change log for JEP 0.9.6

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I've just noticed a small cosmetic error in JEP 0.9.6's
MRJPlugin.plugin -- the version numbers in its Info.plist are
"0.9.5+h" (instead of "0.9.6" as they should be).  The version numbers
in its Resources/English.lproj/InfoPlist.strings are all correct,
however.

This will only be noticeable on OS X 10.2.8 -- its "Get Info" uses the
Info.plist version numbers.  OS X 10.3.X's and 10.4.X's (and 10.5's)
"Get Info" use the Resources/English.lproj/InfoPlist.strings version
numbers (which are correct).

This will have no effect on either programs' operation (on either
MRJPlugin.plugin or JavaEmbeddingPlugin.bundle) -- they use an
internal string to determine the version.

I currently have no plans to correct this.  If Mozilla.org feels
strongly about this, it will be possible to fix MRJPlugin.plugin's
Info.plist "by hand" before landing it.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

I should also mention that the version number in "about:plugins" for
the Java Embedding Plugin (which is stored in MRJPlugin.plugin's
Resources/MRJPlugin.rsrc) is correct -- it's "0.9.6", as it should be.

Comment 4

[Josh Aas]

I will probably correct the Info.plist on checkin if you don't mind. Thanks Steven! I'll get on this asap.

Comment 5

[Josh Aas]

Comment on attachment 248934 [details]
Change log for JEP 0.9.6

I tested this for a while and didn't see any issues.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

> I will probably correct the Info.plist on checkin if you don't mind.

Thanks!  I appreciate it.

Comment 7

[Mark Mentovai]

Impressive changelog, Steven!

Comment 8

[Steven Michaud [:smichaud] (Retired)]

> Impressive changelog, Steven!

Thanks!  Over time I've been rewriting the "plugin" part of Apple's
JVM from the inside out.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 248934 [details]
Change log for JEP 0.9.6

rs=pink

Comment 10

[Josh Aas]

landed on trunk

Comment 11

[Jay Patel [:jay]]

We're going to let this bake on the Trunk for a bit and will revisit the patch approval soon.

Comment 12

[Steven Michaud [:smichaud] (Retired)]

You should really land it on the branches right away.

The trunk has all kinds of problems of its own, and so isn't a
particularly good test of the Java Embedding Plugin.  Also, I get the
impression that there aren't a whole lot of people who test on the
trunk.

Experience tells me it's better to land it on the branches as soon as
possible -- that's a fairer test of the program, and it increases the
chances that important problems will be shaken out _before_ the final
rush to release a new version.

Comment 13

[Jay Patel [:jay]]

Comment on attachment 248934 [details]
Change log for JEP 0.9.6

Good point Steven.  Let's get this on the branch now... and we can address any issues found there quickly if needed (since we still have enough time before release).  Approved for 1.8 branch, a= jay for drivers.

Comment 14

[Steven Michaud [:smichaud] (Retired)]

> Approved for 1.8 branch

Thanks!

I'm not sure whether this applies just to the 1.8.1 branch, or also to
the 1.8.0 branch.  (I'm also not sure whether future releases are
planned on the 1.8.0 branch.)  But just in case, I'm also requesting
that this bug block the 1.5.0.10 release.

Comment 15

[Jay Patel [:jay]]

Pink/Josh:  From comment #0, it sounds like we want this on the 1.8.0 branch as well... if that is the case, please request patch approval for 1.8.0.10.

Stephen: "Approved for 1.8 branch" means we want it for 2.0.0.2 (1.8.1.2 branch).     If we need this for the 1.5.0.x releases (aka 1.8.0 branch), someone needs to request approval for 1.8.0.10.  Also, we do plan on shipping 1.5.0.x releases through spring 2007, hopefully in sync with 2.0.0.x releases.

Comment 16

[Josh Aas]

landed on MOZILLA_1_8_BRANCH

Comment 17

[Jay Patel [:jay]]

Comment on attachment 248934 [details]
Change log for JEP 0.9.6

Approved for the 1.8.0 branch, a=jay for drivers.

Comment 18

[Josh Aas]

landed on 1.8.0 branch

Comment 19

[Marcia Knous [:marcia]]

verified on the 1.8.0 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.10pre) Gecko/20070125 Firefox/1.5.0.10pre and on the 1.8 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070125 BonEcho/2.0.0.2pre. Adding relevant keywords.

Thanks for the great work Steven - all of the Firefox Mac users appreciate it!

Comment 20

[Marcia Knous [:marcia]]

Steven and Josh: Something I just noticed when running 2.0.0.3 on my PPC Mac.

Fresh install of 2.0.0.3 on PPC Mac-> I get the 0.9.6 version of JEP showing in about:plugins
Update from 2.0.0.1->2.0.0.3 using same profile-> I get the JEP 0.9.5+g+2 version showing in about:plugins.

ack.

Comment 21

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #20)

If I remember correctly, Smokey Ardisson reported this a long time
ago.  Apparently it hasn't been fixed.

Comment 22

[Samuel Sidler (old account; do not CC)]

Looking it over, it was from a stale pluginreg.dat file which is covered in other bugs.

Comment 23

[Steven Michaud [:smichaud] (Retired)]

(Following up comment #21)

The bug I (half) remembered is bug 368855 (which is probably
unrelated), and "long ago" was 2007-01-31 :-)

Comment 24

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Maybe Steven was thinking of my experience in bug 309636 (which only happened the once, as some sort of glitch, as far as I can recall)--that's the one I thought of when Sam poked me.

Stale pluginreg.dat is (among others) bug 313700, for those playing along at home.

Comment 25

[Steven Michaud [:smichaud] (Retired)]

> Maybe Steven was thinking of my experience in bug 309636 (which only
> happened the once, as some sort of glitch, as far as I can recall)

I think I'd lumped the two bugs together.  Thanks for reminding me of
bug 309636 -- your bug 309636 comment 4 (and following) does (sort of)
belong together with bug 368855 ... and it was a bit closer to "long
ago" :-)