375622 - dictionary page doesn't honor file status

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Dictionaries, defect)

Description

[Andrei Hajdukewycz [:sancus]]

The dictionary page currently displays the most recent version of a dictionary, regardless of the file status of files in that version. It shouldn't use the most recent version if the file is incomplete, disabled, etc.

Comment 1

[:Gijs (he/him)]

This actually means that while a newer dictionary version is in the review queue, nobody can install the dictionary in question (not even an older version) if they're not logged in. I think that's a pretty major problem - can I suggest updating the severity? (I'd do it myself but I'm not an owner/peer, so you can all figure that out yourself).

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This is very bad for the user experience. Requesting blocking-firefox3

Comment 6

[Justin Scott [:fligtar]]

Requesting that this be included in an upcoming AMO milestone (3.3 probably - likely too late for 3.2) would be more appropriate; this shouldn't block any release of Firefox, imo.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

This does not block the final release of Firefox 3.

Comment 11

[Fred Wenzel [:wenzel]]

The new (=reskin) dictionary page only displays public dictionaries/files.

Comment 13

[hansen]

This should be reopened. The Danish dictionary got this issue at the moment.

Comment 14

[Fred Wenzel [:wenzel]]

(In reply to comment #13)
> This should be reopened. The Danish dictionary got this issue at the moment.

I cannot reproduce this: In the development branch (https://preview.addons.mozilla.org/en-US/firefox/browse/type:3), the Danish dictionary version shown is the last public one, not the one pending review at the moment.

Comment 15

[hansen]

(In reply to comment #14)
> I cannot reproduce this: In the development branch

You're right. Just saw the Version 3.0 and then Resolved Fixed. AMO is passed 3.0 (right?), so I thought it was an error.

Do you have any timeplan for the next version (which looks really cool!), since I can't find any in the wiki?

Comment 16

[Seppo Aarnio]

This bug should be reopened as german de-de, swedish and finnish dictionsaries download alright, but installation does dot succeed at this time. 

Comment 17

[Fred Wenzel [:wenzel]]

REOPENing because it seems to be big enough a problem on trunk that a solution can't wait until the 3.2 redesign is published.

I will port the fix to trunk.

Comment 18

[Fred Wenzel [:wenzel]]

Attachment: only fetch files with the right status on dictionaries page (AMO trunk only)

This patch fixes it for the trunk: Note that because it is fixed on the reskin branch already, it should not be merged there.

Please review, fligtar so that we can get this out with the next push. Thanks!

Comment 19

[Justin Scott [:fligtar]]

Comment on attachment 304199 [details] [diff] [review]
only fetch files with the right status on dictionaries page (AMO trunk only)

r=fligtar

Remember that as of yesterday, this isn't trunk anymore and needs to go into 3.1 branch.

Comment 20

[Fred Wenzel [:wenzel]]

Thanks fligtar, also for the 3.1 branch heads-up. This is in SVN, r10626. Marking fixed and push-needed.