389642 - Default favicon shown for a redirected URL

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[John P Baker]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre) Gecko/2007072517 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre) Gecko/2007072517 Minefield/3.0a7pre

The urlbar results shows the default icon for URLs that result in a redirect

Reproducible: Always

Steps to Reproduce:
1. Go to http://addons.mozilla.org/ by typing URL
2. Navigate away
3. type |addon| in urlbar
Actual Results:  
http://addons.mozilla.org/ shows in dropdown with the default icon

Expected Results:  
I not really sure!

I'd put this as an enhancement if I could think of a suitable expected behaviour.

Comment 1

[(not reading, please use [e-mail] instead)]

confirming

Comment 2

[John P Baker]

This also now applies to the history menu and history sidebar - presumably since the check-in for bug 392392; This may now mean its component should be 'Places'.

Comment 3

[(not reading, please use [e-mail] instead)]

John, thanks for the bug report.

We have some code already that attempts to handle this, but only for bookmarks that redirect.

Note, the following scenario:

1) create a new profile
2) bookmark amo as http://addons.mozilla.org
3) click on amo bookmark
4) redirects to https://addons.mozilla.org/en-US/firefox/

we will update the favicon for http://addons.mozilla.org, because of the code in nsFaviconService::UpdateBookmarkRedirectFavicon()

some thoughts about how we could make this work for non-bookmarks places (and affect the history UI):

in FaviconLoadListener::OnStopRequest(), call a method (UpdateHistoryRedirectFavicon()) to figure out what non-bookmarked places redirect to mPageURI, and set the favicon for those pages to be mFaviconURI.  that should make this work for redirects of one level.  

for handling deeper redirects, we'll have to call UpdateHistoryRedirectFavicon() with those intermediate redirects.

Comment 5

[Dietrich Ayala (:dietrich)]

changing summary per comment #2.

Comment 8

[kcarchana77]

I would like  to work on this bug. It would be nice if you could assign this bug to me, and I will start working on it. It would also nice, if you can provide me some more details about this bug.

Comment 9

[Dão Gottwald [:dao]]

(In reply to kcarchana77 from comment #8)
> I would like  to work on this bug. It would be nice if you could assign this
> bug to me, and I will start working on it. It would also nice, if you can
> provide me some more details about this bug.

Seems like you should first find someone willing to act as a mentor in this bug. This bug may however not be ideal for that. Either way, you might want to poke someone in the irc.mozilla.org's #introduction channel.

Comment 10

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.