40033 - Pressing on a "news:" link should ask to add to newsgroup

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, enhancement, P3)

Description

[Henrik Gemal]

If you go to:
http://www.bootdisk.com/
and press the "win98" link at the top a new news account called 
"alt.windows98" is automatically added to the mail/news accounts.

This should not be the case. There should be a dialog asking the user if he/she 
want to add this news group to his default news server. Or even better ask which 
news server to add it to!

PS: Currently mozilla add the alt.windows98 as a new newsaccount which is wrong, 
but that's properly another bug...

Comment 1

[Daniel Bratell]

I think this is what Seth talks about in bug 37464. Marking as dup.


*** This bug has been marked as a duplicate of 37464 ***

Comment 2

[(not reading, please use [e-mail] instead)]

no, that other bug is something else.

this bug is a RFE, for something new.

Comment 3

[(not reading, please use [e-mail] instead)]

note, 4.x doesn't do this.  

if we ever do this, it would be configurable with a pref.

(I wouldn't want this behaviour.)

this is low on my priority list, adding help wanted, marking m30

Comment 4

[scottputterman]

moving to future milestone.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Mass moving all NEWS bugs from esther to myself.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

If there is a mailto: link on a webpage and you click it, the mail program that
is configured to use the mailto: protocol on your system will open up a compose
message window, I don't see why it should be any different for NNTP, but that's
just my opinion.  Seth - can I assign this to [e-mail]?

Comment 7

[Henrik Gemal]

Pressing a mailto: and a news: isn't the same. Pressing a mailto: just gives you 
an compose window that you can close.

Pressing a "news:alt.windows98" adds a newsaccount called "alt.windows98" to 
your list of accounts. Actually it adds a newsserver "alt.windows98" which is 
dead wrong. If it should do anything it should to adding the newsgroup 
"alt.windows98" to the default newsserver.

Since a lot of hocus pocus is done without the user knowing it (like setting the 
username and email adresse of the account "alt.windows98") I think it should ask 
the user before doing this!

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Henrik - obviously this isn't part of a Netscape spec, but a Mozilla contributor
could contribute the code if he/she wanted.  Leaving the bug as it is, in case
someone wants to add this.  I still think this should be assigned to
[e-mail] until someone steps up to the plate for this.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Setting OS to ALL

Comment 10

[Henrik Gemal]

"obviously this isn't part of a Netscape spec..."?
Why not? Aren't Netscape an News reader and a Browser?
But helpwanted is ok...

Comment 11

[(not reading, please use [e-mail] instead)]

once I land my fix for #41146, a link like "news:alt.windows98" will behave much
better.

(see that bug for details.)

Comment 12

[Henrik Gemal]

RFE cleanup. RFE is already indicated by the Severity field...Sorry for the 
spam!

Comment 13

[Håkan Waara]

I've got some rough code in my tree that does this, but it depends on the
regression in bug 39584 getting fixed.

Comment 14

[(not reading, please use [e-mail] instead)]

cc'ing jglick so she can review the proposed changes in behaviour.

hwaara, can you summarize what the user will see?

Comment 15

[Håkan Waara]

It's simple, it would be the opposite of today's auto-unsubscribe stuff.

autoUnsubscribeText=The newsgroup %1$S does not appear to exist on the host
%2$S.  Would you like to unsubscribe from it?

autoSubscribeText=Would you like to subscribe to %1$S?

Comment 16

[jglick]

Text Håkan suggested seems fine. 

Should there be a "Do not show me this dialog again" checkbox? If so, what does 
checking it to? Future - Clicking on a newsgroup link automatically subscribes 
user to the group? (Since the dialog is asking the user if they want to be 
added (vs confirming an action), its not really clear what behavior they will 
get if they don't want to see the dialog again).

Should there be a place in the UI to turn the dialog back on? If so, is it a 
global or per news server setting?

Comment 17

[Håkan Waara]

jglick, "don't ask me again"-checkboxes should only be used for actions that are
used very frequently (to not annoy the user). This is not one of those cases, as
far as I can see.

Comment 18

[Håkan Waara]

Attachment: Fix

Comment 19

[Håkan Waara]

The code is pretty straightforward. When a news link is run to auto-subscribe, 
ask the user "Would you like to subscribe to alt.blah?", if the user hits OK, 
we subscribe, if Cancel, nothing happens.  Also, this will work much better 
with the fix in bug 47981.

Bienvenu, requesting your r= here as well.  Thanks.

Comment 20

[David :Bienvenu]

Seth is the module owner for news, so he should review, and I'll sr.

Comment 21

[Håkan Waara]

I've been using this patch and this feature a lot, and it works great.   Seth, 
would you please sr=?

Comment 22

[(not reading, please use [e-mail] instead)]

GetNewPrompter() takes an nsIDOMWindow for the parent.

if we've got it, we should use the msg window for the parent, instead of always
passing null.

I'll finish reviewing later.

Comment 23

[Håkan Waara]

I'll make us pass m_msgWindow there, so if it's null it will create a parent for
us and if not we'll use the existing msgwindow.

Comment 24

[(not reading, please use [e-mail] instead)]

see nsImapIncomingServer::FEAlert() in nsImapIncomingServer.cpp for an example 
of what to do.

Comment 25

[Håkan Waara]

Funny, I coded the change before your comment and my code looks almost identical
to that function.

Comment 26

[Håkan Waara]

Attachment: Patch addressing sspitzer's comments

Comment 27

[Håkan Waara]

Attachment: Oops, this too. (forgot the .properties file change)

Comment 28

[(not reading, please use [e-mail] instead)]

1)

what's this for?

+#include "nsIMimeMiscStatus.h"

2)  now that commandSpecificData is an XPIDLCString, you can (and have to) fix
other code.

because you can:

-  if (m_messageID && commandSpecificData && !PL_strcmp(commandSpecificData,
"?cancel")) {
+  if (m_messageID && !PL_strcmp(commandSpecificData, "?cancel")) {

because I think you have to (you should double check)

- else if (commandSpecificData)
+ else if (commandSpecificData.Length())

Comment 29

[Håkan Waara]

Attachment: Hopefully final patch

Comment 30

[(not reading, please use [e-mail] instead)]

Comment on attachment 55930 [details] [diff] [review]
Hopefully final patch

r=sspitzer

make sure to test well.

Comment 31

[Håkan Waara]

Bienvenu, r=sspitzer... You know what to do.  ;-)

Comment 32

[David :Bienvenu]

Comment on attachment 55930 [details] [diff] [review]
Hopefully final patch

sr=bienvenu

Comment 33

[Håkan Waara]

fix checked in.

Comment 34

[[e-mail] (gone - use [e-mail] instead)]

This works fine if you confirm it, but goes bad on cancel...

Anyway there are 3 known issues, and they're specific cases.

See bug 108256, bug 108264 and bug 108251.

Verified FIXED, 2001-11-02 builds - Mac OS 9.1, Windows 2K, RedHat 7.2