445304 - Today-pane: width should be set mode-dependently

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Berend Cornelius]

This is a follow-up issue for Bug 429687 – Follow-up features for the mode dependent today-pane

The width of the today-pane should be stored mode-dependently.

Two interesting comments about the width of the today-pane (see bug 429687 comment #4 and comment 5:
..
I hope this is the right place to do a request about Today pane.
With today pane in calendar and tasks views it's important to consider space
optimization because with 1024x768 resolution monitor, events in month and week
views with today pane are a bit narrow.
It would be nice if today pane could be less large (at its minimum width) and
this should be possible modifying mini-day layout e.g. like shown in the
attachment image.

To gain space I also set padding and margin of agenda and task list to zero but
I see it's personal taste and anyway it could be done easily modifying
userChrome.css file.

Thanks for your attention.

Comment #5 [reply] Sven Giermann  2008-05-05 01:14:31 PDT

(From update of attachment 319164 [details])
Reducing the font-size for 'weekdayNameContainer' to 14px instead of 18px would
also bring the intended smaller width and furthermore save up some vertical
space (if the background is cropped to 40x40px).

I would also reduce the size of '.dateValue' from 36px to 24px.

I also recognized Lightning to be very large on smaller display resolutions -
maybe one should pay attention to that when designing new UIs...
...

Comment 1

[Pete Riley]

If it makes sense, please also consider bug 387575 ("Independent width of left pane in Mail/Calendar/Task modes").

Comment 2

[Pete Riley]

Also, if I change the width of the left pane in calendar mode, it changes the width of the today pane if the today pane is hidden.

This matters because I hide the today pane in calendar mode but not in mail mode, so if I change the left pane in calendar mode then it changes the today pane in mail mode.

Comment 3

[Sven Giermann]

Is this still a valid request?

I did see, that even the display switching of Today Pane (Events, Tasks or both) has been gone, so is the Today Pane still being enhanced in future?

Comment 4

[Sven Giermann]

UPDATE: It has not been gone, but not displayed (as mentioned in Bug 458074).
> In fact this buttons are not visible in some custom themes at all.

Comment 5

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
> I did see, that even the display switching of Today Pane (Events, Tasks or
> both) has been gone, so is the Today Pane still being enhanced in future?

Please ensure that you are using correct Thunderbird version and theme. After the Thunderbird theme changes from Bug 466535 you need Thunderbird 3.0b3pre from 2009-04-22 or newer. If using a custom Thunderbird theme you need an updated version of the theme too.

Comment 6

[Sven Giermann]

Thanks for this hint.
Indeed I preferred the latest localized version which indicates to be

Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1b3pre) Gecko/20090223 Lightning/1.0pre Thunderbird/3.0b2

Comment 7

[Decathlon]

Attachment: patch for width and collapsed state

This patch makes todaypane width and today-splitter state mode independent. It allows to remember todaypane width between modes and between sessions (when Lightning restarts) and the same does for today-splitter collapsed/open state so it should fix bug 430090 too.

I have a doubt about the right behavior when todaypane is enabled via todaypane button (or with F11 key). The patch remembers the collapsed state of the splitter so, if previously the pane was collapsed, when todaypane is enabled with the button it appears in collapsed state. It seems to me a logical behavior, but maybe when todaypane is enabled is it required anyway a not collapsed state?

It could probably be solved in different ways, I don't know whether the way I've chosen (if right) is the best.

Comment 8

[Sven Giermann]

(In reply to comment #7)
> ..., if previously the pane was collapsed, when todaypane is enabled
> with the button it appears in collapsed state.

Wouldn't it be more intuitive to only switch the collapsed state with the button/F11?
If this is not intended (I do not remember the discussions about it) I would vote for removing the collapsed state on enabling the todaypane with button/F11.

Comment 9

[Decathlon]

(In reply to comment #8)
> (In reply to comment #7)
> > ..., if previously the pane was collapsed, when todaypane is enabled
> > with the button it appears in collapsed state.
> 
> Wouldn't it be more intuitive to only switch the collapsed state with the
> button/F11?
> If this is not intended (I do not remember the discussions about it) I would
> vote for removing the collapsed state on enabling the todaypane with
> button/F11.

I made the patch in that way also after read bug 489152 comments #1 and #3

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 390182 [details] [diff] [review]
patch for width and collapsed state

The only concern I have with this patch is the "Show Unifinder" menuitem also becomes mode dependant. This may be a bit strange for users. On the other hand, the menu has the same issue for some other items too.

I guess I can live with that though.

r=philipp

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I need to run, I'll check in later, unless someone else wants to.

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/fef122f45e0b>

-> FIXED

Comment 13

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".