454993 - saved passwords lost/gone on migration/update from 3.0.1 to 3.0.2

Status: VERIFIED DUPLICATE of bug 454708

(Firefox :: Security, defect)

Description

[andibn63]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.2) Gecko/2008090514 Firefox/3.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.2) Gecko/2008090514 Firefox/3.0.2

After Update from Mozilla 3.0.1 to 3.0.2 all Safed Passwords are lost. 

Reproducible: Didn't try

Steps to Reproduce:
1.
2.
3.

Comment 1

[Tyler Downer [He/Him]]

Please visit http://support.mozilla.org for technical support. This is not a support center, but a technical bug reporting database for the developers.

Comment 2

[fritz.heinrichmeyer]

same here, old "signons3.txt" is still there but no more used. Also the saved password list stays empty when passwords (like for this account, luckily i could remember) are typed in again. This seems to be remarkable bug. I use the firefox from ubuntu intrepid (3.0.2).

Comment 3

[fritz.heinrichmeyer]

additional information from javascript console:

Fehler: uncaught exception: [Exception... "'[JavaScript Error: "this._storage is null" {file: "file:///usr/lib/xulrunner-1.9.0.2/components/nsLoginManager.js" line: 425}]' when calling method: [nsILoginManager::getAllLogins]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://passwordmgr/content/passwordManager.js :: LoadSignons :: line 59"  data: yes]

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

i tried to repro this and could only confirm this issue with my working profile, but not in a clean profile.
what i did:
1. create a new profile using 3.0.1
2. save a password for google.com
3. run 3.0.2 (build5) on the same profile
-> password was still available

so i tought it may be caused by an extension, but as an further test i repeated above steps with installing those extension one-by-one to 3.0.1 prior to testing the profile with 3.0.2

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

arrg, as addition to comment 4:
even after getting my test profile to my "working" profile concerning the base of installed extensions i still failed to repro :-/

Comment 6

[Tyler Downer [He/Him]]

It seems like an extension has modified something in your working profile. You can try in safe Mode, then if it does not occur then (with new passwords in the working profile) then it is 99% certain it is an extension. Disable them one by one, then if you find the one that causes it, contact the developer of the extension. i am closing as INVALID for now, since it does not seem to be a bug in Firefox, but you can reopen if you fail to find the issue. Also, you can post the name of the extension while leaving as INVALID.

Comment 7

[Tyler Downer [He/Him]]

(In reply to comment #4)
> so i tought it may be caused by an extension, but as an further test i repeated
> above steps with installing those extension one-by-one to 3.0.1 prior to
> testing the profile with 3.0.2
It was seemingly a freak thing that happened, with a messup modification.

Comment 8

[(mostly gone) XtC4UaLL [:xtc4uall]]

@Tyler: please do *not* invalidate bugreports based on feedback by just one commenter (here: me), with other commenters not having a chance to contribute (a lot of ppl do not seach for INVALID marked bugs). e.g. maybe my testing hasn't been appropriate.
thank you.

Comment 9

[Tyler Downer [He/Him]]

If this is an issue with an extension (as it certainly seems) there is no need to wait for INVALID. It is not a problem with Firefox. The reported has been given opportunity to confirm. If you can find the issue with Firefox, feel free to reopen.

Comment 10

[fritz.heinrichmeyer]

it happened with existings accounts on ubuntu on different boxes (i386, amd64) even in -safe-mode. With a clean profile passwords are saved.

Now i don't have time to investigate further but i have read going back to 3.0.1 helped another user. Maybe it is an ubuntu thing as there were 3.0.1 language extensions active in the updated 3.0.2 firefox.

Maybe this is an ubuntu bug.

Comment 11

[Tyler Downer [He/Him]]

What OS are you guys that have experienced this issue using. fritz said ubuntu, reporter was on XP, what about the rest?

Comment 12

[fritz.heinrichmeyer]

When i delete "signons3.txt" in the profile directory the password database and an new useable "signons3.txt" is built up successive again when logging in my websites.

It seems to me that data records are separated by "---". I don't want to post this database files :-) btw.

The first record in the old database makes no sense to me but until now i found no way to repair the old database by deleting or changing lines. 

Maybe encryption has changed?

Comment 13

[fritz.heinrichmeyer]

i klicked at firefox upgrade button under windows and now had the same effect (lost passwords, but i saved everything before ;-) ) also under windows XP.

Comment 16

[(mostly gone) XtC4UaLL [:xtc4uall]]

reopening since after the 3.0.2 rel there are now some more reports of lost passwords after migration. moreover the error console output of comment 3 does not point to extension relevance.

Comment 19

[felix-mozbugz]

I have the same problem on mac osx 10.5.5.

after upgrading from 3.0.1 to 3.0.2 no passwords are filled anymore. in the prefs the list of stored passwords is empty. although the 'remember passwords' option is set, firefox does not show the black pw-store-bar after loggin in somewhere. unsetting and resetting the options does not show any effect.

reverting back to 3.0.1 "solves" the issue.

Comment 20

[Carsten Book [:Tomcat]]

confirming based on the number of dupes and reports 

For anyone with this problem:

If you can still reproduce this, please enable debugging per
https://wiki.mozilla.org/Firefox:Password_Manager_Debugging and attach here.

Also it would be very interesting what extensions do you have installed?  Do you see this Problem also in Firefox Safe Mode ?

Comment 21

[Hannes Rasmus Fehr]

Reproducable in safe mode, with all extensions disabled; Not reproducable when using a new profile.

See my comment in the dupe https://bugzilla.mozilla.org/show_bug.cgi?id=456182#c8 for the complete debugging output.

Comment 23

[Ip00n]

As I showed in my bugreport: https://bugzilla.mozilla.org/show_bug.cgi?id=456704

this happens when a line from signons3.txt is read and if this line contains a character with a diacritic, like: é or ü

I added a debug line before line 853 in file:///C:/Program%20Files/Mozilla%20Firefox/components/storage-Legacy.js to log the line that was read, and it crashed on the following line:

http://members.lycos.nl (Log in om de Privé directory binnen te gaan:)


This line of code fails to read that line:

            line.value = this._utfConverter.ConvertToUnicode(line.value);

Comment 24

[u127172]

Current profile : issue reproduced

Safe mode : issue reproduced

New profile : issue not reproduced.

The error log is : 
Pwmgr Prompter: ===== initialized =====
Pwmgr Prompter: ===== promptAuth called =====
Pwmgr Prompter: getAuthTarget is for proxy auth
Login Manager: Searching for logins matching host: moz-proxy://xx.xx.xx.xx:3128, formSubmitURL: null, httpRealm: moz-proxy://xx.xx.xx.xx:3128
Login Manager: No alternate nsILoginManagerStorage registered
PwMgr Storage: Checking file signons3.txt (SignonFileName3)
PwMgr Storage: Reading passwords from /Users/skuld/Library/Application Support/Firefox/Profiles/9oxsd0e0.default/signons3.txt
Login Manager: Initialization of storage component failed: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIScriptableUnicodeConverter.ConvertToUnicode]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: file:///Users/skuld/Desktop/Firefox.app/Contents/MacOS/components/storage-Legacy.js :: anonymous :: line 853"  data: no]
Erreur : this._storage is null
Fichier Source : file:///Users/skuld/Desktop/Firefox.app/Contents/MacOS/components/nsLoginManager.js
Ligne : 464
Erreur : LoginManagerPrompter: Epic fail in promptAuth: [Exception... "'[JavaScript Error: "this._storage is null" {file: "file:///Users/skuld/Desktop/Firefox.app/Contents/MacOS/components/nsLoginManager.js" line: 464}]' when calling method: [nsILoginManager::findLogins]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///Users/skuld/Desktop/Firefox.app/Contents/MacOS/components/nsLoginManagerPrompter.js :: anonymous :: line 434"  data: yes]

Fichier Source : file:///Users/skuld/Desktop/Firefox.app/Contents/MacOS/components/nsLoginManagerPrompter.js
Ligne : 454

Comment 25

[Atsushi Sakai]

(In reply to comment #23)
> This line of code fails to read that line:
> 
>             line.value = this._utfConverter.ConvertToUnicode(line.value);

It's dupe of Bug 454708.

Comment 26

[Ip00n]

Well this dupe leads to circular reference:

This Bug 454993 -> Bug 454708 -> Bug 456661 -> Bug 454993

Comment 27

[Carsten Book [:Tomcat]]

regression of Bug 451155

Comment 30

[Carsten Book [:Tomcat]]

This Bug will be fixed by the Patch in Bug 454708

Comment 32

[Tyler Downer [He/Him]]

If fixed by Bug 454708, should we mark a dupe or resolve as fixed than?

Comment 37

[tequillaxy]

I fixed this problem in my profil by explicit saving signons3.txt in UTF-8 Format.

Comment 38

[felix-mozbugz]

(In reply to comment #37)
> I fixed this problem in my profil by explicit saving signons3.txt in UTF-8
> Format.

excellent idea! works for me, too. (mac osx 10.5.5) thanks!

Comment 39

[David Tenser [:djst]]

(In reply to comment #37)
> I fixed this problem in my profil by explicit saving signons3.txt in UTF-8
> Format.

This sounds like a workaround we should add to the KB article http://support.mozilla.com/kb/Cannot+use+or+save+passwords+after+upgrading+Firefox, unless there are risks associated with doing this.

Comment 40

[tequillaxy]

(In reply to comment #39)
> (In reply to comment #37)
> > I fixed this problem in my profil by explicit saving signons3.txt in UTF-8
> > Format.
> 
> This sounds like a workaround we should add to the KB article
> http://support.mozilla.com/kb/Cannot+use+or+save+passwords+after+upgrading+Firefox,
> unless there are risks associated with doing this.

Of course anybody should make a backup of his profile before doing this ;)

Comment 42

[[:Cww]]

(In reply to comment #40)
> (In reply to comment #39)
> > (In reply to comment #37)
> > > I fixed this problem in my profil by explicit saving signons3.txt in UTF-8
> > > Format.
> > 
> > This sounds like a workaround we should add to the KB article
> > http://support.mozilla.com/kb/Cannot+use+or+save+passwords+after+upgrading+Firefox,
> > unless there are risks associated with doing this.
> 
> Of course anybody should make a backup of his profile before doing this ;)

I'd like to get one more confirmation of this fix before adding it to the support article.

Comment 43

[rbu]

I can confirm, that the workaround with saving the signons3.txt in UTF-8
format does work. Of course, this could not be the final solution.

Comment 44

[[:Cww]]

Um, sorry, I didn't mean to change any of the stuff in the bug... I only added a comment and added myself to the CC list.  I don't have a clue why it marked it fixed, changed the blocks and dependency.

Comment 45

[David Tenser [:djst]]

Reverting changed states.

Comment 48

[Carsten Book [:Tomcat]]

v.