465.75 KB, image/png
323.38 KB, image/png
19.95 KB, patch
|Details | Diff | Splinter Review|
18.18 KB, patch
|Details | Diff | Splinter Review|
Created attachment 366755 [details] Screenshot of 3.0.6 Summary: AOL.com/AIM.com attached images aren't displaying inline. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:22.214.171.124) Gecko/2009011913 Firefox/3.0.6 works Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:126.96.36.199) Gecko/2009021910 Firefox/3.0.7 fails Steps to Reproduce: 1. Using the 3.0.7 build, log in to AOL.com or AIM.com 2. Load any email that has an attached, but normally inline-viewable image. Expected Results: Image displays Actual Results: Broken image icon displays; image is still there in the email content, though. It's content-type is: Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="2008_Lexus_IS_F_113_(400x300).jpg" Content-Type: image/jpeg; name="2008_Lexus_IS_F_113_(400x300).jpg" Sorry, I don't yet have time for a regression range.
Stephen says this is broken in Shiretoko too. I'll test this more tomorrow, but nominating for a bunch of things so it gets on the radar.
(In reply to comment #2) > Stephen says this is broken in Shiretoko too. I'll test this more tomorrow, but > nominating for a bunch of things so it gets on the radar. Yeah, broken in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b4pre) Gecko/20090310 Shiretoko/3.1b4pre, too; I won't belabour you with more screenshots.
It seems that relative urls starting with "/" don't map correctly, that's what is breaking the images on aol, with a full path it works fine. I tested this locally as well, and I'll try to get a testcase up soon.
see bug 482659 for some information (relative URL, page source, image properties)
We'll probably need to block on this since it's now a common issue.
(In reply to comment #7) > see bug 482659 for some information (relative URL, page source, image This is bug 482659. --> Core::ImgLib
I meant bug 481674...
imgLoader::LoadImage() is never called for those attached images, so the problem does not lie in imagelib. (I have a test AOL account whose credentials I will pass out to people who ask. E-mail me privately.)
(This problem also appears for AIM Mail accounts, which are freely available and are automatically created for anyone with an AIM account.)
Right. I was just trying to save someone from the (considerable!) annoyance of finding a screen name that is a) memorable and b) not taken. Fwiw, all I had to do to reproduce the bug was send a plain text message with an image as an attachment.
Do we know what regressed this?
Looking at the DOM of the page, it appears that the cause of this is that URL, baseURI, and documentURI are "about:blank" in the message <iframe>'s document. This is breaking the relative image paths used for attachments. From a quick scan of the 188.8.131.52 changes, bug 459470 could be related.
Boris, Jonas: Any idea here?
Comment on attachment 367172 [details] testcase This is wrong, although that is what shows up on AOL's frame. Bug 436965 is also a possible candidate... I'll try to narrow down some regression range.
Regression Range: 08-11-18 works 08-11-19 fails pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2d4ddc92e47d&tochange=0cd41f599080 ->Bug 445004
I think I nailed the testcase down to this: http://martijn.martijn.googlepages.com/aol_test.htm This works in Firefox 3.0.6, but doesn't work in Firefox3.0.7.
Yeah, so the key change here for bug 445004 was to change the URI and base URI used for document.written documents. They used to have something to do with the document the function calling document.write() was defined in. That bug changed it to the document the script is running on (which is not the same thing, in some cases). I did do some testing of IE's behavior wrt document.write() (see bug 445004 comment 24) and implemented something compatible with that testing. But perhaps IE has some sort of special-case behavior for situations where the document the script is running on is about:blank... Martijn, thanks for the testcase. I'll try to dig into it a bit and see what I can get from it.
Er, I take that back. On Martijn's testcase, IE7 does NOT show the image.
And I take that back too; if I change the testcase enough (work around IE's bogus handling of <html:button> and its inability to remove the load handler), then the image does show up in IE. And the key here is that in IE the base URI of the about:blank document is NOT about:blank. In particular, the image shows up even if I remove the location set from the testcase. I guess I knew that; see bug 465804 comment 2. That didn't use to work in Gecko, of course, and I wonder whether the site is using the location set to work around that... Martijn, do they really just write out the empty string in the original site?
Created attachment 367278 [details] [diff] [review] This gives about:blank URIs the loader's base URI Not completely sure how safe this is, but I think it should be ok; it's aligning us closer to IE on this matter. This also affects the base URI of window.open("about:blank"), but NOT window.open(""). In IE the latter has the base URI of the opening document. If desired, I can fix that case too. biesi says he's ok with the general necko approach and with dcamp doing the review. jst, what do you think of this in web compat terms?
Setting P1; beta exposure would be afwul nice here.
I've verified in my debug build that the patch fixes the AOL mail issue.
I'm a little worried about what new thing this patch will break, but I don't see how we can not un-break the AOL/AIM users we screwed over with 3.0.7 --> blocking184.108.40.206
Comment on attachment 367278 [details] [diff] [review] This gives about:blank URIs the loader's base URI Requesting branch approval
I've backed this out from the 1.9.1 branch since it sent all 3 unit testers orange with a variety of failures and leaks. http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.1/1237259329.1237263259.28096.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.1/1237266529.1237273366.23390.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.1/1237259329.1237269151.15938.gz
Right and I didn't notice that this hadn't baked on trunk and so was breaking there too. Totally backed out.
Hmm. I'd actually run tests on that patch, I thought... In any case, the problem is stomping on |rv| in the non-nested case in nsAboutProtocolHandler::NewChannel. Fixed that, and relanded on m-c: http://hg.mozilla.org/mozilla-central/rev/69aa67fe3314
And on 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/780e244b9b8e The leaks are an interesting question. I'll look into them; I bet some code somewhere just totally fails to deal with newChannel failing... which we should fix regardless of this bug.
Created attachment 367766 [details] [diff] [review] 1.9.0 patch
Ah, the leaks is due to NS_NewChannel assuming that the protocol handler's newChannel didn't touch the out param on failure. Filed bug 483788 on that.
Er, and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/01d135d82e30 to fix the fact that I forgot to qref on 1.9.1.
OK, the remaining leak failure was due to bug 483818 being tickled by the test. Pushed http://hg.mozilla.org/mozilla-central/rev/66e869462475 and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/73236cfcbde9 to disable that part of the test.
Created attachment 367799 [details] [diff] [review] 1.9.0 patch with the test commented out
Comment on attachment 367799 [details] [diff] [review] 1.9.0 patch with the test commented out Approved for 220.127.116.11, a=dveditz for release-drivers
Checked into CVS.
Verified FIXED in 1.9.1 using: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b4pre) Gecko/20090317 Shiretoko/3.5b4pre Replacing fixed1.9.1 keyword with verified1.9.1
Also verified FIXED on trunk using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090317 Minefield/3.6a1pre
Any idea when this fix will be available to us users? I have dropped back to 3.0.6 so that attachments will display, and can't move to 3.0.7 because of this bug. Thanks.
It should be available in the next security update, which is 3.0.8.
OK, thanks. Any idea when that will be?
My estimate would be something like approximately 6 weeks.
We're targeting a release of Firefox 3.0.8 at or around April 14. https://wiki.mozilla.org/Releases
Wonderful. Thank you.
Verified in 18.104.22.168 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:22.214.171.124pre) Gecko/2009031904 GranParadiso/3.0.8pre.
As of 3/24/09 the AOL image issue is still unresolved in Firefox 3.0.7
This issue will be fixed in Firefox 3.0.8, targeted for release in mid-April.
Don't see this any more.