Closed Bug 484567 Opened 15 years ago Closed 15 years ago

Make sure native theming of groupboxes on Windows introduced no UI regressions

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Details

Attachments

(4 files, 2 obsolete files)

Preferences window
40.72 KB, image/gif
Details
Comparison of before/after/with patch
55.30 KB, image/gif
Details
Patch
1.39 KB, patch
neil
: review+
Details | Diff | Splinter Review
Page info with attachment 369932, classic and modern theme
54.97 KB, image/png
Details 
Bug 390734 introduced native theming of groupboxes on Windows. This changed padding and margin for groupboxes. See Bug 483327, Bug 480898, Bug 483187, Bug 484013 and Bug 484374 for how this affected Firefox and how this can be fixed.
Attached image Preferences window — 
Ok, so the good thing is it no longer cuts off the border of the groupbox. It looks like the patch from Bug 483187 needs to applied to the SeaMonkey theme(s?), too.
Actually we already use the fix from Bug 483187. The styling actually matches the groupboxes in the Windows control panel for example, so I guess the new styling in the preferences window is ok.
Attached patch Patch (obsolete) — — Splinter Review 
This is the patch from Bug 484374 ported to SeaMonkey. I changed the margin to 2px as this matches the old behavior.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #369770 - Attachment is patch: false
Attachment #369770 - Attachment mime type: text/plain → image/gif
Attachment #369769 - Flags: review?(neil)
Comment on attachment 369769 [details] [diff] [review]
Patch

Hrm wait, do I need to make this Windows-only?
Attached patch Patch (obsolete) — — Splinter Review 

        Attachment #369769 -
        Attachment is obsolete: true

        Attachment #369931 -
        Flags: review?(neil)

        Attachment #369769 -
        Flags: review?(neil)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  

        Attachment #369931 -
        Attachment is obsolete: true

        Attachment #369932 -
        Flags: review?(neil)

        Attachment #369931 -
        Flags: review?(neil)

    
  

        Attachment #369932 -
        Flags: review?(neil) → review+

    
    

    
  
Comment on attachment 369932 [details] [diff] [review]
Patch

Looks like Modern has far too much top padding on its other groupboxes anyway.

    
    

    
  
Pushed to comm-central, changeset 0e50058d747a.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: