Closed Bug 490621 Opened 16 years ago Closed 15 years ago

Fullscreen mode leave some unhided pixels on the top...

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b2

People

(Reporter: Virtual, Assigned: dao)

References

(
URL
)

Details

(Keywords: nightly-community)

Attachments

(1 file)

make fullscr-toggler as small and unobtrusive as possible
849 bytes, patch
asaf
: review+
faaborg
: ui-review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-PL; rv:1.9.2a1pre) Gecko/20090428 Minefield/3.6a1pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-PL; rv:1.9.2a1pre) Gecko/20090428 Minefield/3.6a1pre Fullscreen mode leave unhided some pixels on to bottom of my screen Reproducible: Always Steps to Reproduce: 1. Go to "http://deadpixel.googletoad.com/" 2. Click button "Lunch the Application" 3. when page is loaded, press F11 or other fullscreening button Actual Results: I see unhidden pixels on bottom on my screen... Expected Results: I dont want to see unhided pixels, but properly fullscreening mode like in Opera or Chrome ;)
Summary: Fullscreen mode leave unhided some pixels on to bottom... → Fullscreen mode leave unhided some pixels on the top...
(In reply to comment #0) > I see unhidden pixels on bottom on my screen... on the TOP of course...
Can you provide a screenshot and attach it to this bug?
bump... adding links too see for ppl how bug look like on Firefox http://i39.tinypic.com/2568tie.png and how look like when bug is gone (on Chrome and Opera for example)... http://i40.tinypic.com/10p7sqp.png
(In reply to comment #4) > the line is intended -> https://bugzilla.mozilla.org/show_bug.cgi?id=240859#c5 > -> related/dupe of bug 348880/bug? Intended ? Then where's my fully fullscreen mode, where I can see only page, not bars, controls or etc. ? If this will be intended, this bar will be hiding like in Chrominium or IE...
than what will we be doing about this bug... ? It's still unconfirmed, but I show ppl that's a "problem"...
Resolving INVALID based on bug 240859 comment 5, this is intended.
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
I don't think that bug 240859 comment 5 actually solves his original problem: in his own words, the patch developer says "On fullscreen, it will hide the navigation bar and tab strip, and put an extremely tiny bar at the top of the screen." What this person is asking for is *no* tiny bar whatsoever (as well as my Bug 570982 duplicate).
Either way, this would make Bug 570982 not a duplicate, or this bug unresolved, unless I'm missing something.
We can make the line thinner (i.e. 1px). We cannot hide it completely, as we still need it as a mouseover target.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
Assignee: nobody → dao
Status: UNCONFIRMED → ASSIGNED
Component: Tabbed Browser → Theme
Ever confirmed: true
OS: Windows XP → All
QA Contact: tabbed.browser → theme
Hardware: x86 → All
Component: Theme → General
QA Contact: theme → general
Yep, It didn't solve my problem. Cause fullscreen mode should be fullscreen, not only partial with menus, bars, tabs etc... I can't e.g. stress my LCD with pixel burn tests ;p Could we mark this as wanted in Firefox 4.0 ? And reconsider changing this "bad" behavior for sth like autohiding upper menu and autohiding scrollbars (down & right) like it's partially in Chromium (except scrollbars) to get clean fullscreen like in Opera.
Summary: Fullscreen mode leave unhided some pixels on the top... → Fullscreen mode leave some unhided pixels on the top...
(In reply to comment #11) > We can make the line thinner (i.e. 1px). > > We cannot hide it completely, as we still need it as a mouseover target. odd, Chromium didn't need to have it as far I see
Dão Gottwald: well, if Chrome can do it, it's obviously not *impossible* to have it completely and totally invisible, they still have that "leave fullscreen" box appear when you move your mouse to the top of the screen. Otherwise, there's no reason to have anything happen when you move your mouse to the top of the screen (that's also acceptable behavior in my opinion); the mouseover target could be removed completely and leaving fullscreen mode would rely entirely on the F11 hotkey. That said, there's still an issue with that: when mouse/keyboard controls are being used by an embedded java applet, for example, the F11 hotkey doesn't work until you give focus back to firefox again; that would need to be overcome before the hotkey could be completely and totally relied on. A similar issue with the changes made by bug 240859 comment 5: when such an applet is flush with the tool-bars (no space between top of page area and applet) and fill 100% of the vertical and horizontal page area, after going into fullscreen mode (hiding toolbars/addressbar area) and then hovering over them again (making them visible), with the current implementation it appears that you need to then go back to hovering over a "regular" html area for firefox to hid the toolbar/addressbar area again. The (annoying) workaround, of course, is to fully exit fullscreen mode, and then re-enter again. Does a new bug need to be opened for this issue, or is it essentially the same bug?
(In reply to comment #14) > (In reply to comment #11) > > We can make the line thinner (i.e. 1px). > > > > We cannot hide it completely, as we still need it as a mouseover target. > > odd, Chromium didn't need to have it as far I see The only way to avoid the line would be to steal the mouseover event from web content, which we don't want.
Dão Gottwald: I suppose I'm not understanding you: doesn't the mouseover region "steal" from web content? How about this: make your mouseover region the same color as the page background color? It wouldn't work well with pages that have images for background, but then again, (of the websites I use) few do.
(In reply to comment #17) > Dão Gottwald: I suppose I'm not understanding you: doesn't the mouseover region > "steal" from web content? It makes the content area smaller, but it doesn't consume the mouseover event when web content might want to consume it as well.
So how about making this 1 pixel tab transparent when we not using it and turn non transparent when we hover mouse on upper side of the screen It will be possible to do sth like this ?
Comment on attachment 450168 [details] [diff] [review] make fullscr-toggler as small and unobtrusive as possible So, now that bug 532569 is fixed, cannot we overlay the browser area?
We can, but we should not do it permanently, as it's the web page's screen real estate. Making the top row inaccessible as long as you're in full screen mode isn't technically sound.
Why do we need the mouseover area in the first place? (Comment 15)
In order to show the browser UI when you move the mouse to the top of the screen.
Indeed; I should have been more specific: why do we need to show the browser user interface while in fullscreen? My point is that Firefox would work just as well (if not better) without. Or, for the people that like it, perhaps two different fullscreen modes could be implemented? (clever names would have to be invented to help people understand what each does without actually having it described to them) One with and one without the UI. I think everyone would be happy with that (those that hate the little 1-10px bar in fullscreen mode, and those that still want to type urls and do tab-switching in fullscreen).
Feel free to hide that bar with #fullscr-toggler { display: none; } in userChrome.css. I don't think we'll implement two modes, but feel free to file a new bug on this as well.
Blocks: 240859
Comment on attachment 450168 [details] [diff] [review] make fullscr-toggler as small and unobtrusive as possible r=mano for the code. ux should look at this too.
Attachment #450168 - Flags: review?(mano) → review+
Comment on attachment 450168 [details] [diff] [review] make fullscr-toggler as small and unobtrusive as possible Alex: This replaces the gray 5px high line with a black 1px high line. It is practically invisible but very easy to hit by rushing the mouse to the top of the screen.
Attachment #450168 - Flags: ui-review?(faaborg)
Attachment #450168 - Flags: ui-review?(faaborg) → ui-review+
Comment on attachment 450168 [details] [diff] [review] make fullscr-toggler as small and unobtrusive as possible >We cannot hide it completely, as we still >need it as a mouseover target. we should also go back and try to hide it completely if we get the ability to place chrome over content (in this case invisible chrome).
http://hg.mozilla.org/mozilla-central/rev/580205b95ceb
Status: ASSIGNED → RESOLVED
Closed: 16 years ago → 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7b1
Is it intended that in Minefield m-c builds that the 'Menu Button' is not hidden when entering full-screen ?
Depends on: 575994
(In reply to comment #31) > Is it intended that in Minefield m-c builds that the 'Menu Button' is not > hidden when entering full-screen ? That's bug 575155.
Target Milestone: Firefox 3.7b1 → Firefox 3.7b2
See Also: → 1126026
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: