505569 - Mark As Read and Mark All As Read non-Latin problem (Shift+key and key don't work)

Status: UNCONFIRMED

(Thunderbird :: Message Reader UI, defect)

Description

[Eugene Savitsky]

Using non-Latin keyboard (expl. Russian) I not able to "mark/unmark Read" (M) or "mark/unmark All Read" (the new Shift-C) using keyboard shortcuts.

It had worked CTRL-Shift-C for marking All Read, but now it is changed to Shift-C and it does not work eith Russian, I have to switch to Latin keyb to mark smth.

All other shortcuts without CTRL does not work as well.

Comment 1

[Mark Banner (:standard8)]

(In reply to comment #0)
> It had worked CTRL-Shift-C for marking All Read, but now it is changed to
> Shift-C and it does not work eith Russian, I have to switch to Latin keyb to
> mark smth.

Is this something the Russian localization should be handling? Or some bigger problem with gecko/Thunderbird/Firefox?

Comment 2

[Eugene Savitsky]

I'm sure it all non-Latin problem. The just M also does not works.

Comment 3

[Magnus Melin [:mkmelin]]

I'm not sure this bug is valid. We have to be able to use Ctrl+Shift+[a key] even though that's not possible on some keyboards.

Comment 4

[Simon Paquet [:sipaq]]

Bringing in the Russian l10n team specifically.

Guys, how do you handle this in the ru localization? I guess you're using a different keyboard shortcut. Can you confirm that?

Moving back to UNCO for now.

Comment 5

[Alexander L. Slovesnik]

WFM on Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9.1b3pre) Gecko/20090223 Thunderbird/3.0b2 ID:20090223124157
Unfortunately reporter haven't specified version of Thunderbird and OS. If he is using Thunderbird 2.0 on Linux, then this bug is dupe of Bug 69230.

Comment 6

[Eugene Savitsky]

I mentioned Trunk build in this bug. I'm on Windows. XP and Win7. Both do not work. On Win7 CTRL-Shift-C opens Lightning Calendar (on XP it's not installed).

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.3pre) Gecko/20090823 Lightning/1.0pre Shredder/3.0b4pre

It stopped to work around June or July 2009.

Comment 7

[Alexander L. Slovesnik]

Looks like a dup of Bug 503060.

Comment 8

[Alexander L. Slovesnik]

Though probably it's not a case. I'll download Russian trunk build and recheck.

Comment 9

[Alexander L. Slovesnik]

(In reply to comment #4)
> Guys, how do you handle this in the ru localization? I guess you're using a
> different keyboard shortcut. Can you confirm that?
No, we are not touching command keys. "mark/unmark Read" is http://mxr.mozilla.org/l10n-mozilla1.9.1/source/ru/mail/chrome/messenger/messenger.dtd#362
"mark/unmark All Read" is http://mxr.mozilla.org/l10n-mozilla1.9.1/source/ru/mail/chrome/messenger/messenger.dtd#371

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

The shortcut for "mark all as read" was intentionally changed from Ctrl-Shift-C to Shift-C around that time, specifically to open up that key combination for Lightning to use.  If it's not already, the bug for that should be marked with the "relnote" keyword so that we can include this in the release notes for Tb3.

Comment 11

[Alexander L. Slovesnik]

Confirmed on Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9.1.3pre) Gecko/20090824 Shredder/3.0b4pre ID:20090824030519
Besides Shift+C/M following keys doesn't work on single message (when using Russian keyboard layout): J, S, Shift+J, C, Shift+C, A.
I don't have time right now to test it all (it's 03:16AM here), but looks like all single letters or Shift+single letter combinations don't work on message using Russian keyboard layout.
CTRL+letter combinations works fine though.

Comment 12

[Alexander L. Slovesnik]

Please, ignore last comment.

Comment 13

[Rimas Kudelis [use needinfo to ping]]

AFAIK, having Ctrl depressed toggles the "ANSI key" mode on Windows, and that's why the shortcuts using Ctrl work with Russian keyb. However, for Shift-key and plain key shortcuts, you're supposed to use letters that exist on the keyboard, I guess.

I wonder how other applications solve this issue with non-latin locales? Perhaps they simply avoid keyboard shortcuts without Ctrl?

Comment 14

[Alexander L. Slovesnik]

So, looks like a problem that CTRL+<letter> or ALT+<letter> combinations are not affected by keyboard layout (due fix for Bug 69230), but SHIFT+<letter> and <letter> combinations are affected. This is not issue for Firefox (afaik it doesn't use SHIFT+<letter> and <letter> combinations), but it's problem for Thunderbird.
When Thunderbird dropped CTRL from CTRL+SHIFT+C it regressed functionality. Probably we should relnote it and resolve this bug as WONTFIX, unless someone volunteer to look into SHIFT+<letter>/<letter> - <keyboard layout> interaction.

Comment 15

[Alexander L. Slovesnik]

(In reply to comment #14)
> So, looks like a problem that CTRL+<letter> or ALT+<letter> combinations are
> not affected by keyboard layout (due fix for Bug 69230)
For reference, ALT+<letter> combinations are affected by keyboard layout (Bug 177508).