511656 - Get about:rights into Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

about:rights doesn't seem to be in Fennec at the moment.  It should be!

Comment 1

[Madhava Enros [:madhava]]

Can we use the already localized versions from Firefox?  Or does it have to be localized all over again?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

The files are currently firefox-specific. We can copy the l10n files over, I guess, but it's still going to be a pain to keep them in-sync if we end up changing one or the other. We could probably move this code to toolkit and avoid having to fork it.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Is the text Firefox specific? I mean desktop Firefox. I guess moving it to toolkit is still a bit non-browser specific.

I'm not too worried about forking the text

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I don't see anything desktop-firefox specific in about:rights - it all applies equally to us AFAIK. I think we should try and move it.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> I don't see anything desktop-firefox specific in about:rights - it all applies
> equally to us AFAIK. I think we should try and move it.

OK. That's better in the long run.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

fixed by bug 512843 (though see bug 514953 and bug 514822 for followup issues)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Verified with 20090910 1.9.2 nightly build on my n810

Comment 8

[Aakash Desai [:aakashd]]

This is ...bad, there's no about:rights page on trunk. Bug https://bugzilla.mozilla.org/show_bug.cgi?id=516053 was filed for that.


This is verified as fixed on build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090911 Fennec/1.0a3

Comment 9

[Aakash Desai [:aakashd]]

There should be a BFT subgroup for about: pages as there's a number of them for fennec. Let's keep this going with about:fennec, about:firefox, about:, about:certerror, about:buildconfig and any others I'm forgetting at the moment.

Comment 10

[Aakash Desai [:aakashd]]

Litmus testcase https://litmus.mozilla.org/show_test.cgi?id=9688 takes care of strings for about:rights. This will test the functionality of the page inherently.

Comment 11

[Aakash Desai [:aakashd]]

Litmus testcase https://litmus.mozilla.org/show_test.cgi?id=9761 has also been created.