525574 - Delete and Junk buttons too wide with icons beside text

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: screenshot

See attached screenshot. According to philor the button's taking the width of Undelete and Not Junk.

Comment 1

[Phil Ringnalda (:philor)]

Can't block on it, since it's pretty much unfixable: they are <deck>s that need to be as wide as their widest child image+label, since if they weren't the whole rest of the toolbar would jump back and forth as you went from a non-junk message to a junk message, or a deleted message to a non-deleted.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Well, that's not entirely true.  I'm sure Andreas could whip up a patch to make the buttons the same size as their text, and give them extra padding if they're smaller than the other button text…

Andreas?  ;)

Comment 3

[Phil Ringnalda (:philor)]

Sure, we could say that this bug is about the hover border, and then file another one about the amount of space.

Comment 4

[Phil Ringnalda (:philor)]

And I'd still say that it isn't a blocker at 5pm on a freeze day :)

Comment 5

[Andreas Nilsson (:andreasn)]

this seems to appear on Linux and Mac too.

Comment 6

[Jim Porter (:squib)]

It wouldn't be so bad if the text were centered, which shouldn't affect the other buttons at all.

Comment 9

[Yves Goergen]

> Can't block on it, since it's pretty much unfixable: they are <deck>s that need to be as wide as their widest child image+label

What is a <deck>? And what other child of a devil is there hidden inside that button? I can only see the icon and the text and the empty space at the right side, and it looks ugly. Why exactly can't this unused space be freed? It was still good in Thunderbird 2 (which I happen to have upgraded from right now...).

Comment 10

[Yves Goergen]

Attachment: The button widths seems to be increasing by versions.

Comment 11

[Jim Porter (:squib)]

(In reply to Yves Goergen from comment #9)
> It was still good in Thunderbird 2 (which I happen to have upgraded from
> right now...).

If you want the Thunderbird 2 way, then choose "Icons and Text" in the Customize dialog for the toolbar.

Comment 12

[Yves Goergen]

Alright, here's the bug fix: Add the following to your userChrome.css and the button has regular width again.

toolbarbutton#button-mark-undelete
{
    display: none !important;
}

It seems that the button text is supposed to show "Restore" but I couldn't manage to actually see it. So I guess I won't miss it, too. Dunno about the Junk button, my spam filter works on the server and I usually don't speak with it.

PS: DOM Inspector is not declared compatible with any recent Thunderbird version. How do you hackers get along without it? It's not perfect but it still works well enough to find out elements and IDs like this one.

Comment 16

[Thomas D. (:thomas8)]

Attachment: Screenshot: Message header buttons on 91.1.2 with Junk and Delete correctly sized

.

Comment 17

[Thomas D. (:thomas8)]

Wfm in TB 91.1.2, Win10, see screenshot attachment 9243418 [details].