531777 - Action button in folder picker dialog ("Save all attachments"/save multiple messages etc.) is labelled "Open" instead of "Save" [Mac, Linux]

Status: NEW

(Thunderbird :: Mail Window Front End, defect)

Description

[u142003]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.5) Gecko/20091112 Thunderbird/3.0

When saving all attachments in an e-mail, the save button on "Save All Attachments" dialog says "Open" instead of "Save". The button saves all attachments as expected, though.

Reproducible: Always

Steps to Reproduce:
1. Open an e-mail sent to you with a couple of attachments
2. Right click in the attachments pane and select "Save All..."
Actual Results:  
The blue Save button says "Open".

Expected Results:  
The blue Save button should say "Save".

Comment 1

[u142003]

Attachment: Save all Atachments dialog in TB3

Uploaded a screenshot of the dialog.

Comment 2

[Jonathan Protzenko [:protz]]

I don't think this is a bug in Thunderbird but rather a bug in the native Mac OS filepicker that should say "select" or maybe "pick this" instead of saying open. I'm not sure we can customize this... Neil, any thoughts?

Comment 3

[[e-mail]]

I don't know about the Mac but I don't think Windows lets you change it either.

Comment 4

[:aceman]

This is a problem on Linux too.
It seems the FilePicker in this case is called with Mode="select_folder" and then the native toolkit (GTK, QT, Win32,...) will pick the text on the button (Open). This mode is probably needed to allow choosing a folder only.

When saving one attachment, Mode="save" picks the correct text (Save). But it's aim is to choose a folder but also get a filename from the user (usually prefilled).

So it is probably necessary to keep both modes separate. I don't know if there are any other modes available from the toolkit which would help here.

Comment 5

[Thomas D. (:thomas8)]

Per comment 4, this is not only seen on MAC, but also on Linux -> Platform: All (in lack of more refined options)

Comment 7

[tasso.mulzer]

Wow .. this bug really lives in Thunderbird for 11 years, now?!
I just changed to thunderbird some days ago - it causes me pain when saving attachments. I'll almost call this button (Save all) broken.
Severity of "minor" doesn't fit here.

I can't "Save all" attachments with an "Open" dialog - it just won't save anything anywhere, at least in linux.

Comment 8

[Thomas D. (:thomas8)]

(In reply to tasso.mulzer from comment #7)

Wow .. this bug really lives in Thunderbird for 11 years, now?!

Kindly read the comments on this bug to understand that most likely it does not live in Thunderbird, but in the native filepicker dialogs provided by the OS.

I can't "Save all" attachments with an "Open" dialog - it just won't save anything anywhere, at least in linux.

What happens if you do "Save all", select a target folder, and click "Open" (as in "open/use/select this folder for saving")?
If it does not save your attachments into that folder, please file a new bug for that.

Comment 9

[u621994]

(In reply to tasso.mulzer from comment #7)

I can't "Save all" attachments with an "Open" dialog - it just won't save anything anywhere, at least in linux.

(In reply to Thomas D. from comment #8)

What happens if you do "Save all", select a target folder, and click "Open" (as in "open/use/select this folder for saving")?

Saving multiple attachments here works as it should using Ubuntu 20.04 and Thunderbird 68.8.0.

Comment 10

[tasso.mulzer]

Hello Thomas,

(In reply to Thomas D. from comment #8)

(In reply to tasso.mulzer from comment #7)
Kindly read the comments on this bug to understand that most likely it does not live in Thunderbird, but in the native filepicker dialogs provided by the OS.

Hmmm, I can't tell where it really lives .. in Thunderbird which selects and configures one of the multiple filepicker dialogs, an OS provides .. or in the filepicker dialog of the OS itself.

My profession is mechatronics, with just a little knowledge about software and programming - far from enough to understand the details inside of thunderbird (I tried, but didn't get that deep).

I can't "Save all" attachments with an "Open" dialog - it just won't save anything anywhere, at least in linux.

What happens if you do "Save all", select a target folder, and click "Open" (as in "open/use/select this folder for saving")?
If it does not save your attachments into that folder, please file a new bug for that.

If I click "Open" .. nothing happens .. the "Open" button changes to the active-color and stays active but nothing further happens.
When I select the attachments, do a right-click and "save all" then I do get a different dialog with a "Save" button at the lower right for each of the attachments.

It's an updated Arch-Linux (Manjaro) - with KDE / Plasma
Qt: 5.14.2
KDE: 5.70.0

Kind regards and thank you for looking into it. - I won't mind if that's not solved in the next decade - I'll work with thunderbird anyway and use the context menu.

Comment 12

[Thomas D. (:thomas8)]

Attachment: For comparison: Win10: Choose Folder dialog with [Select Folder] button on 78.10.0

For comparison: TB's folder picker dialog for saving multiple messages on Win10/TB 78.10.0 is better (but also not ideal, e.g. no hint for saving):

Dialog titled "Choose Folder" (that looks set by TB, as it's non-localized), button labelled "Ordner auswählen" (German for "Select/choose Folder", so that's probably Win10-dialog-inbuilt).

Comment 13

[John Flower]

This issue as reported 13 years ago is still present as initially reported.

I experience it in Gnome 3 on Fedora 37. Other applications are able to provide a normal 'Save as' dialogue box - it would be nice if Thunderbird could fix this. Unexpected behaviour like this means I have to explain to new staff why Thunderbird is doing something weird and it reduces the appeal of switching from proprietary software to open source.

In addition to the jarring 'Open' button I can not navigate my filesystem by typing the first few characters of the directory that I want to enter.