54885 - alternative mailnews 3-pane forgets sizes

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[R.K.Aa.]

2000100106 linux

this happened sometime the past 36 hours:

the alternate 3-pane display (two top panes + 1 bottom for mailbody
now forgets the sizes user sets.

It also initially opens with the top left pane (folders) much too narrow:
impossible to see what accountnames or foldernames are.

(The default 3-pane setup remembers size OK.)

Comment 1

[R.K.Aa.]

Also: The mailheader doesn't initially display till horizontal splitter is moved
up or down. Then it "snaps" into place.

Comment 2

[justin hugh daly]

it's been happening for awhile (at least a few days) in win32 as well...

Comment 3

[bjwhite]

This is still an issue.  I'm using build 2000101808

In my case, not only is the upper left pane (folder pane) too small, but when I
resize it, the folder names are not "drawn" on the screen.  The Pane is mostly
blank.

To correct this, I can hit the middle of the horizontal sizer and go to 2-pane
view (messages and body only) and then repeat to return to 3-pane view.   Then,
I can successfully see all of my folder names (they are painted properly)

Comment 4

[R.K.Aa.]

*** Bug 58182 has been marked as a duplicate of this bug. ***

Comment 5

[R.K.Aa.]

OS: All

Comment 6

[Scott Brodmerkle]

*** Bug 58025 has been marked as a duplicate of this bug. ***

Comment 7

[R.K.Aa.]

*** Bug 62371 has been marked as a duplicate of this bug. ***

Comment 8

[R.K.Aa.]

seems this has been fixed. WFM.

Comment 9

[R.K.Aa.]

2000121621

Comment 10

[Ninoschka Baca]

Build 2001-02-19-08: NT4, fixed.
Build 2001-02-19-04: Mac 9.04, fixed.

Reopening
Build 2001-02-19-08: Linux RH 6.2, using the alt-3pane the size is
1. remembered if at one point during the session Nav closes/quits:
- Mail and Nav are open, close Nav first, then quit Mail.
- Mail and Nav are open, close Mail, then close/quit Nav
- Mail and Nav are open, quit Nav (which also closes Mail)

2. not remembered if
- only Mail is open and a close/quit is performed.

Additional Notes:
- The position of the window being remembered worked in a similar fashion.

Comment 11

[Ben Ruppel]

I think this just started up again.  Every time I open the mail window in win2k,
the top splitter is in the dead center of the window and it doesn't remember my
moving it.

Comment 12

[Ninoschka Baca]

Marking nsbeta1. The alt-3pane window should remember the size of the panes the 
user sets.

Comment 13

[scottputterman]

reassigning to ssu.

Comment 14

[R.K.Aa.]

Didn't know this was reopened. I filed it again as 72365 (blocker of bug 72338)
since the new outliner code likely had something to do with it this time.
One of these (54885 or 72365) should be dup'ed against the other.

Comment 15

[scottputterman]

*** Bug 72365 has been marked as a duplicate of this bug. ***

Comment 16

[[e-mail]]

I have been having problems with the message pane forgetting its size.
With old versions of Mozilla it never remembered it size.
With new versions of Mozilla it remembers its size if the folders are collapsed.
So I have written a patch specifically for this bug.
The same problem appears to be occurring horizontally:
The folder pane forgets its size unless Account Central is open.
Interestingly both outliner and account central ignore their flex="2".

Comment 17

[[e-mail]]

Attachment: fingers crossed this patch fixes everything

Comment 18

[Sean Su]

The patch seems to fix the problem under the Alt-3pane.  However, it does not 
remember if the panes are collapsed or not.  Probably a different bug.

I'm still looking at the patch a bit more.  I'll r= when I'm done.

Comment 19

[racham]

I noticed the flex value for "accountCentralBox" changed from "2" to "1". The
reason to have it as 2 is that AccountCentral page is shown when an accountlevel
folder is selected hiding threadpane and messagepane. So, it looks much better
to have AccountCentral page to have the same flex that threadpane as
AccountCentral has data which needs more space. My guess is when you change the
flex from 2 to 1, folderpane will occupy half of the screen and AccountCentral
the remaining half. Sean, when you run this patch, please do update the bug with
what you notice. thanks.

bhuvan

Comment 20

[Sean Su]

there was a problem with neil's patch and the accountCentralPane.  I'm attaching 
another patch that will deal with the accountCentralPane and fix this bug.

Comment 21

[Sean Su]

Attachment: patch that also deasl with the accountCentralPane

Comment 22

[Sean Su]

Attachment: patch after talking with bhuvan.

Comment 23

[Sean Su]

Attachment: patch with last bhuvan suggestion

Comment 24

[Sean Su]

got r=bhuvan for the last patch.

Comment 25

[(not reading, please use [e-mail] instead)]

looks like a grippy got added, were we missing one (based on the spec?)

also, a box got removed.  that looks right to me, but as bhuvan knows, we've had
wild bugs show up when we've made minor changes like that.

make sure to test that everything still looks good after resizing the window,
especially on other platforms.  (I think it was resizing on linux that had
problems last time.)

I'm sure you tested switching to and from account central (bhuvan probably asked
you that in the review.)

I'll give a fast sr= once I know how you tested this.

Comment 26

[Sean Su]

finally got it tested under mac and linux (it has already been tested under 
windows).  I also asked Jennifer Glick about the grabber.  She said it's okay.

Comment 27

[(not reading, please use [e-mail] instead)]

thanks for testing and checking with jglick.

sr=sspitzer

Comment 28

[[e-mail]]

I wondered why you put align="horizontal" on my mail3PaneVertLayoutBox but I
realize that it's to make the splitter work. I should point out that align is
deprecated and you should use orient="horizontal". I also know that there is an
outstanding bug that says that splitters should just "work" without align/orient.

Comment 29

[Keyser Sose]

*** Bug 77787 has been marked as a duplicate of this bug. ***

Comment 30

[Sean Su]

The patch has been checked in with the 'orient' attribute instead of the 
'align'.  Thanks for pointing it out.

Comment 31

[R.K.Aa.]

only half fixed, i'm afraid.

When alternate three-pane is started, it will always start displaying a
"two-pane". (Very annoying, but that's how it is.)

To the right in this two-pane setup is the account managment pane.
In the middle is a vertical splitter.
To the left are accounts in tree-view.

First when i select the inbox of an account, the alternate 3-pane displays in
all it's glory. Between the upper two panes is a vertical splitter

After this checkin behaviour changed, but only one vertical splitters position
is remembered.

So: If i resize the "two-pane" - that is remembered next time i open mailnews.
But then the vertical splitter in three-pane is forgotten, and becomes centered
instead.

And vice versa: If i resize the vertical splitter in 3-pane, the vertical
splitter between account three-view and manage-pane is forgotten.

So this is still a bug - we're only half-way there.

But something else happened after this checkin:
When that two-pane appears with the vertical splitter "forgotten" - and in other
words approximately centered between the panes, the first account in three-view
is "semi selected". If i click on it, it becomes selected for "real" - indicated
with a dark selection color.

But untill i eventually click on it, there's a "this could have been selected"
color, brighter blue. And that one is now only covering part of the pane.
So the selction area seems to actually remember how wide the pane should have
been, but the splitter does not.

Attaching screenshot.

Comment 32

[R.K.Aa.]

Attachment: jpg, 30k, selection width knows something the splitter doesn't

Comment 33

[R.K.Aa.]

I hope i don't give anyone an ulcer here..

There is yet a problem with the 3-pane's "two-pane" splitter between treeview
and account-manager:

Grab it and drag it slowly to the left.
Notice how the cursor that one would expect to be positioned OVER the grab-area
actually moves far further to the left than the splitter itself. The "off by
something" error seems to be incremental, so during the move: the further to the
left i drag the splitter, the further away from the actual splitter the cursor is.

Comment 34

[Sean Su]

Attachment: patch to fix RKA's find

Comment 35

[Sean Su]

reopening

Comment 36

[R.K.Aa.]

Tadaaaa - the fix as such is purrrrfect.

Got a "malformed patch - error at line 10: </splitter> (or something like that.)
So perhaps look at that. 
Hand edited in the modifications, rebuilt, and sat here clicking and dragging
splitters for 5 minutes, closing app - restarting - and: Things now work like
they should. Now I'll stop whining ;)

Comment 37

[(not reading, please use [e-mail] instead)]

awaiting review from bhuvan before I sr...

Comment 38

[racham]

I think flex value for "mail3PaneVertLayoutBox" should be 2 so that
threadpane/accountcentral gets 2/3 of the space in the enclosed box.

Comment 39

[Sean Su]

Attachment: patch with bhuvan's suggestion of flex="2"

Comment 40

[racham]

Forgot to mention that flex for the boxes ("threadpaneBox", "accountCentralBox")
inside can now be changed to "1", just tobe consistent with format we follow all
over mozilla. 

Sean did make those changes.

r=bhuvan 

Comment 41

[(not reading, please use [e-mail] instead)]

sr=sspitzer

note, we need to remove our inline style from our xul (style="width:0px;")

that makes our xul non skinnable.

Comment 42

[Sean Su]

fix checked in with flex's changed to 1.

Comment 43

[[e-mail]]

:-( Patch 32766/32816 duplicated the id "mail3PaneVertLayoutBox" added by 31898

Comment 44

[Ninoschka Baca]

Build 2001-05-02-04: WinMe
Build 2001-05-02-08: Mac 9.04
Reopening, because the vertical splitter does not remember its position within a
session (i.e. Close mail with browser open) or between sessions (i.e. exit/restart).

I tried the following while checking for the splitter to maintain its position:
- Grippy appears (problem: grippy on top at startup. Known problem, Bug?) 
- Switch between folders
- Switch between folders and account central
- Collapse/Expand/resize vertical splitter
- Collapse/Expand/resize hortizontal splitter
- With Browser open, close and open Mail
- Exit/Restart

Comment 45

[scottputterman]

If this is an easy fix, go for it, otherwise moving to 0.9.2

Comment 46

[Håkan Waara]

*** Bug 80850 has been marked as a duplicate of this bug. ***

Comment 47

[Koike Kazuhiko]

*** Bug 83002 has been marked as a duplicate of this bug. ***

Comment 48

[scottputterman]

moving to 0.9.3

Comment 49

[[e-mail]]

Attachment: Possible patch (could do with some readable ids)

Comment 50

[Ninoschka Baca]

*** Bug 77752 has been marked as a duplicate of this bug. ***

Comment 51

[Jacek Piskozub]

Adding mostfreq at 10 dups.

Comment 52

[Blake Ross]

Missed 0.9.3.

Comment 53

[Sean Su]

The problems with remembering the position of the splitters seems to be fixed 
now.  I can't reproduce this problem anymore on both Win32 and Mac.

However, the grippy seems to show up not in the middle of the splitters (for 
both the verticle and horizontal grippies).  This was working fine at one point.  
It looks like a xul (or xptoolkit) problem.

I'm closing this bug as fixed because it refers to the splitters forgetting 
their positions, not about the postion of the grippy on the splitters.

Comment 54

[Ninoschka Baca]

Note: The problem with the grippies is covered in bug# 94180.

Comment 55

[Olga]

Fix is verified on Linux branch build 2001-09-19.
Alt 3 pane window remembers sizes.  I checked with dif. combinations.

Only when we "Collapse horizontal splitter -  it does not keep the position of
the splitter, but window position is saved.
I am going to check/open a separate bug.