555979 - Commit access (Level 3) for Mike Hommey <[e-mail]>

Status: RESOLVED FIXED

(mozilla.org :: Repository Account Requests, task)

Description

[Mike Hommey [:glandium]]

Attachment: ssh public key

I hereby request commit access to hg repositories (mozilla-central being my main interest). I've got many patches landed in the past years, and I think this would make it easier for me to push reviewed patches without waiting for somebody else to check them in (for instance, at the moment, I have 8 patches waiting for checkin). With my Debian developer hat on, my main interest is Linux integration, and fixes for non mainstream architectures.
Example of patches already landed:
bug 547656 - xptcall broken on mips o32 big endian
bug 546093 - Print dialog should not display the SVG output option when printing to a file
bug 544512 - Misaligned accesses in uconv causes Bus Error on sparc and word wrapping on arm
bug 543438 - TestBlockingProcess relies on stdin to "block"
bug 542999 - Setting general.useragent.locale in user profile should override any intl.locale.matchOS setting
bug 461663 - 16 bits colour channel values should not have lower bits zeroed 
bug 448658 - nsAutoTArray aligns buffer to 32 bits, causing SIGBUS when array entry type requires 64-bit alignment
bug 440840 - mailcap handling may fail due to race conditions between thread waiting and system() 
bug 373397 - nsGNOMERegistry could use the mozgnome component 
(...)

Comment 1

[Mike Hommey [:glandium]]

Sent Committer's Agreement.

Comment 2

[Erica McClure]

I have received Mike's Committer's Agreement.

Comment 3

[Justin Wood (:Callek)]

I'm willing to vouch, as a c-c build peer.

Comment 4

[Benjamin Smedberg]

sr=me

Comment 5

[Reed Loden [:reed]]

Can't count bsmedberg as SR (as he's reviewed glandium's patches), but he can be the second voucher. Still need an SR to vouch...

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

sr=biesi

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Unfortunately biesi is not a suitable SR, since he's also reviewed several of Mike's patches. See number 2) at http://www.mozilla.org/hacking/committer/#general-rule .

Comment 8

[Mike Hommey [:glandium]]

FWIW, here is a list of SRs that already reviewed one or more of my patches: brendan, bsmedberg, bzbarsky, cbiesinger, dbaron, dveditz, jonas, jst, kaie, mrbkap, mscott, neil, shaver and vladimir. That's almost half of them.

Comment 9

[Justin Wood (:Callek)]

Hmm, Standard8 (Mark) is not in your list of sr's. Perhaps he will sr+ you.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment 8 shows why the "sr who has not reviewed a patch" rule is ridiculous...

Comment 11

[:Gavin Sharp [email: [e-mail]]]

I agree that it's ridiculous, but I lost that fight when we last updated the policy. I think we should revisit that, but in the mean time, finding another SR is probably the most expedient option.

If mconnor really hasn't reviewed any of your patches (I thought he had), then I'd suggest asking him, since he's volunteered to vouch for account requests in the past.

Comment 12

[Mike Hommey [:glandium]]

Note my list could have false negatives, I only grepped my bugzilla mail box for the review messages. (though I think I have all messages I ever received)

Comment 13

[Mike Hommey [:glandium]]

Asking mconnor anyway, though he might be reviewing my Debian patches as part of bug 555935...

Comment 14

[Mike Hommey [:glandium]]

Still no one to sr me ? :(

Comment 15

[Benjamin Smedberg]

We're changing the policy (see mozilla.dev.governance) so that any of the existing srs can do it. That should take effect very shortly.

Comment 16

[Justin Wood (:Callek)]

and this policy is now changed, so any of the sr's here can be valid sr's! Which means this should now be able to be resolved.

Comment 17

[Reed Loden [:reed]]

Over to IT for LDAP account creation with hg_mozilla and hg_mozsrc bits.

Comment 18

[Justin Lazaro [:jlaz] (use needinfo)]

Unable to create account at the moment with your current e-mail address: "[e-mail]".  oremj will be updating LDAP for functionality when creating accounts with special characters.

Comment 19

[Mike Hommey [:glandium]]

(In reply to comment #18)
> Unable to create account at the moment with your current e-mail address:
> "[e-mail]".  oremj will be updating LDAP for functionality when
> creating accounts with special characters.

You can use the address in the bug subject, without the special character.

Comment 20

[Justin Lazaro [:jlaz] (use needinfo)]

Nice :)

Account created for [e-mail] with hg_mozilla and mg_mozsrc bits enabled

-jlazaro