562922 - Multiple entries of the same extension and theme appear if the installation/update is triggered more than once

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Tony Chung [:tchung]]

Attachment: multiple addons in queue screenshot

If installing a traditional addon via AMO or websites, the new addons manager doesn't seem to detect if the addon has already been installed and queued up.  We need a way to determine the addon is already there, and not keep writing entries into the queue.

* See screenshot

Repro:
1) install nightly Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre
2) visit a AMO site and search for a compatible plugin (eg. Quick notes @ https://addons.mozilla.org/en-US/firefox/addon/13572)
3) click the Add to Firefox button, then the Install button on the popdown.
4) Repeat this step a few more times when completed
5) switch to about:addons, and verify Quick notes is duped a few times in the queue before restarting.

Expected:
- if the addon is already in the install queue, there shouldnt be multiple rows being written to it.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's not only for installed addons but also for canceled installations. Duping to bug 558134.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry but bug 558134 is already marked as fixed.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Feels like something the API should be handling.

Comment 5

[Dave Townsend [:mossop]]

Some kind of link with bug 553966 here

Comment 9

[Paul [pwd]]

This is still happening.

Comment 11

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Simple approach, when an install starts check for pending installs of the same add-on in the same install location and cancel them.

Comment 12

[Robert Strong (they/them - no direct email)]

Comment on attachment 483680 [details] [diff] [review]
patch rev 1

>diff --git a/browser/base/content/test/browser_bug553455.js b/browser/base/content/test/browser_bug553455.js
>--- a/browser/base/content/test/browser_bug553455.js
>+++ b/browser/base/content/test/browser_bug553455.js
>@@ -543,19 +543,18 @@ function test_renotify_installed() {
>             info("Timeouts after this probably mean bug 589954 regressed");
> 
>             // Wait for the complete notification
>             wait_for_notification(function(aPanel) {
>               let notification = aPanel.childNodes[0];
>               is(notification.id, "addon-install-complete-notification", "Should have seen the second install complete");
> 
>               AddonManager.getAllInstalls(function(aInstalls) {
>-              is(aInstalls.length, 2, "Should be two pending installs");
>+              is(aInstalls.length, 1, "Should be two pending installs");
Should be one pending install?

r=rstrong with that

Comment 13

[Dave Townsend [:mossop]]

This actually landed: http://hg.mozilla.org/mozilla-central/rev/efd0cb45eb37

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101025 Firefox/4.0b8pre