592547 - Fill in the Edit sections of the add-on edit page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Mockups: 
http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Addon_02_Edit_Default.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Addon_02_Edit_Empty.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Addon_02_Edit_Expanded.png

This is a big one.  Each section's Edit button will swap the section out for it's editable twin (first vs. third mockup).  Saving or cancelling will swap them back.  This bug covers implementing all the editable sections.  Unless content is excluded below, it should be included in this bug.

This is mostly a front end bug, since the information is already on the page.  <form>s should PUT or POST to the appropriate API URLs to update the add-on.  Error messages will be returned from the API - they should be reviewed before swapping the section back to the read-only view.  

Exclusions:
- Videos need more pondering on our end.  For now, build this section to work only with images.

Comment 1

[Wil Clouser [:clouserw]]

-> gkoberger just because he has the read-only one anyway, so this is something to think about in the mean time.  The backend API isn't done yet, so if this gets done first, just have it submit to nowhere and we'll fill in URLs in a bit

Comment 2

[Chris Howse [:chowse]]

FYI, I've posted workflow mock-ups for several of the more complicated parts of the Edit Add-on page:

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction/
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction.pdf

I'll be posting an updated version of the Edit Add-on mocks w/ more annotations and links to the relevant workflows shortly.

Comment 3

[Chris Howse [:chowse]]

Annotated mocks are now available too:

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/00_common.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/01_edit_listing.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/02_edit_listing_empty.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/03_edit_listing_expanded.png

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon.pdf
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction.pdf

Comment 4

[Jeff Balogh (:jbalogh)]

Following the detraction meeting, we're dropping the user/dev tag dichotomy.  Changes

1. Skip the user tag section; all tags will be developer tags.
2. All tags come from <addon>.tags
3. When editing tags you can leave the user field blank.  We're going to drop/hide that.

Comment 5

[Jeff Balogh (:jbalogh)]

QA: Make sure add-ons have a name in all the locales they've filled out name, and make sure there's no leading whitespace to junk up search results.

Comment 6

[Gregory Koberger (:gkoberger)]

All the main pieces are done for this (see 'Depends On').

(Note: There are still smaller parts that need to be finished, but these are covered in other bugs.)