576063 - Hovering the topmost pixel row in fullscreen mode doesn't show the browser UI when tabs are on top

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

Regression from bug 575994? The blue, mouse sensing border area shrunk to about a pixel or two, making it unreliable to hit on mouse moves.

Comment 1

[Vykintas Vyšniauskas]

This is not a regression - bug 490621

Comment 2

[Dão Gottwald [:dao]]

Well, there might be a regression, but I'm not sure what it is. Are you saying that you move the mouse to the very top and the browser UI doesn't appear?

Comment 3

[Dão Gottwald [:dao]]

I see, the small border becomes a problem when the firefox button is visible. So the solution is to remove the button.

Comment 4

[[not reading bugmail]]

(In reply to comment #2)
> Well, there might be a regression, but I'm not sure what it is. Are you saying
> that you move the mouse to the very top and the browser UI doesn't appear?

This works now that bug 571813 is fixed, the titlebar with menu disappeared, but the autohide row seems to be not on the screen edge in fullscreen mode, but on the 2nd pixel row only, which makes it hard to hit and is jumpy.  

Reminds me of bug 575493 not to recognize the edge in maximized mode.

Comment 5

[[not reading bugmail]]

(In reply to comment #4)
> (In reply to comment #2)
> > Well, there might be a regression, but I'm not sure what it is. Are you saying
> > that you move the mouse to the very top and the browser UI doesn't appear?
> 
> This works now that bug 571813 is fixed, the titlebar with menu disappeared,
> but the autohide row seems to be not on the screen edge in fullscreen mode, but
> on the 2nd pixel row only, which makes it hard to hit and is jumpy.  
> 
> Reminds me of bug 575493 not to recognize the edge in maximized mode.

In short yes, the screen edge doesn't trigger un-hide, only the second row.

Comment 6

[Oskar Ivanić (:icecold)]

It's hard to show tab bar (no matter how much i mouse over top of the screen) in fullscreen mode with 20100707 build. Should we re-open?

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> It's hard to show tab bar (no matter how much i mouse over top of the screen)
> in fullscreen mode with 20100707 build. Should we re-open?

You should probably file a new bug with your exact configuration and steps to reproduce.

Comment 9

[Dão Gottwald [:dao]]

morphing

Comment 11

[Alice0775 White]

From Bug 577581, this problem caused by landing of Bug 430687

Comment 13

[Dão Gottwald [:dao]]

Attachment: patch

We set a bottom border on the toolbox when tabs are on top. Apparently clientHeight doesn't take this into account.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 456871 [details] [diff] [review]
patch

Aren't we supposed to prefer getBoundingClientRect() nowadays? I suppose it's wordier, but could put it in a local variable.

Comment 15

[Dão Gottwald [:dao]]

using getBoundingClientRect:

http://hg.mozilla.org/mozilla-central/rev/9c53adea30c6