Closed Bug 57188 Opened 24 years ago Closed 22 years ago

image warning dialog is not modal

Categories

(Core :: Graphics: Image Blocking, defect, P2)

Product:
Core
Component:
Graphics: Image Blocking
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 146513
Milestone:
Future

People

(Reporter: cesarb, Assigned: security-bugs)

References

(
URL
)

Details

(Keywords: crash) 

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.0-test9-pre1 i686; en-US; m18)
Gecko/20001017
BuildID:    2000101708

When mozilla is configured to ask before loading images, it pops up lots of
dialogs in some sites. Marking the "don't ask me again" box is thus sorta
useless until you manage to acknowledge all the repeated dialogs. I even managed
to crash mozilla right now only by loading securityfocus and answering 'yes' a
lot of times (looks like that feature is still a bit unstable; it crashes at
least once every few days when that kind of dialog is answered).

Reproducible: Sometimes
Steps to Reproduce:
1. Tell mozilla to ask before loading images
2. Go to a image- and frame-heavy site like securityfocus (most sites pop up
just two; securityfocus somehow managed to load more than five dialogs)
3. Mark "don't ask me this again"
4. Answer yes. Answer yes again. Answer yes yet again.

Actual Results:  Lots of dialogs. Dialogs popping up exactly at the time you try
to click 'yes'. Sometimes crashes after clicking 'yes'.

Expected Results:  Showed just one dialog, waited for the answer, and THEN tried
to show another. If I told it I don't want to be bothered anymore, don't ask
again for the same site.
over to cookies.
Assignee: asa → morse
Status: UNCONFIRMED → NEW
Component: Browser-General → Cookies
Ever confirmed: true
QA Contact: doronr → tever
Not really cookies, but there's no image-blocking component and it's the same 
owner anyway.  So I'll take it.
Status: NEW → ASSIGNED
Target Milestone: --- → Future
This is my top crasher (see many Talkback reports).  Most recently seen in build
2000102308 on Linux 2.2.16-22 i686.  As cesarb reports, most sites only pop up
two dialogs, but on those that do I find Mozilla will crash 75% of the time
after hitting either button on the second dialog.
The dialogs are now modal so it shouldn't be possible to have them stacked up 
anymore.  Therefore closing this out as works-for-me.  If you still get multiple 
dialogs all at once, please reopen this report.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → WORKSFORME
You Asked For It (tm)

Just got it. A "would you like to load this image" one, and a second later, a
"any information you submit will be insecure" one. The "would you like to load
this image" one got completely hidden behind the form submit one, but I couldn't
click on the form submit one. Since I saw the image one pop up, I knew I had to
alt+tab to the image dialog and acknowledge it before I could even unmark the
"bother me about this again" checkbox in the form submit dialog. A newbie
wouldn't know what to do.

I'll try to reopen; if I fail, please do it for me.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Can you give the URL and step-by-step instructions for reproducing this.  
Obvioulsy the URL for securityfocus that you had originally entered for this bug 
report does not demonstrate the problem you are now encountering (that url does 
not trigger the dialog about submitting insecure information).
Status: REOPENED → ASSIGNED
Summary: mozilla asks too much → [x]mozilla asks too much
Target Milestone: Future → ---
I've gotten multiple identical "would you like to load this image" dialogs in
build 2000110908 on Linux.  The particular URL is http://www.rebolpress.com/.
Heh, just got it again... Guess where? securityfocus ;-)

Build 2000110808.

Gotta *love* securityfocus... So nice to test mozilla there... *g*
Clarification: what I got again was the multiple dialogs (original report), no
crash. The insecure whatever one was on slashdot (hard to trigger, will happen
only when the ad is offsite).
OK, I'm seeing it as well.  Running on windows.
I see what the problem is.  I went to great pains to make the cookie-warning 
dialog modal but not the image-warning dialog.  The offending line is in the 
Image_CheckForPermission routine in nsCookie.cpp.  The actual line is:

     permission = permission_Check(0, hostname, IMAGEPERMISSION,
                                image_GetWarningPref(), new_string);

That first argument has to be the parent window and not 0.  So now it's a matter 
of determining the parent window.
Great!

After you finish it (and it works), could you morph this into a generic
dialogs-which-should-be-modal bug? We still have the "security" warnings
(sending forms is evil! And I need 6 wordy lines to explain it!), which seem to
pop up in odd times (fortunately, everybody disables them on first sight).
Summary: [x]mozilla asks too much → mozilla asks too much
Whiteboard: [x]
Summary: mozilla asks too much → image warning dialog is not modal
*** Bug 60704 has been marked as a duplicate of this bug. ***
Bug 60704 had "crash" keyword, adding it here too
Keywords: crash
*** Bug 52771 has been marked as a duplicate of this bug. ***
Netscape Nav triage team: this is not a Netscape beta stopper.
Keywords: nsbeta1-
This is still my top crasher (Linux build 2000122610). Mozilla crashes really
often while adding a host in the image permission list. The summary line for
this bug may be confusing but since Bug 60704 was marked as a duplicate of this
one I guess the crashes mentioned there are now included in this one as well.
*** Bug 64164 has been marked as a duplicate of this bug. ***
Whiteboard: [x]
*** Bug 65441 has been marked as a duplicate of this bug. ***
*** Bug 69874 has been marked as a duplicate of this bug. ***
Target Milestone: --- → mozilla1.2
*** Bug 73545 has been marked as a duplicate of this bug. ***
I just went to another site, and got another two prompts to accept images.  The
first one came up when only the background color for the page had been
displayed, no content.  I clicked "Don't prompt me again for this site" and "Yes".

The second prompt then came up, after a brief delay.  I didn't click on the
second prompt, just watched.  All of the images on the page loaded, and when
nothing else appeared to be changing, I clicked "Yes" (the "Don't prompt again"
was already checked, of course).

When I clicked on the second prompt, the page background image loaded.

The page I went to was http://208.55.6.108/comedians/brian-regan.htm and both of
the prompts for images definitely referred to tha IP address.  This is backwards
from the order I reported happening in bug 73545, but I think that this is the
order in which things usually happen.

When the image prompts for body / rest of page are clicked on in the reverse
order seems to be when the crash described by this bug occurs.  The crash does
still occasionally happen for me, but I don't believe there should be two
prompts for the same host anyway - not if I say "don't prompt again".

I'm still using Linux build 2001032614 because newer builds are still trashing
my cookperm.txt file, and I really don't want to lose the 1000-odd sites listed
in there :-)

The behaviour of this bug has morphed slightly; now not only do I get two (or
more) dialogs, but each one seems to add another copy of the entire HTML
document.  For example, given a page like

FOO [image] BAR

that presents multiple dialogs, it will appear when finally loaded as

FOO [image] BAR
FOO [image] BAR
FOO [image] BAR
...

for as many dialogs as appeared.  Reloading the page displays the correct single
copy.

I don't crash nearly as often any more, but it still happens regularly in normal
browsing with nightlies (including 2001071608).
peterj: I reported the duplication of parts of the pages in bug 87462.
> So now it's a matter of determining the parent window.

Forgive the nag, but this is still my top crasher, and has been for a year.  It
sounds like the same problem was fixed for cookies last November, and that that
fix could be applied here.

Mozilla 1.2 (the target milestone) isn't even listed on the roadmap, which
covers the next six months. :(  Would someone like to nominate it for 1.0?
How about volunteering to fix it?
I've also seen crashes on the "load images" dialog when unblocking images from
sites that were previously blocked.  A single "Yes/No" dialog appears at the
same time as the "Images will always be loaded" dialog.  It's easy to reproduce
simply by blocking images, reloading the page, and unblocking images a few times.

I'm not sure if this is exactly the same problem, but I suspect so--the
interfering dialog just isn't the same one.  Stephen Morse has described the
root cause in |http://bugzilla.mozilla.org/show_bug.cgi?id=57188#c11|.
I just got a crash with QFA after answering three consecutive dialogs for
m.doubleclick.net on 2002021513. The id is TB3059175M, can someone check if it's
related to this or is something else? (How do I read the reports after they're
sent?)
This seems to be related to mozilla crashing a lot recently for me. TB3626855Q,
TB3624941Q, TB3614102W are the ones I got with 2002030108; I don't know how to
get the ones from other builds out of my ~/.talkback .
Since this is a generic bug for modal dialogs...I would suggest that any crash
information or steps to reproduce it be added to bug 133633.  I have logged that
bug to cover recent crashes like the ones Cesar has experienced.
I tried fixing the issue raised by comment 11, but it didnt help. I suspect
that, given the age, its no longer a problem passing 0 to permission_check().

The crash only seems to occur with background images for me (I'm getting similar
stack traces to those posted in 133633). For example, going to www.bbc.co.uk
causes a crash, but if you turn background images off (pref -> appearance ->
colours -> use mine) it is fine. Or if you edit the page to remove background
image style elements it is also fine.



Further to comment 31, i've posted a testcase and stack trace to bug 133633. In
summary, the testcase consists of an html page with one inline image and a
background image. What appears to be happening is:

- a dialog is created to ask whether to load the (inline) image
- it hits the gtk event loop
- the main browser window gets repainted
- an attempt to draw the background of the page is made which causes a load of
  the background image
- dialog is created to ask whether to load (background) image
- gtk event loop
- both dialogs appear but only the second is drawn and active
- after responding to this, the crash occurs when painting the first

This also happens on a windows build (admittedly 2002021608), where you can see
the two dialogs, but it doesnt seem to get upset.
Blocks: 133633
*** Bug 126092 has been marked as a duplicate of this bug. ***
For me this gives me a 50/50 chance of crashing whenever I visit a new site.

I love this feature, but I'm going to have to turn it off. It's just too broken.
changing component.
Component: Cookies → Image Blocking
when I tried to find out what caused the many annoying crashes I was having, I
found out it was always the background image of a page. If a page has more
images than the background one, I am asked twice (at least) if I want to load
images from that site, if there's only the background image, I am asked only
once (but still mozilla crashes). See also talback report TB5687409H
Now that "ask image" has been disabled (see bug 110112), is this bug fixed?

Personally, I'd rather have an occasional browser crash than do without this
feature.
No it's not.

If what was checked in was the attachment in bug 110112, this bug wasn't really
fixed. The code isn't being called anymore, but it is still there, and still has
the bug, ready for reappearing when it is uncommented.

I'm marking a dependency on bug 110112, since this bug is untestable until the
code is reenabled.
Depends on: 110112
Priority: P3 → P2
Target Milestone: mozilla1.2alpha → mozilla1.1beta
Target Milestone: mozilla1.1beta → mozilla1.2beta
Mass reassigning of Image manager bugs to mstoltz@netscape.com, and futuring.
Most of these bugs are enhancement requests or are otherwise low priority at
this time.
Assignee: morse → mstoltz
Status: ASSIGNED → NEW
Target Milestone: mozilla1.2beta → Future

*** This bug has been marked as a duplicate of 146513 ***
Status: NEW → RESOLVED
Closed: 24 years ago → 22 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → DUPLICATE
QA Contact: tever → nobody
You need to log in before you can comment on or make changes to this bug.