580297 - New Mail Account created through 'Manual Setup' doesn't land on the 'Account Settings' for the *new* account when more than one account exists

Status: RESOLVED DUPLICATE of bug 679873

(Thunderbird :: Account Manager, defect)

Description

[Charles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6
Build Identifier: 3.1 final

Currently, when the New Mail Account Wizard runs and auto-detect has problems
or the user gets frustrated because auto-detect wants to set things up
differently from what the user wants and the user clicks 'Manual Setup', the
new account dialog simply disappears and you are dropped into the 'Account
Settings' window.

If this is a new installation, and this is the first account being created, it
lands you on the settings page for the new account you just created...

*However*...

If you already have one or more [IMAP] accounts, and you are creating a new mail
account from the 'Account Settings' > Add Mail Account' wizard, this is not the
case - at least, not for me. It seems to randomly pick an account to land you
on, but after 5 attempts, not once did it land me on the new one I just
created.

I have confirmed this on multiple computers multiple times after being told by Ben that it worked for him.

It is very easy to reproduce (at least for me)...

Reproducible: Always

Steps to Reproduce:

1. Start TB with a new/clean profile (ie, move your Thunderbird folder out of the 'Applications Data' folder and let TB create everything from scratch),

2. When the automatic new account wizard starts up, add the following dummy info: name (Test 1), email ([e-mail]) and password (whatever), then click 'Continue',

3. Click the 'Stop' button (repeat if necessary to fully stop the auto-detect process),

4. Click the 'Manual Setup' button,

5. Note that the 'Account Settings' dialog opens, and the details for the new IMAP account you just created are displayed in the 'Server Settings' on the right,

6. Click 'OK' to close the 'Account Settings' dialog,

7. Re-open the 'Account Settings' dialog,

8. Click 'Account Actions' > 'Add Mail Account',

9. Add more dummy info: name (Test 2), email ([e-mail]) and password (whatever), then click 'Continue',

10. Click the 'Stop' button (repeat if necessary to fully stop the auto-detect process),

11. Click the 'Manual Setup' button,

12. Note that:

 12a. the 'Account Settings' dialog opens,

 12b. the new IMAP account was created (is displayed in the list of accounts
      on the left),

BUT...

Actual Results:  

 12c. details for the *first* account (email = test*1*@test.com) you created
      are displayed in the 'Server Settings' on the right, instead of the one
      you just created (email = test*2*@test.com).


Expected Results:  

 12c. details for the *new* account (email = test*2*@test.com) you created
      should be displayed in the 'Server Settings' on the right.


This bug may or may not be made moot by the implementation of bug 549045, I won't know until I can see the new functionality in action...

Comment 1

[Ben Bucksch (:BenB)]

> This bug may or may not be made moot by the implementation of bug 549045

It won't, this bug will still exist.

As said in the other bug, this WORKSFORME. The newly created account does get selected for me.

Comment 2

[Ben Bucksch (:BenB)]

3.1.x, Linux. Tried with fresh profile, same. Create new account, click Stop several times, click Manual Setup.... Repeat 2 times. Everytime, the "Server settings" of the new account gets selected.

Comment 3

[Ben Bucksch (:BenB)]

Tried with same domain, and same servername and type. Still works.

Ah!

> 8. Click 'Account Actions' > 'Add Mail Account',

That's the reason. I always use File | New | Mail Account...

The UI path your use is indeed broken. It's just going back to the existing Account Manager window. For me, it then simply has nothing selected (not the first account, and not the previously selected account).

I don't consider this to be a serious bug, given that you were in the Account Manager before, so you better know how to use it. Having to manually select the new account is not a major problem.

Nevertheless, IIRC I fixed this in bug 549045.

Comment 4

[Charles]

(In reply to comment #3)
> Tried with same domain, and same servername and type. Still works.
> 
> Ah!
> 
>> 8. Click 'Account Actions' > 'Add Mail Account',
> 
> That's the reason. I always use File | New | Mail Account...
> 
> The UI path your use is indeed broken. It's just going back to the existing
> Account Manager window. For me, it then simply has nothing selected (not the
> first account, and not the previously selected account).

Ok, well, good, at least now you know I'm not crazy (or imcompetent)... ;)

Fwiw (and no offense intended) - I did specify these same steps in bug 580216, which you more than once claimed 'WORKSFORME', when now we know you obviously weren't following the same steps - not good, makes me have less confidence in you the next time you say you can't reproduce something.

> I don't consider this to be a serious bug, given that you were in the Account
> Manager before, so you better know how to use it.

It is a pain in the ass, when you have a bunch of accounts (I'm at 20 now, was at 16 before, may be at 30 tomorrow), especially when the danged thing always opens with all accounts expanded every time.

And it brings to mind another bug I've been meaning to open - when you click on an account, then click over in the details section, the account you're on on the left is no longer highlighted - it can get confusing sometimes, depending on where you are ion the details...

> Having to manually select the new account is not a major problem.

It is a usability issue - just because something is only broken 'a little bit' doesn't mean it shouldn't be fixed, especially if it is relatively simple.

> Nevertheless, IIRC I fixed this in bug 549045.

Good to know... but you recently said that that bug may never get implemented? Can the fix for this issue be included as a separate patch so it gets fixed even if bug 549045 doesn't get implemented?

> *** This bug has been marked as a duplicate of bug 549045 ***

Thanks...

Comment 5

[Charles]

(In reply to comment #4)
> And it brings to mind another bug I've been meaning to open - when you
> click on an account, then click over in the details section, the account
> you're on on the left is no longer highlighted - it can get confusing
> sometimes, depending on where you are ion the details...

And of course now I can't duplicate this... <sigh>

Comment 6

[Ben Bucksch (:BenB)]

> makes me have less confidence in you the next time you say you can't
> reproduce something.

Please! You had 3-4 bugs rolled into one there, and you did not mark this step as important.
I tried very hard to reproduce it, as you can see in my comments. I spent over an hour on your bug report, time that I would usually work and get paid for.

Comment 7

[Charles]

(In reply to comment #6)
>> makes me have less confidence in you the next time you say you can't
>> reproduce something.

> Please!

As I said, no offense was intended...

> You had 3-4 bugs rolled into one there,

No, there was only *one* actual *bug*, and this was pretty clear from my opening comment - the rest was a suggested fix disguised as an enhancement for the New Account Wizard, and I've already acknowledged that I probably shouldn't have done it that way.

> and you did not mark this step as important.

Oh... my apologies... I thought that 'Steps to reproduce' meant that I shoudl provide the exact steps that you need to take to be able to reproduce the problem.

And yes, the sarcasm was intentional.

Please tell me just how am I supposed to know that *that* step was the important one that *you* were missing??????

> I tried very hard to reproduce it, as you can see in my comments. I spent over
> an hour on your bug report, time that I would usually work and get paid for.

And it is appreciated - BUT...

Had you simply followed my steps *as provided*, you would not have spent 'over an hour' on it, probably more like 5 minutes (that's all it took for me to reproduce it each time) - so the fact that you wasted over an hour on it was your *own* fault, not mine.

Comment 8

[Ben Bucksch (:BenB)]

> Nevertheless, IIRC I fixed this in bug 549045.

Actually, I think I was wrong, I was thinking of bug 525238 where I changed the same code. I just checked whether this is a regression from that bug, but TB 3.0 exhibits this bug as well.
REOPEN (no dup)

Comment 9

[Ben Bucksch (:BenB)]

CONFIRM

Comment 10

[Michael A. Pasek]

(In reply to comment #9)
> CONFIRM

Ditto, while testing proposed XML file for Bug 567588 and GS customer's domain.

Comment 11

[Ben Bucksch (:BenB)]

He means bug 567688

Comment 12

[Michael A. Pasek]

(In reply to comment #11)
> He means bug 567688

That I did.

Comment 13

[Alex]

You did nothing in a whole year and I just lost my news account due to this. And corrupting RANDOM accounts is not of just a "normal" severity.

Comment 14

[Ben Bucksch (:BenB)]

Alex, this bug is not about corrupting accounts at all. See the summary.

This bug is very confusingly written. I therefore filed a new, clean one.