Closed Bug 59871 Opened 24 years ago Closed 23 years ago

"Trash" still shows messages in bold even after emptying trash on IMAP server

Categories

(MailNews Core :: Networking: IMAP, defect, P3)

Product:
MailNews Core
Component:
Networking: IMAP
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.3

People

(Reporter: jnichols, Assigned: naving)

References

Details

(Keywords: polish, Whiteboard: [nsbeta1+][nsbranch+,pdt+]Have Fix)

Attachments

(2 files)

proposed fix
922 bytes, patch
Details | Diff | Splinter Review
fix for the pop3 part
927 bytes, patch
Details | Diff | Splinter Review 
As far as I can tell, this is only happening on an AppleshareIP 6.3.2 mail
server. (logged in with IMAP)
1)Get a new message or 2..
2)delete an unread message
3)choose "Empty Trash"

Trash will remain in bold with the message count displayed. If I go into the
trash, it goes back to the normal non-bold grey text.

Happens every time I check my mail on my Appleshare IP box. Including version
20001110...

I tried playing with some of the IMAP settings, but they don't seem to make a
difference..
This problem has been around a long time, I bet there's a duplicate out there
... will look for it.
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: esther → laurel
what if you expand and collapse the top-level imap server, without opening the
trash? Does the folder count get updated correctly? I.e., is this just an
update/redraw problem?
Tried collapsing it.. it's most noticible when there's a deleted new message.
collapsing it didn't work, but if I click "Trash" it'll go in the folder,
realize it's supposed to be empty, and update accordingly..
*** Bug 62584 has been marked as a duplicate of this bug. ***
Found this bug in Win 98 also on 2000120920.
*** Bug 64856 has been marked as a duplicate of this bug. ***
OS: Mac System 9.x → All
Hardware: Macintosh → All
*** Bug 72996 has been marked as a duplicate of this bug. ***
*** Bug 73663 has been marked as a duplicate of this bug. ***
I see this with today's win32 (2001041009) build against nsmail-1 in imap.  I
delete a message that's unread, the trash folder goes bold, I empty trash and it
doesn't go unbold until I click on the folder.  If I collapse the sidebar/folder
pane and reopen it, it stays bold.
The same happens with POP too (win98, 2001-05-13-10-trunk, also in duped bug
64856). Even restarting mail doesn't update the count. The summary is confused:
"shows messages in bold"? The description nor the comments describe messages
shown in bold, but the folder name and message count.
moving to mozilla0.9.2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.2
balancing to naving.
Assignee: mscott → naving
I think we're not clearing the pending counts when we empty the trash.
Attached patch proposed fix — — Splinter Review 

    
    

    
  
The counts were not changing only for imap. For pop3 it worksforme. The fix is 
to update the counts in OnStopRunningUrl. Need review, david.  

    
    

    
  
r=bienvenu

    
  
Whiteboard: [nsbeta1+] → [nsbeta1+]Have Fix

    
    

    
  
I have this problem with POP3 (2001053115 on RedHat Linux 7.1), so it is not
just an IMAP problem.

    
    

    
  
When you do File | Empty Trash or right click Empty Trash on pop3 we delete the 
trash folder and create a new trash folder, so it should not show anything in 
bold. 

    
    

    
  
May be it shouldn't, but it does. It goes away when I click on it, though. Is it
possible that it's just a question of the folder pane not being refreshed properly?

    
    

    
  


  

    
    

    
  
The fix is basically call UpdateFolder on the newly created Trash folder 
so that counts are updated. request for review, david ?

    
    

    
  
r=bienvenu

    
    

    
  
moving to 0.9.3.  Please hold onto the fix in case we can get in later.
Target Milestone: mozilla0.9.2 → mozilla0.9.3

    
  
Keywords: nsBranch

    
    

    
  
sr=mscott for both patches.

    
    

    
  
*** Bug 80665 has been marked as a duplicate of this bug. ***

    
    

    
  
fix landed on trunk.

    
    

    
  
*** Bug 88273 has been marked as a duplicate of this bug. ***

    
    

    
  
adding vtrunk keyword to indicate the bug has been fixed on the trunk.  Bug left
open for tracking checkin to branch (nsbranch) when appropriate.

Once bug has been fixed on the branch also, pls remove vtrunk keyword.
Keywords: vtrunk

    
    

    
  
If this patch gets in, please remember to take out the CompactAll (which I think
is part of another bug that we decided not to take).  If I'm wrong about that,
ignore me.

    
    

    
  
yep, i will take care of that. 

    
    

    
  
trunkverified
using trunk builds 2001-07-02, this is fixed.  I checked IMAP, POP and WebMail
IMAP accounts for this.  They all worked fine.  

    
    

    
  
I take back the trunkverified,  I found a problem with this fix.
Select messages in a pop inbox
Delete them
File|Empty trash
Select a message in the inbox and wait a second. 
Result: the thread pane is blank
Does not happen with branch build, still checking this scenario. Same true on
linux and mac


    
    

    
  
The problem I found is with POP only.

    
    

    
  
For Mac, running through this scenario, I get one of those "Unknown Errors" 
Error 80004005.  From then on, selecting msgs in the tread pane for the Inbox
gives me the error.  Changing folders doesn't help.  I have to exit app and 
relaunch.

    
    

    
  
On the trunk CompactAll after Empty Trash bug 61960 is checked in. 
i will back that one out. I know that is what is causing problems that 
esther mentions. 
Scott, do you want this to be verified again on trunk after I back out 61960
or do you want me to go ahead and check this fix on branch. I am pretty
sure it should work


    
    

    
  
Let's get this verified on the trunk again.  If you can get it checked in today
then we can test it on Thursday.  If it passes we can get it checked in for
Friday's build.

    
    

    
  
Please verify this again on thursday on trunk. I have just removed the 
CompactAll part of emptyTrash for local folders.

    
    

    
  
Using trunk builds 2001-07-04 the problem I mentioned on 7-3 with unknown errors
for mac and missing thread pane content is gone.  making this  trunkverified again

    
  
Whiteboard: [nsbeta1+]Have Fix → [nsbeta1+][nsbranch+]Have Fix

    
    

    
  
When the branch is open, please check this into it today.
Whiteboard: [nsbeta1+][nsbranch+]Have Fix → [nsbeta1+][nsbranch+,pdt+]Have Fix

    
    

    
  
fix checked in on branch
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Verified OK on jul09 0.9.2 branch builds with win98, linux rh6.2 and mac OS 9.0
OK with IMAP, POP.
since esther already did the verification on the trunk, I'll mark this verified.
Status: RESOLVED → VERIFIED

    
    

    
  
*** Bug 90302 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 90350 has been marked as a duplicate of this bug. ***

    
    

    
  
This bug regressed for POP; in Build ID 2001102215 the total message count for
Trash is never updated - see bug 64856 (I reopened it).
Product: MailNews → Core
Product: Core → MailNews Core

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: