602872 - Some Places xpcshell tests are failing due to idle-daily notified for each test

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

After the fix for bug 602085 idle-daily is notified again after 7 months, unfortunately tinderboxes are permanently idle, and we run idle-daily tasks at each test.

These failures started being more permanent:

TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\toolkit\components\places\tests\queries\test_redirectsMode.js | test failed (with xpcshell return code: 0), see following log:
Bug 523578 - test_places/queries/test_redirectsMode.js fails, and then reports a failure in head_queries.js TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/components/places/tests/queries/head_queries.js | Expected http://1.example.com/ found http://2.example.com/ - See following stack:
Bug 511860 - test_results-as-visits.js randomly (but constantly) fails, and then reports a failure in head_queries.js
Bug 523578 - test_places/queries/test_redirectsMode.js fails, and then reports a failure in head_queries.js TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\toolkit\components\places\tests\queries\test_tags.js | test failed (with xpcshell return code: 0), see following log:
Bug 555014 - Intermittent failure in test_tags.js | (NS_ERROR_FAILURE) [nsINavBookmarksService.removeFolderChildren]
Bug 557525 - Intermittent failure in test_tags.js | [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark]"
Bug 559279 - Intermittent failure in test_places/queries/test_tags.js | 3 == 2
Bug 582557 - Intermittent failure in test_tags.js | test failed (with xpcshell return code: -2147483645)
Bug 591850 - Intermittent failure in places/tests/queries/test_tags.js | 0 == 1 TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/components/places/tests/queries/test_tags.js | 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\toolkit\components\places\tests\unit\test_history_sidebar.js | test failed (with xpcshell return code: 0), see following log:
Bug 576220 - test_history_sidebar.js | 8 == 9 - unit test failure
Bug 552386 - test_history_sidebar.js fails between midnight and 2:00 am with new DST settings TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/components/places/tests/unit/test_history_sidebar.js | September == Yesterday - See following stack:
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\toolkit\components\places\tests\unit\test_removeVisitsByTimeframe.js | test failed (with xpcshell return code: 0), see following log:
Bug 509970 - xpcshell-tests: random failure in test_removeVisitsByTimeframe.js | 2 == 10, 6 == 10, etc.
Bug 590034 - xpcshell tests test_removeVisitsByTimeframe.js and test_faviconService_expireAllFavicons.js fail with "test failed (with xpcshell return code: -2147483645)" after "ASSERTION: hasResult is false but the call succeeded?: 'hasResult'" TEST-UNEXPECTED-FAIL | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | 14 == 10 - See following stack:

Comment 1

[Marco Bonardo [:mak]]

Attachment: workaround v1.0

Comment 2

[Marco Bonardo [:mak]]

Attachment: workaround v1.1

added bug number.

Comment 3

[Marco Bonardo [:mak]]

after workarounding failures we should still investigate the interaction, so please don't close the bug.

Comment 4

[(no longer active)]

Comment on attachment 481837 [details] [diff] [review]
workaround v1.1

I landed this patch: http://hg.mozilla.org/mozilla-central/rev/408fa6da7e0c

Comment 5

[Marco Bonardo [:mak]]

And looks like it worked, thanks.

Comment 6

[Marco Bonardo [:mak]]

removed the workaround, no more needed after the fix for bug 602871
http://hg.mozilla.org/mozilla-central/rev/8d53ea71793e

Comment 7

[Marco Bonardo [:mak]]

so, I think I've figured out most of what I cared about while working on the branch, idle can do a lot of stuff to the db, and it's async stuff that really hurts tests-reliability.
I don't need further work here.