616933 - [Quick Filter bar] Toggle quick bar hide text (layout change from text + icons to only icons)

Status: RESOLVED WORKSFORME

(Thunderbird :: Search, defect)

Description

[[:Aureliano Buendía]]

Attachment: screenshot

STR:
1. toggle to show quick filter bar;
2. select a filter by tags;
3. select one messages into resulset;
4. toggle to hide quick filter bar;
5. here I see a "corrupt" layout (no icons) as show in attached screenshots.

Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101205 Thunderbird/3.3a2pre

Comment 1

[[:Aureliano Buendía]]

Attachment: screenshot (default mode, not "corrupt")

Comment 2

[Richard Marti (:Paenglab)]

Aureliano do you really mean "no icons" or "no text"? If you mean no icons, then it's a dupe of Bug 616932. When no text, had the window the same width?

Comment 3

[rsx11m]

I think it's the same as your other bug. Once the available width for the quick-filter bar is getting too small, the text labels disappear on purpose. Since no icon is available for the "Tag" selector button, it looks empty.

Comment 4

[[:Aureliano Buendía]]

(In reply to comment #2)
> Aureliano do you really mean "no icons" or "no text"? If you mean no icons,
> then it's a dupe of Bug 616932. When no text, had the window the same width?

Sorry Richard I mean "no text".
And yes the window has the same width.

Comment 5

[rsx11m]

That seems to be a borderline case where the threshold to switch between "icons+text" and "icons only" is crossed depending on the qfb state.

Moving to "Search" component as this is not a theme issue.

Comment 6

[[:Aureliano Buendía]]

(In reply to comment #3)
> I think it's the same as your other bug. Once the available width for the
> quick-filter bar is getting too small, the text labels disappear on purpose.
> Since no icon is available for the "Tag" selector button, it looks empty.

I rsx11m.
I disagree, but it's possible that I'm wrong.
I disagree because this reason: if I start TB on my laptop and then I select my Inbox and toggling to show quick filter bar I see with "text + icons" mode.
When I execute STRs in comment #0, I see quick filter bar in "icons only" mode.
For me this sound as incongruent behavior.

Ciao.

Comment 7

[rsx11m]

I may not understand your STR correctly, but I get either icons only or icons+text when modifying the window width, and when toggling the QFB with
the handle on the tab (your step #4), it disappears as intended...

Comment 8

[Richard Marti (:Paenglab)]

Aureliano can you try to move the folderpane splitter a little bit to the right or left with open QFB. How much have you to move until the text collapses, or after a search, appears?

Comment 9

[[:Aureliano Buendía]]

(In reply to comment #8)
> Aureliano can you try to move the folderpane splitter a little bit to the right
> or left with open QFB. How much have you to move until the text collapses, or
> after a search, appears?

yes, this fixes the issue... but I dont understand why. During execution of STRs in comment #0 window width don't change.
Then I think this issue can close as dupe of any other.

Comment 10

[[:Aureliano Buendía]]

(In reply to comment #8)
> Aureliano can you try to move the folderpane splitter a little bit to the right
> or left with open QFB. How much have you to move until the text collapses, or
> after a search, appears?

Another workaround is to enable\disable messages pane (hitting F8)

Comment 11

[:aceman]

This is still not solved even in TB14, Win XP. Just toggling the quick filter bar on/off/on makes the text disappear. TB window is  maximized all the time.

Comment 14

[:aceman]

I can't seem to reproduce this on current trunk (TB32), but I can with TB24. Does anybody still see it on current trunk?

Comment 15

[[:Aureliano Buendía]]

I can still reproduce in  Mozilla/5.0 (Windows NT 6.1; rv:29.0) Gecko/20100101 Thunderbird/29.0

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Steps to reproduce on trunk and release:
1. Have Inbox selected.
2. Select account name in folder pane
3. Switch back to Inbox.
It's possible that one needs several tries to reproduce the issue.

Details:
When selecting the account, onOverflow will run
http://mxr.mozilla.org/comm-central/source/mail/base/content/quickFilterBar.js#333
and collapse the buttons:
http://mxr.mozilla.org/comm-central/source/mail/base/content/quickFilterBar.js#359

The expansion of the labels should be done by onWindowResize
http://mxr.mozilla.org/comm-central/source/mail/base/content/quickFilterBar.js#371
but that only runs for window resizes:
http://mxr.mozilla.org/comm-central/source/mail/base/content/quickFilterBar.js#34

Comment 18

[Roasted]

I had this issue for a while and then installed the extension "expression-search" which is also handling the quick filter bar. The developer of this extension fixed the disappearing-text-issue years ago, maybe his code could help. The reason of this bug is, in his words, "the shrink value depends on the total length of the search bar and the length contains the (hidden) 'quick search filter' text box".

Maybe someone who understands what this means could compare the extension's and Mozilla's code and fix this for those who don't use this extension.

Comment 19

[u276367]

This bug reappears in Thunderbird 52.0 Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 (and I believe also in its most previous version).

Steps to reproduce:
1.) Use the classic view of TB's window-layout.
2.) Deactivate message (preview) pane by pressing F8 on your keyboard.
3.) Activate and deactivate (toggle) Quick Filter Toolbar, which you can do in any given manner.
4.) The text will disappear, due the fact, that the "search this message CTRL + SHIFT + K" searchbar  gets a little bit bigger, instead of staying the same size.

Workaround:
Keep the message pane always activated.

Also restarting TB or opening a new tab will clean up the layout and show the text Quick Filter Toolbar again.

Comment 20

[u276367]

> 4.) The text will disappear, due the fact, that the "search this message
> CTRL + SHIFT + K" searchbar  gets a little bit bigger, instead of staying
> the same size.

Sorry, I made a small translation failure; it really should say "search these messages CTRL + SHIFT + K" instead of "search this message CTRL + SHIFT + K"

BTW: Where's the edit button for bugzilla comments? ;-)

Comment 21

[Wayne Mery (:wsmwk)]

Does this still reproduce?
WFM with nightly build. And quick filter bar is heavily changed in recent versions.

Comment 22

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #21)

Does this still reproduce?
WFM with nightly build. And quick filter bar is heavily changed in recent versions.

=> WFM