Closed
Bug 629900
Opened 15 years ago
Closed 15 years ago
Print Preview doesn't work in viewsource and mailnews plus misc fixes from toolkit.
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philip.chee, Assigned: philip.chee)
Details
Attachments
(1 file)
|
17.07 KB,
patch
|
jag+mozilla
:
review+
|
Details | Diff | Splinter Review |
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebBrowserPrint.printPreviewNumPages]"
nsresult: "0x80004005 (NS_ERROR_FAILURE)"
location: "JS frame :: chrome://communicator/content/printPreviewBindings.xml :: updateToolbar ::
line 427"
data: no]
<NeilAway> smaug broke us, I think
<NeilAway> RattyAway: yeah, beats me why, but there's a change that he didn't do in one of our files
<NeilAway> RattyAway: http://hg.mozilla.org/mozilla-central/diff/180966423a3c/toolkit/components/printing/content/printPreviewBindings.xml
RattyAway: try applying that to suite/common/printPreviewBindings.xml
|
Assignee | |
Comment 1•15 years ago
|
||
Basically sync all the changes in the toolkit version over.
References:
Bug 281932 - Print preview UI not keyboard accessible.
Bug 233461 - [GNOME] use of stock images.
Bug 326716 - Remove xprint from the tree r+sr=dbaron (Comment only change)
(Bye bye Xprint. b=326716 r+sr=dbaron)
Bug 398388 - XUL numberboxes for the Print Preview. r=gavin
Bug 483419 - Rename the left-arrow and right-arrow class names in the print preview toolbar to previous-arrow and next-arrow.
Bug 487667 - Clone documents for printing, r=roc+jst+joe+dbaron
Bug 505060 - [Print preview] Changing scale xx% -> shrink to fit -> xx% does not work. r=gavin.sharp
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/printing/content/printPreviewBindings.xml&rev=1.3#62
1.3 <chanial@noos.fr> 2003-10-26 20:30
- remove useless class toolbarbutton-icon
> - - Rod Spears <rods@netscape.com>
> + - Rod Spears <rods@netscape.com>
Whitespace cleanup. There is no Hg Blame to mess up.
> - oncommand="PrintUtils.print();"/>
> + oncommand="PrintUtils.print();" icon="print"/>
Gnome stuff.
> - <xul:toolbarbutton class="toolbarbutton-icon home-arrow"
> + <xul:toolbarbutton class="home-arrow tabbable"
1.3 <chanial@noos.fr> 2003-10-26 20:30
- remove useless class toolbarbutton-icon.
> oncommand="parentNode.navigate(0, 0, 'home');" tooltiptext="&homearrow.tooltip;"/>
> - <xul:toolbarbutton class="toolbarbutton-icon left-arrow"
> + <xul:toolbarbutton class="previous-arrow tabbable"
Left and right arrow buttons missing images.
> - type="radio" group="orient" class="toolbar-portrait-page"
> + type="radio" group="orient" class="toolbar-portrait-page tabbable"
Keyboard accessibility.
> - <field name="mDebug">
> - false
> - </field>
[....]
> - this._debug("constructor");
[....]
> - <method name="_debug">
> - <parameter name="aMsg"/>
> - <body>
> - <![CDATA[
> - if (this.mDebug)
> - dump("\t *** printPreviewBindings: " + aMsg + "\n");
Nothing ever sets mDebug to true in toolkit. I don't know if this was actually used in old XPFE either.
> aValue /= 100;
toolkit uses aValue /= 100.0; I'm not sure if this is needed. Are they trying to cast this to a float?
> - if (settings.scaling != aValue)
> + if (settings.scaling != aValue || settings.shrinkToFit)
Bug 505060 - [Print preview] Changing scale xx% -> shrink to fit -> xx% does not work.
Attachment #508119 -
Flags: review?
|
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 508119 [details] [diff] [review]
Patch v1.0 Kitchen Sink.
jag, up to reviewing a print preview patch? This just ports over all the toolkit patches that haven't been backported since the carboniferous.
Attachment #508119 -
Flags: review? → review?(jag-mozilla)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 508119 [details] [diff] [review]
Patch v1.0 Kitchen Sink.
Looks good to me.
Attachment #508119 -
Flags: review?(jag-mozilla) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
>> aValue /= 100;
> toolkit uses aValue /= 100.0; I'm not sure if this is needed. Are they trying
> to cast this to a float?
Neil, I didn't take this change from toolkit. Is there any advantage to this?
|
||
Comment 5•15 years ago
|
||
(In reply to comment #4)
> > > aValue /= 100;
> > toolkit uses aValue /= 100.0; I'm not sure if this is needed. Are they trying
> > to cast this to a float?
> Neil, I didn't take this change from toolkit. Is there any advantage to this?
Can't see any, JS has no true integer type.
|
|
Assignee | |
Comment 6•15 years ago
|
||
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/c45978ee2f61
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•