Closed
Bug 638552
Opened 13 years ago
Closed 13 years ago
Form Assistant suggestions should not reach into side pane
Categories
(Firefox for Android Graveyard :: General, defect, P3)
Tracking
(fennec2.0+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0+ | --- |
People
(Reporter: tarend, Assigned: vingtetun)
References
Details
(Whiteboard: [has patch][can land])
Attachments
(5 files)
(1) tap into any input field (make sure to "train" form assistant with a number of input values, so that suggestions come up) (2) swipe to the right, opening left panel Result: suggestions overlap with tabs (see screenshot) Expected: suggestions stay within content area
Updated•13 years ago
|
Assignee: nobody → 21
tracking-fennec: ? → 2.0+
Assignee | ||
Comment 1•13 years ago
|
||
The patch size the suggestions list to the a percentage the visible browser width. The patch also includes a few tweaks to when the suggestions container should be hidden when the target field is out of view (it was buggy)
Attachment #516748 -
Flags: review?(mbrubeck)
Updated•13 years ago
|
Attachment #516748 -
Flags: review?(mbrubeck) → review+
Updated•13 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [has patch][can land]
Assignee | ||
Comment 2•13 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/bcca55616295
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 3•13 years ago
|
||
verified fixed on build id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110304 Firefox/4.0b13pre Fennec /4.0b6pre
Status: RESOLVED → VERIFIED
Comment 4•13 years ago
|
||
in portrait mode are still problems. sorry for the last comment. It should be fixed I guess in tomorrow build, no Vivien?
Status: VERIFIED → RESOLVED
Closed: 13 years ago → 13 years ago
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to comment #4) > in portrait mode are still problems. sorry for the last comment. It should be > fixed I guess in tomorrow build, no Vivien? Yes, I've pushed those changes late this morning so they are not in the nightly.
Reporter | ||
Comment 6•13 years ago
|
||
This seems fixed in the 20110305 nightly, but I see new issues (see three attached screenshots): (1) when panning to the left: suggestions get gut off on the LEFT side - I may consider that acceptable, as users can simply pan back. But the behavior is inconsistent: when you pan to the right, you actually shorten the suggestion field to fit it in the visible content area (2) Changing screen orientation while suggestions are shown: places suggestions in wrong positions (should be pointing to input field) - this problem remains even if you turn back to portrait (3) Back in portrait mode: now we have TWO issues: the list is (still) in the wrong place, and it moves into the left panel
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 7•13 years ago
|
||
Reporter | ||
Comment 8•13 years ago
|
||
Reporter | ||
Comment 9•13 years ago
|
||
Comment 10•13 years ago
|
||
(In reply to comment #6) > This seems fixed in the 20110305 nightly, but I see new issues (see three > attached screenshots): if this bug is fixed, then file new bugs for the new issues you see and mark them blocking this one.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•13 years ago
|
||
Okay, I filed Bug 639330, Bug 639331 , and Bug 639333 and marked the blocking this one. I would argue that Bug 639333 shows the behavior that was supposed to be fixed with this one, which is why I had reopened it. Thanks!
Assignee | ||
Comment 12•13 years ago
|
||
(In reply to comment #11) > Okay, I filed Bug 639330, Bug 639331 , and Bug 639333 and marked the blocking > this one. I would argue that Bug 639333 shows the behavior that was supposed to > be fixed with this one, which is why I had reopened it. Thanks! Sorry, I thought to have done a comment here but I have done a mid-air collision with myself :/ Basically I've filed one bug (bug 639329) for your 3 screenshots with a patch. ---- Copy-pasting my comment for the record (In reply to comment #10) > (In reply to comment #6) > > This seems fixed in the 20110305 nightly, but I see new issues (see three > > attached screenshots): > > if this bug is fixed, then file new bugs for the new issues you see and mark > them blocking this one. I've filled bug 639329 (with a patch)
Comment 13•13 years ago
|
||
VERIFIED FIXED on: Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110315 Firefox/4.0b13pre Fennec /4.0b6pre Devices: Motorola Droid 2 (Android 2.2), HTC Desire (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•