Closed Bug 643265 Opened 13 years ago Closed 7 years ago

Multiple entry of master password required

Categories

(Thunderbird :: Security, defect)

Product:
Thunderbird
Component:
Security
Version:
38 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: t.rother, Unassigned)

References

(Blocks 1 open bug)

Details

Starting the TB 3.1.8, I need a three-fold entry of the master password. I tested in different situations

a) Nomal setup. Two imap accounts and three extensions: Deutsches Woerterbuch 2.0.2, Google Calendar Tab 3.5, Google Contacts 0.6.34
Result: three master password prompts

b) Two imap accounts and only one of the three extensions at a) activated
Result: two master password prompts

c) Two imap accounts and no  extensions
Result: one master password (correct behaviour)

It looks as if the extensions are requesting separate logins into the security module. The situation is the same, no matter which extension is active. Looks like a general bug in the extension integration, but on the side of TB, not on the extensions side ...
So what extensions do trigger this ?
These extensions are installed:
Deutsches Woerterbuch2.0.2, 
Google Calendar Tab 3.5, 
Google Contacts 0.6.34  https://addons.mozilla.org/de/thunderbird/addon/google-contacts/

I don't think that the "Wörterbuch" requests any authentfication. But the google extensions need to login into the google account. Google Contacts website shows no information abount login problems, I de-installed Google Calendar Tab 3.5 permanently now, but I still need three logins into the security module.I've seen similar bug reports for earlier tb releases, maybe this is a regression?

https://bugzilla.mozilla.org/show_bug.cgi?id=354658
https://bugzilla.mozilla.org/show_bug.cgi?id=549904
https://bugzilla.mozilla.org/show_bug.cgi?id=338549
https://bugzilla.mozilla.org/show_bug.cgi?id=349641
Please contact the extensions authors as the bug ois present in their code and not in Thunderbird Core.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Whiteboard: dupme
Ludo, Google Calendar tab does nothing but open a content tab with Thunderbird's tabmail, and it's Thunderbird code that's responsible for restoring content tabs, so in a way, I guess we're responsible for this failure (which I'm experiencing too, hence my reopening this bug).

CCing standard8 and asuth who might have thoughts about this.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Status: REOPENED → NEW
Whiteboard: dupme
Thunderbird 9 Still has not fixed this issue which has been open for many many years now. And StartupMaster, which was a workaround is incompatible with TB9. Why not just put the StartupMaster code into Thunderbird and solve this once and for all?
Hi,

I am forwarding my intervention from https://bugzilla.mozilla.org/show_bug.cgi?id=728654

aceman wrote:
> Alexandre, can you try to disable Google contact and Google Calendar?

I think that the point is (I don't know the source code) that every modules which requires an access to the security device call getSecurityInformation("key") -> "value";

And as the device is not yet opened, it opens many password prompt, you just have to make getSecurityInformation() a wrapper which checks:
 - if the security device is opened, then get the info
 - if the security device is being opened, then register to the "finished" event of the current password prompt
 - if the security device is not opened, then open it

I believe that it must be that simple. Anyway IMO it should not be possible to open many prompt at the same time to open the security device, because the security device API should do the necessary checks and synchronizations to prevent it.

So I think that I don't have to disable any add-on, because whatever the add-on I am going to install, I want my Mozilla products to prompt me 1 time at most.

Thanks.
Why can't you just incorporate StartupMaster into TB. It solves the problem!  This has gone on too long, and a solution is at hand!
(In reply to James Rome from comment #8)
> Why can't you just incorporate StartupMaster into TB. It solves the problem!
> This has gone on too long, and a solution is at hand!

James, I think we need to solve the problem at its root: the function which opens the security device, and I think that it could fix this bug for every Mozilla products at the same time.
Alexandre, I would be most happy to see you submit a patch since « [you] believe that it must be that simple. ». :-)

Thanks,

jonathan
Jonathan Protzenko [:protz] from comment #10)
> Alexandre, I would be most happy to see you submit a patch since « [you]
> believe that it must be that simple. ». :-)

Jonathan, ok if you can give me a hint where this code is, I'll try to patch it.
how is this different from bug 584014/bug 177175 ?
(In reply to Jonathan Protzenko [:protz] from comment #4)
> Ludo, Google Calendar tab does nothing but open a content tab with
> Thunderbird's tabmail, and it's Thunderbird code that's responsible for
> restoring content tabs, so in a way, I guess we're responsible for this
> failure (which I'm experiencing too, hence my reopening this bug).

then, is this not unlike bug 682474?
Flags: needinfo?(jonathan.protzenko)
Double negation. Tricky.

Yes, it could be the same issue, but I don't think I'm qualified to be sure of that.
Flags: needinfo?(jonathan.protzenko)
Blocks: 682474
Is this bug / bug 682474 a regression?
I have this problem too with both Thunderbird v24.2.0 (Portable as well as "normal" standalone on a different PC).
I was running Thunderbird with 4 IMAP email accounts and never saw this problem. Then I added the following Addons (configured to connect to my gmail account for its Google calendar and contact sync):
Google Contacts v0.7.12
Inverse SOGo Connector v24.0.2
Lightning v2.6.4
Provider for Google Calendar v0.25
ThunderBirthDay v0.8.0
Since the addons are installed and active (configured to store the passwords for those that require passwords) I get 3 Master Password entering dialogs on each start of Thunderbirg (immediately after starting it, no time delay etc.)
Same here in TB 38 (current beta)
BTW, I am on OS X, not Linux
OS: Linux → All
Hardware: x86_64 → All
Version: 3.1 → 38
Was fixed in 31.x, reappeared in 38.x.
Seems like a regression.
In my case Thunderbird asks at least 4 times the master password in the begin. Also, it asks for my Google Contacts password always even I marking "remember".
I'm using Thunderbird 38.3.0 on Mac OS X 10.10 and this problem has now appeared to me too. When starting Thunderbird, it asks me three times the Master Password before actually checking my email addresses. I have to add that I have just installed the Provider for Google Calendar plugin (version 1.0.4) and configured the Calendar in Thunderbird to synchronize to my Google Calendar.
Just for completeness: I'n not using any of the abovementioned plugins.
There has been no work done on this issue. Patches welcome.
Blocks: 1180374
Blocks: 653678
How can I help? I have this issue for several years. I can run debug version on my computer.
Blocks: 1176399
Depends on: 177175
Before last update Thunderbird (in February 2017) I didn't have problem with Master Password (Ubuntu 16.04). But now I have the same problem like above - multiple request password when I run Thunderbird.
I have a few email-account in Thunderbird. The Thunderbird request master password many times but I just enter password only one time and close other prompt' windows. That works correctly but not convenient.
In my case this problem is solved long ago (running current TB on OpenSuse and Windows 10), I had no similar issues then. Possible problem may come from additional code from extensions, but not from TB itself
Status: NEW → RESOLVED
Closed: 13 years ago → 7 years ago
Resolution: --- → FIXED
(In reply to Thommie Rother from comment #30)
> In my case this problem is solved long ago (running current TB on OpenSuse
> and Windows 10), I had no similar issues then. Possible problem may come
> from additional code from extensions, but not from TB itself

I have only two add-ons: "Enigmail" and "Messaging Menu and Unity Launcher integration" (default for Ubuntu). Both were more then month and Master Password worked great.
This will likely be fixed by bug 1176399 for people that are still experiencing this issue.
Resolution: FIXED → WORKSFORME
(In reply to Philipp Kewisch [:Fallen] from comment #32)
> This will likely be fixed by bug 1176399 for people that are still
> experiencing this issue.

Thanks Philipp, I really have Gmail OAuth accounts too (like described there: 1176399).
Now I disabled receiving mails at program start and bug was gone.
OK, let's wait for #1176399 then.

I don't have any OAuth accounts at all, and no google calendars, but still having the problem ... so I'm curious.
Resolution: WORKSFORME → FIXED
Thommie (hey mate ;)), can you say with certainty that this was FIXED? If yes, by which bug? On meta bug 570421, I still see open bugs with the same problem, e.g. bug 584014, so I think the maximum you could say for this bug is "WORKSFORME"...
(In reply to Thomas D. (currently busy elsewhere; needinfo?me) from comment #36)
> Thommie (hey mate ;)), can you say with certainty that this was FIXED? If
> yes, by which bug? On meta bug 570421, I still see open bugs with the same
> problem, e.g. bug 584014, so I think the maximum you could say for this bug
> is "WORKSFORME"...

This is clearly the effects of bug 1176399 which is in nightly builds starting 2017-04-12, and will be in beta 54. So "Fixed" is a good resolution for this bug unless there are many users for whom those versions don't fix their problem
I forgot about comment 30, which is why Thomas D was asking. I don't normally like doing this, but the bug has been marked up with dependencies and such on the assumption that everyone here is seeing the same problem, including Thommie. So I hate destroying that. Let's keep it at Fixed unless lot's of users don't get fixed.

As for bug 570421 and friends on the Firefox side, they clearly aren't going to make progress so we should just ignore them unless again we see lots of users not getting fixed.
You need to log in before you can comment on or make changes to this bug.