Closed
Bug 646229
Opened 14 years ago
Closed 14 years ago
Update ANGLE to r611 or newer
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 657748
People
(Reporter: joe, Assigned: joe)
References
Details
Attachments
(1 file, 1 obsolete file)
421.91 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
We need to update ANGLE to something newer than what we shipped in Firefox 4 so we can pick up the bugfixes they've done. Unfortunately this isn't 100% straightforward since it seems that we can't use r591, which starts using the D3D10 shader compiler, due to problems with the February 2010 DirectX SDK - just including D3DCompiler.h causes the build to fail. So this patch is an update to r598 with a separate backout of r591.
Attachment #522824 -
Flags: review?(bjacob)
Assignee | ||
Comment 1•14 years ago
|
||
Making its way through try: http://tbpl.mozilla.org/?tree=MozillaTry&rev=04ae17376d60
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → joe
Assignee | ||
Comment 2•14 years ago
|
||
Running locally, this fails a *lot* of WebGL conformance tests. Going to have to do some debugging here; probably not a "this week" task.
Assignee | ||
Comment 3•14 years ago
|
||
Oh, except I'm running what seems to be a pretty broken card w.r.t. WebGL; I'm not going to cry in despair until I see the Try results.
Assignee | ||
Comment 5•14 years ago
|
||
Results look good for this patch on try! So good, in fact, that we fail due to a test unexpectedly passing. This patch removes that special case for Windows XP.
Attachment #522904 -
Flags: review?(bjacob)
Comment 6•14 years ago
|
||
Comment on attachment 522904 [details] [diff] [review] canvas test now passes on Windows XP Awesome news!
Attachment #522904 -
Flags: review?(bjacob) → review+
Comment 7•14 years ago
|
||
Comment on attachment 522824 [details] [diff] [review] update angle to r598 No need to ask for review on this: nobody wants to review a 400K patch, everyone just trusts that this is just the diff from upstream + our buildsystem and NPOTB files; everyone will just want to trust you :-) I see that you updated README.mozilla, great.
Attachment #522824 -
Flags: review?(bjacob) → review+
Comment 8•14 years ago
|
||
ANGLE r609 is a performance improvement: we want that. ANGLE r605 fixes bug 623791.
Blocks: CVE-2011-1302
Summary: Update ANGLE to something newer than r550 → Update ANGLE to r609 or newer
Comment 9•14 years ago
|
||
ANGLE r606 also works around a severe Mac crash (thanks to Zhenyao from Google for pinging me about it)
Comment 10•14 years ago
|
||
ANGLE r611 is another fix we want to take, see bug 623791 comment 6.
Summary: Update ANGLE to r609 or newer → Update ANGLE to r611 or newer
Comment 11•14 years ago
|
||
Ah no, OK, r611 is: "Merging trunk revs 592, 593 and 605 to chrome_m10 branch" For Macaw, this means that we also want 592 and 593; alternatively it could well be that the chrome_m10 branch has exactly the kind of security fixes that we want in Macaw.
Assignee | ||
Comment 12•14 years ago
|
||
Comment on attachment 522904 [details] [diff] [review] canvas test now passes on Windows XP Bug 640887 shows that this wasn't correct.
Attachment #522904 -
Attachment is obsolete: true
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•