646229 - Update ANGLE to r611 or newer

Status: RESOLVED DUPLICATE of bug 657748

(Core :: Graphics: CanvasWebGL, defect)

Description

[Joe Drew (not getting mail)]

Attachment: update angle to r598

We need to update ANGLE to something newer than what we shipped in Firefox 4 so we can pick up the bugfixes they've done. Unfortunately this isn't 100% straightforward since it seems that we can't use r591, which starts using the D3D10 shader compiler, due to problems with the February 2010 DirectX SDK - just including D3DCompiler.h causes the build to fail. So this patch is an update to r598 with a separate backout of r591.

Comment 1

[Joe Drew (not getting mail)]

Making its way through try: http://tbpl.mozilla.org/?tree=MozillaTry&rev=04ae17376d60

Comment 2

[Joe Drew (not getting mail)]

Running locally, this fails a *lot* of WebGL conformance tests. Going to have to do some debugging here; probably not a "this week" task.

Comment 3

[Joe Drew (not getting mail)]

Oh, except I'm running what seems to be a pretty broken card w.r.t. WebGL; I'm not going to cry in despair until I see the Try results.

Comment 5

[Joe Drew (not getting mail)]

Attachment: canvas test now passes on Windows XP

Results look good for this patch on try! So good, in fact, that we fail due to a test unexpectedly passing. This patch removes that special case for Windows XP.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 522904 [details] [diff] [review]
canvas test now passes on Windows XP

Awesome news!

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 522824 [details] [diff] [review]
update angle to r598

No need to ask for review on this: nobody wants to review a 400K patch, everyone just trusts that this is just the diff from upstream + our buildsystem and NPOTB files; everyone will just want to trust you :-) I see that you updated README.mozilla, great.

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

ANGLE r609 is a performance improvement: we want that.

ANGLE r605 fixes bug 623791.

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

ANGLE r606 also works around a severe Mac crash (thanks to Zhenyao from Google for pinging me about it)

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

ANGLE r611 is another fix we want to take, see bug 623791 comment 6.

Comment 11

[Benoit Jacob [:bjacob] (mostly away)]

Ah no, OK, r611 is: "Merging trunk revs 592, 593 and 605 to chrome_m10 branch"

For Macaw, this means that we also want 592 and 593; alternatively it could well be that the chrome_m10 branch has exactly the kind of security fixes that we want in Macaw.

Comment 12

[Joe Drew (not getting mail)]

Comment on attachment 522904 [details] [diff] [review]
canvas test now passes on Windows XP

Bug 640887 shows that this wasn't correct.