663193 - Cannot attach non-file attachments from command line

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Ian Neal]

Steps to reproduce
1/ Try starting TB from commandline with following commmand:
thunderbird -compose attachment=http://www.google.co.uk/

Expected result
1/ TB opens with compose window and www.google.co.uk web page attached.

Actual result
1/ TB errors with message "An error occurred while creating a message compose window. Please try again." and then exits when acknowledged.

Note
There is an issue with sending non-ascii web pages but that is bug 663183

Comment 1

[Ian Neal]

This was initially fixed in SM in bug 617011 with additional work now happening in bug 662698 - I will look at porting those changes back to TB once review process has been completed on SM.

Comment 2

[Ian Neal]

Attachment: Port commandline attachment fix from SeaMonkey

This patch ports the fix from SeaMonkey bug 662698:
* Handles web page attachments from command line.
* Checks for file existence before attaching and if does not exist prompt.
* General code simplification.

Comment 3

[Ian Neal]

Comment on attachment 538791 [details] [diff] [review]
Port commandline attachment fix from SeaMonkey

Switching request as protz reviewed some of the code this is replacing

Comment 4

[Jonathan Protzenko [:protz]]

Hi Ian,

I fail to understand how this fixes "* Handles web page attachments from command line.". Is that implied by resolveURI? In that case, a comment would be welcome...

Comment 5

[Ian Neal]

(In reply to comment #4)
> Hi Ian,
> 
> I fail to understand how this fixes "* Handles web page attachments from
> command line.". Is that implied by resolveURI? In that case, a comment would
> be welcome...

A comment in here or a comment in the code?

Comment 6

[Ian Neal]

Attachment: Port commandline attachment fix from SeaMonkey with extra comments [Checked in: Comment 8]

Changes since last version:
* Extra comments to explain what resolveURI does.

Comment 7

[Jonathan Protzenko [:protz]]

Comment on attachment 540930 [details] [diff] [review]
Port commandline attachment fix from SeaMonkey with extra comments [Checked in: Comment 8]

Review of attachment 540930 [details] [diff] [review]:
-----------------------------------------------------------------

While I haven't tested this, it is small enough that I trust it works. Plus, it's a port from a Seamonkey bug.

Comment 8

[Ian Neal]

Comment on attachment 540930 [details] [diff] [review]
Port commandline attachment fix from SeaMonkey with extra comments [Checked in: Comment 8]

http://hg.mozilla.org/comm-central/rev/4d2abb43abcb