668494 - Highlight of mailboxes crosses the characters in high-DPI mode

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Tilman]

Attachment: tb5-2.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

Click on and/or hover over a mailbox


Actual results:

A rectangle is drawn that crosses the bottom of some characters (the "g"), see screenshot. I am using Windows 7 64.


Expected results:

The rectangles should not cross the characters

Comment 1

[Richard Marti (:Paenglab)]

Attachment: One line patch

I see this only with 125% font size.
This patch changes the height from px to em which scales the treechildren height according the font height.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Folderpane with font height 125% with patch

Comment 3

[rsx11m]

Yes, I didn't see it with normal settings using the Windows 7 default desktop theme either, thus didn't confirm this bug right away...

Comment 4

[Tilman]

(In reply to comment #1)
> Created attachment 543178 [details] [diff] [review] [review]
> One line patch
> 
> I see this only with 125% font size.
> This patch changes the height from px to em which scales the treechildren
> height according the font height.

Yes, it is true, I do use the 125% setting.

Sadly I can't test the patch because I can't find that "messenger-aero.css" file on my system.

Comment 5

[Richard Marti (:Paenglab)]

The messenger-aero.css is only in hg. In omni.jar search for messenger.css. The one in chrome\classic\skin\classic\aero\messenger is the right one.

Comment 6

[Tilman]

(In reply to comment #5)
> The messenger-aero.css is only in hg. In omni.jar search for messenger.css.
> The one in chrome\classic\skin\classic\aero\messenger is the right one.

Thanks, that works for me!
(Someone else with different screen settings might want to test whether the change works for 100% and for 150% setting)

Comment 7

[Tilman]

Attachment: Screenshot of patch suggestion with 125% - successful IMHO

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 543178 [details] [diff] [review]
One line patch

Review of attachment 543178 [details] [diff] [review]:
-----------------------------------------------------------------

This looks like it should fix it, so r=me.

But, before you close the bug, did we have similar issues in non-aero builds, or on Mac or Linux?

Thanks,
Blake.

Comment 10

[Jim Porter (:squib)]

Does this add a whole bunch of extra padding to the rows? That's what it seems like in the screenshots. I think we should try to avoid that if possible...

Comment 11

[Richard Marti (:Paenglab)]

(In reply to comment #9)
> But, before you close the bug, did we
> have similar issues in non-aero builds, or on Mac or Linux?

The problem was introduced with the Vista/Win7 treerow appearance. On XP I'm sure it works.

Comment 12

[Richard Marti (:Paenglab)]

(In reply to comment #10)
> Does this add a whole bunch of extra padding to the rows? That's what it
> seems like in the screenshots. I think we should try to avoid that if
> possible...

I've choosen the value which effects in the same height as before on default font size. With bigger fonts the rows are naturally heigher.

Comment 13

[Richard Marti (:Paenglab)]

Comment on attachment 543178 [details] [diff] [review]
One line patch

This is only a visual change and shouldn't harm the builds

Comment 14

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/9127a0af1ca2

Comment 15

[Rain [:rain1] (inactive)]

https://hg.mozilla.org/releases/comm-aurora/rev/2eb76e7ad17e
https://hg.mozilla.org/releases/comm-beta/rev/6b9136b01b0c

Comment 18

[Wayne Mery (:wsmwk)]

another person probably likes it :)
http://getsatisfaction.com/mozilla_messaging/tags/bug_668494